Review Request: Implicit dedication of resources to an account

2013-05-10 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11045/ --- Review request for cloudstack and Prachi Damle. Description --- Changes fo

Re: Review Request: Implicit dedication of resources to an account

2013-05-13 Thread Prachi Damle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11045/#review20520 --- Thanks for a clean patch and an extensive unit test. Have following

Re: Review Request: Implicit dedication of resources to an account

2013-05-15 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11045/ --- (Updated May 15, 2013, 2:08 p.m.) Review request for cloudstack and Prachi Daml

Re: Review Request: Implicit dedication of resources to an account

2013-05-15 Thread Devdeep Singh
> On May 14, 2013, 12:16 a.m., Prachi Damle wrote: > > Thanks for a clean patch and an extensive unit test. Have following review > > comments: > > > > 1) When we list the VMs on a host (List userVms = > > _vmDao.listByHostId(host);), also consider the VMs that are stopped on this > > host (l

Re: Review Request: Implicit dedication of resources to an account

2013-05-15 Thread Devdeep Singh
- Devdeep --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11045/#review20520 --- On May 15, 2013, 2:08 p.m., Devdeep Singh wrote: > > -

Re: Review Request: Implicit dedication of resources to an account

2013-05-15 Thread Prachi Damle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11045/#review20619 --- Ship it! The changes in the patch look good. Please also add an int

Re: Review Request: Implicit dedication of resources to an account

2013-05-16 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11045/ --- (Updated May 16, 2013, 1:14 p.m.) Review request for cloudstack and Prachi Daml

Re: Review Request: Implicit dedication of resources to an account

2013-05-16 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11045/ --- (Updated May 16, 2013, 1:15 p.m.) Review request for cloudstack and Prachi Daml