Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-24 Thread Dave Cahill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/ --- (Updated March 25, 2013, 4:02 a.m.) Review request for cloudstack, Hugo Trippaer

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-26 Thread Hiroaki Kawai
> On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote: > > server/src/com/cloud/network/NetworkManagerImpl.java, line 1773 > > > > > > NetworkElement should be always called after NetworkGuru, isn't it? > > Dave Cahill

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-26 Thread joe mills
> On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote: > > server/src/com/cloud/network/NetworkManagerImpl.java, line 1773 > > > > > > NetworkElement should be always called after NetworkGuru, isn't it? > > Dave Cahill

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-26 Thread Hiroaki Kawai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/#review18390 --- server/src/com/cloud/network/NetworkManagerImpl.java

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-26 Thread Dave Cahill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/ --- (Updated March 27, 2013, 6:33 a.m.) Review request for cloudstack, Hugo Trippaer

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-28 Thread Dave Cahill
Hi all, I think all review comments have been addressed on this, but review progress seems to have stalled - anything I should be doing to keep things moving? Thanks, Dave. On Wed, Mar 27, 2013 at 3:33 PM, Dave Cahill wrote: >This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-29 Thread Hugo Trippaers
Hey Dave, My "ship it" is waiting for a last compile and test run on my dev platform. I'll try to do that over the weekend. Cheers, Hugo Sent from my iPhone On 29 mrt. 2013, at 02:17, "Dave Cahill" mailto:dcah...@midokura.com>> wrote: Hi all, I think all review comments have been addresse

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-29 Thread Dave Cahill
Sounds great, thanks Hugo! On Fri, Mar 29, 2013 at 8:47 PM, Hugo Trippaers < htrippa...@schubergphilis.com> wrote: > Hey Dave, > > My "ship it" is waiting for a last compile and test run on my dev > platform. I'll try to do that over the weekend. > > Cheers, > > Hugo > > Sent from my iPhone

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-04-02 Thread Dave Cahill
Checking back in - any progress on this review? We're now at the 3 week point from initial submission. Hugo, is your Ship It (once test run completes) equivalent to a "commit now", or is there an additional review required? I don't see any other review activity, so I'm guessing you're the only one

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-04-03 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9898/#review18640 --- Ship it! Ship It! - Hugo Trippaers On March 27, 2013, 6:33 a.m.,

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-04-03 Thread Hugo Trippaers
> On April 3, 2013, 10:11 a.m., Hugo Trippaers wrote: > > Ship It! commit eddf7b9357bc18497b8cb16a6c6f3382ac52f61c Author: Dave Cahill Date: Mon Mar 25 10:56:13 2013 +0900 MidoNet Networking Plugin - Supports DHCP, Source NAT, Static NAT, Firewall rules, Port Forwarding - Rename

RE: Review Request: MidoNet Networking Plugin [2/2]

2013-04-03 Thread Hugo Trippaers
y, April 03, 2013 3:00 AM To: Hugo Trippaers Cc: Chiradeep Vittal; cloudstack; Hiroaki Kawai; joe mills Subject: Re: Review Request: MidoNet Networking Plugin [2/2] Checking back in - any progress on this review? We're now at the 3 week point from initial submission. Hugo, is your Ship I