Review Request 12180: Fix NPE when adding invalid primary datastore

2013-06-28 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12180/ --- Review request for cloudstack, Chip Childers, Devdeep Singh, Kelven Yang, and Sa

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

2013-06-28 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12180/ --- (Updated June 29, 2013, 12:48 a.m.) Review request for cloudstack, Chip Childer

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

2013-06-29 Thread Sateesh Chodapuneedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12180/#review22562 --- engine/storage/volume/src/org/apache/cloudstack/storage/datastore/m

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

2013-06-29 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12180/#review22563 --- engine/storage/volume/src/org/apache/cloudstack/storage/datastore/m

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

2013-06-29 Thread Sateesh Chodapuneedi
> On June 29, 2013, 7:33 a.m., Prasanna Santhanam wrote: > > engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java, > > line 59 > > > > > > This block should

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

2013-07-02 Thread Venkata Siva Vijayendra Bhamidipati
> On June 29, 2013, 7:33 a.m., Prasanna Santhanam wrote: > > engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java, > > line 59 > > > > > > This block should

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

2013-07-02 Thread Venkata Siva Vijayendra Bhamidipati
> On June 29, 2013, 7:24 a.m., Sateesh Chodapuneedi wrote: > > engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java, > > line 61 > > > > > > LGTM. > > C

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

2013-07-02 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12180/ --- (Updated July 3, 2013, 12:25 a.m.) Review request for cloudstack, Chip Childers

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

2013-07-03 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12180/#review22715 --- Ship it! applied to master and 4.2 - Chip Childers On July 3, 20