Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

2013-11-09 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12192/#review28615 --- Ship it! 3fd95fe231bdde6045b81fae0f6ff1bd4c2c0918 - daan Hoogland

Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

2013-11-07 Thread Amogh Vasekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12192/#review28418 --- Reminder- Hi, The review has been pending for long. Please update

Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

2013-08-01 Thread Sanjay Tripathi
On July 2, 2013, 7:11 a.m., daan Hoogland wrote: Your change seems fine. Did you regression test it? Or did you solve a problem with it? Dave Brosius wrote: Just noticed during code inspection Dave, can you also open a ticket for this and mention your review request in the

Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

2013-07-31 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12192/#review24405 --- Review 12192 failed the build test : FAILURE The url of build

Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

2013-06-29 Thread Dave Brosius
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12192/ --- Review request for cloudstack. Repository: cloudstack-git Description