RE: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-17 Thread Musayev, Ilya
nkata Siva Vijayendra Bhamidipati; cloudstack > Subject: Re: Review Request 12612: Fix NPE when attaching vmware-tools iso > to guest VM on ESX > > > > > On July 17, 2013, 11:57 p.m., Sheng Yang wrote: > > > Ship It! > > Pushed t

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-17 Thread Sheng Yang
> On July 17, 2013, 11:57 p.m., Sheng Yang wrote: > > Ship It! Pushed to MASTER and 4.2 Thanks! -Sheng - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12612/#review23347 ---

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-17 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12612/#review23347 --- Ship it! Ship It! - Sheng Yang On July 17, 2013, 11:54 p.m., Ven

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-17 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12612/ --- (Updated July 17, 2013, 11:54 p.m.) Review request for cloudstack, Chip Childer

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-17 Thread Venkata Siva Vijayendra Bhamidipati
> On July 17, 2013, 12:24 a.m., Sheng Yang wrote: > > server/src/com/cloud/template/TemplateManagerImpl.java, line 999 > > > > > > How can this happen?? Add Min Chen in reviewer. > > Venkata Siva Vijayendra Bhamidipat

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-17 Thread Sheng Yang
> On July 17, 2013, 12:24 a.m., Sheng Yang wrote: > > server/src/com/cloud/template/TemplateManagerImpl.java, line 999 > > > > > > How can this happen?? Add Min Chen in reviewer. > > Venkata Siva Vijayendra Bhamidipat

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-17 Thread Venkata Siva Vijayendra Bhamidipati
> On July 17, 2013, 12:24 a.m., Sheng Yang wrote: > > server/src/com/cloud/template/TemplateManagerImpl.java, line 999 > > > > > > How can this happen?? Add Min Chen in reviewer. > > Venkata Siva Vijayendra Bhamidipat

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-17 Thread Min Chen
> On July 17, 2013, 12:24 a.m., Sheng Yang wrote: > > server/src/com/cloud/template/TemplateManagerImpl.java, line 999 > > > > > > How can this happen?? Add Min Chen in reviewer. > > Venkata Siva Vijayendra Bhamidipat

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-16 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12612/ --- (Updated July 17, 2013, 12:39 a.m.) Review request for cloudstack, Chip Childer

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-16 Thread Venkata Siva Vijayendra Bhamidipati
> On July 17, 2013, 12:24 a.m., Sheng Yang wrote: > > plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java, > > line 875 > > > > > > need proper indent Hmm, thanks for catching that.

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-16 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12612/#review23217 --- plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSto

Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

2013-07-16 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12612/ --- Review request for cloudstack, Chip Childers, edison su, Kelven Yang, Sateesh Ch