Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-18 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/ --- Review request for cloudstack and Devdeep Singh. Bugs: 3382 Repository: cloud

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-18 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/#review23372 --- Do you think you can add a integration test to test_explicit_dedicat

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-18 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/#review23375 --- Few comments: 1. You need to handle when migration with storage is t

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-19 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/ --- (Updated July 19, 2013, 11:52 a.m.) Review request for cloudstack and Devdeep S

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-19 Thread Saksham Srivastava
> On July 18, 2013, 11:09 a.m., Prasanna Santhanam wrote: > > Do you think you can add a integration test to test_explicit_dedication.py > > for this failure? That would be really useful to catch this part of tricky > > code Prasanna the changes I have made are specifically related to alert ge

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-21 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/#review23611 --- server/src/com/cloud/vm/UserVmManagerImpl.java

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-21 Thread Jenkins Cloudstack.org
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/#review23612 --- Review 12720 failed the build test : FAILURE The url of build clouds

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-22 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/ --- (Updated July 22, 2013, 11:28 a.m.) Review request for cloudstack and Devdeep S

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-22 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/ --- (Updated July 22, 2013, 11:28 a.m.) Review request for cloudstack and Devdeep S

Re: Review Request 12720: CLOUDSTACK: 3382 Unable to Migrate VM's If the hosts are implicitly or explicitly dedicated.

2013-07-23 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12720/#review23682 --- Ship it! Committed to 4.2 and master in commits e2f2bc5f0 and 89b94