Re: Review Request 13938: StringUtils csv methods simplified

2013-11-21 Thread Amogh Vasekar
> On Oct. 4, 2013, 5:24 p.m., Darren Shepherd wrote: > > utils/src/com/cloud/utils/StringUtils.java, line 79 > > > > > > This is not actually correct, the previous code would do a trim() and > > the new code also can i

Re: Review Request 13938: StringUtils csv methods simplified

2013-10-04 Thread Darren Shepherd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13938/#review26676 --- utils/src/com/cloud/utils/StringUtils.java

Re: Review Request 13938: StringUtils csv methods simplified

2013-09-03 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13938/ --- (Updated Sept. 3, 2013, 7:22 a.m.) Review request for cloudstack and Prachi Dam

Re: Review Request 13938: StringUtils csv methods simplified

2013-09-03 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13938/ --- (Updated Sept. 3, 2013, 7:22 a.m.) Review request for cloudstack and Prachi Dam

Re: Review Request 13938: StringUtils csv methods simplified

2013-09-02 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13938/#review25845 --- After from that whitespace character, Looks good to me. utils/test

Review Request 13938: StringUtils csv methods simplified

2013-09-02 Thread Laszlo Hornyak
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13938/ --- Review request for cloudstack and Prachi Damle. Repository: cloudstack-git De