Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller

2013-09-18 Thread Nguyen Anh Tu
2013/9/18 Daan Hoogland > It looks allright but I cannot judge this code without seeing it work. I > hope Hugo or Sebastien can approve it. Yah. About rebase code, I tried to rebase my sdnextensions with 4.1 branch, but there are so many conflict need to fix manually. Do you have any tips to do

Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller

2013-09-18 Thread Daan Hoogland
/me know your pain, I am feeling it on a long standing change right now. The pain needs to be felt and should lead to better modularization of the code. Having some regression tests in place that will force other committers to take into account the code you depend on is one thing. This won't help y

Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller

2013-09-18 Thread Daan Hoogland
h Nguyen, It looks allright but I cannot judge this code without seeing it work. I hope Hugo or Sebastien can approve it. regards, Daan On Tue, Sep 17, 2013 at 12:04 PM, Nguyen Anh Tu wrote: > Hi guys, I made an update patch, which aim to remove commented code and > old files. Please review i

Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller

2013-09-17 Thread Nguyen Anh Tu
Hi guys, I made an update patch, which aim to remove commented code and old files. Please review it 2013/9/17 tuna >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14167/ > > On September 17th, 2013, 8:24 a.m. UTC, *daan Hoogland* wrote: > > Do you

Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller

2013-09-17 Thread tuna
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14167/ --- (Updated Sept. 17, 2013, 10:03 a.m.) Review request for cloudstack, Sebastien G

Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller

2013-09-17 Thread tuna
On Sept. 17, 2013, 8:24 a.m., tuna wrote: > > Do you have any (unit-)tests or #!human test scenarios to validate your > > code? I haven't made unit tests yet. Will do asap. Just try with my own scenarios. - tuna --- This is an automati

Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller

2013-09-17 Thread tuna
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14167/#review26170 --- api/src/com/cloud/network/Networks.java

Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller

2013-09-17 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14167/#review26169 --- api/src/com/cloud/network/Networks.java

Review Request 14167: [GSoC] Adding LB, PF service to GRE controller

2013-09-16 Thread tuna
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14167/ --- Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repositor