----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14217/ -----------------------------------------------------------
Review request for cloudstack and Alex Huang. Repository: cloudstack-git Description ------- In order to modularize ACS all extension points need to support incrementally adding the extensible items. The Configurables will be loaded in a different context and then added to the ConfigDepotAdmin. This means ConfigDepotImpl can't just rely on injection to find all Configurables as injection will only find the configurables in the current and parent contexts but not in child contexts. Diffs ----- framework/config/src/org/apache/cloudstack/framework/config/ConfigDepotAdmin.java b4d3773 framework/config/src/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java b516596 framework/config/test/org/apache/cloudstack/framework/config/impl/ConfigDepotAdminTest.java 1c5fbe5 Diff: https://reviews.apache.org/r/14217/diff/ Testing ------- Thanks, Darren Shepherd