Re: Review Request 14467: fix for Invalid SMTP breaks HA

2013-10-21 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14467/ --- (Updated Oct. 21, 2013, 8:31 a.m.) Review request for cloudstack and Devdeep Si

Re: Review Request 14467: fix for Invalid SMTP breaks HA

2013-10-21 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14467/ --- (Updated Oct. 21, 2013, 8:29 a.m.) Review request for cloudstack and Devdeep Si

Re: Review Request 14467: fix for Invalid SMTP breaks HA

2013-10-18 Thread Likitha Shetty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14467/#review27181 --- Changes have been committed to 4.2. But the patch doesn't clean appl

Re: Review Request 14467: fix for Invalid SMTP breaks HA

2013-10-18 Thread Likitha Shetty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14467/#review27180 --- Ship it! Ship It! - Likitha Shetty On Oct. 3, 2013, 11:31 a.m.,

Re: Review Request 14467: fix for Invalid SMTP breaks HA

2013-10-04 Thread Chip Childers
On Fri, Oct 4, 2013 at 2:17 AM, Anshul Gangwar wrote: > On Thursday 03 October 2013 08:44 PM, Chip Childers wrote: > > On Thu, Oct 03, 2013 at 11:31:50AM +, Anshul Gangwar wrote: > >> Description > >> --- > >> > >> added the connection and socket timeout parameters for SMTP and sending > m

Re: Review Request 14467: fix for Invalid SMTP breaks HA

2013-10-03 Thread Anshul Gangwar
On Thursday 03 October 2013 08:44 PM, Chip Childers wrote: > On Thu, Oct 03, 2013 at 11:31:50AM +, Anshul Gangwar wrote: >> Description >> --- >> >> added the connection and socket timeout parameters for SMTP and sending >> message in new thread so that HA doesn't get blocked beacause of h

Re: Review Request 14467: fix for Invalid SMTP breaks HA

2013-10-03 Thread Chip Childers
On Thu, Oct 03, 2013 at 11:31:50AM +, Anshul Gangwar wrote: > Description > --- > > added the connection and socket timeout parameters for SMTP and sending > message in new thread so that HA doesn't get blocked beacause of hang in > sending email alert Wouldn't a better approach be to e

Review Request 14467: fix for Invalid SMTP breaks HA

2013-10-03 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14467/ --- Review request for cloudstack and Devdeep Singh. Bugs: https://issues.apache.or