Re: Review Request 15175: Added a verifyElementInList utility function

2013-11-08 Thread Girish Shilamkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28513 --- 4.2: b18e730108e6a24e00c372e3c56c655ff51106ba - Girish Shilamkar

Re: Review Request 15175: Added a verifyElementInList utility function

2013-11-04 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28085 --- Easier to do if a in [1,2,3]: , no? - Prasanna Santhanam On Nov.

Re: Review Request 15175: Added a verifyElementInList utility function

2013-11-04 Thread Santhosh Edukulla
On Nov. 4, 2013, 8:21 a.m., Prasanna Santhanam wrote: Easier to do if a in [1,2,3]: , no? 1. Purpose is to check whether the input is list and whether it is empty as well. 2. If it is not a list, then a in None will lead to exception. 3. Purpose is also to provide a generic api to check

Re: Review Request 15175: Added a verifyElementInList utility function

2013-11-04 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28088 --- Just thinking aloud, could we not provide customized-assert for

Re: Review Request 15175: Added a verifyElementInList utility function

2013-11-04 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28089 --- Also your patch failed to apply for me on latest master:

Re: Review Request 15175: Added a verifyElementInList utility function

2013-11-04 Thread Santhosh Edukulla
On Nov. 4, 2013, 8:48 a.m., Prasanna Santhanam wrote: Also your patch failed to apply for me on latest master: ~/workspace/cloudstack/incubator-cloudstack(branch:master) ยป git am patch/element.patch Applying: Added a verifyElementInList utility function

Re: Review Request 15175: Added a verifyElementInList utility function

2013-11-04 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28095 --- Ship it! Ship It! - Santhosh Edukulla On Nov. 1, 2013, 7:44

Review Request 15175: Added a verifyElementInList utility function

2013-11-01 Thread Santhosh Edukulla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/ --- Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.