Re: Review Request 16361: CLOUDSTACK-5535: Do not allow addNetwork to create NIC across VPC tiers and Isolated Networks

2014-01-13 Thread Saksham Srivastava
> On Jan. 9, 2014, 6:22 p.m., Alena Prokharchyk wrote: > > Saksham, > > > > The patch fails on 4.3 branch with the error: > > > > Applying: CLOUDSTACK-5535 : Do not allow addNetwork to create NIC across > > VPC tiers and Isolated Networks > > error: patch failed: server/src/com/cloud/vm/UserVm

Re: Review Request 16361: CLOUDSTACK-5535: Do not allow addNetwork to create NIC across VPC tiers and Isolated Networks

2014-01-09 Thread Marcus Sorensen
> On Jan. 9, 2014, 6:22 p.m., Alena Prokharchyk wrote: > > Saksham, > > > > The patch fails on 4.3 branch with the error: > > > > Applying: CLOUDSTACK-5535 : Do not allow addNetwork to create NIC across > > VPC tiers and Isolated Networks > > error: patch failed: server/src/com/cloud/vm/UserVm

Re: Review Request 16361: CLOUDSTACK-5535: Do not allow addNetwork to create NIC across VPC tiers and Isolated Networks

2014-01-09 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16361/#review31444 --- Saksham, The patch fails on 4.3 branch with the error: Applying: C

Re: Review Request 16361: CLOUDSTACK-5535: Do not allow addNetwork to create NIC across VPC tiers and Isolated Networks

2014-01-09 Thread Alena Prokharchyk
> On Jan. 9, 2014, 12:39 a.m., Alena Prokharchyk wrote: > > One more check is needed: don't let to add vm to VPC network if its already > > a part of another VPC network. > > Saksham Srivastava wrote: > This check is already in place unless I am missing something: > if (existingNetwork.

Re: Review Request 16361: CLOUDSTACK-5535: Do not allow addNetwork to create NIC across VPC tiers and Isolated Networks

2014-01-09 Thread Saksham Srivastava
> On Jan. 9, 2014, 12:39 a.m., Alena Prokharchyk wrote: > > One more check is needed: don't let to add vm to VPC network if its already > > a part of another VPC network. This check is already in place unless I am missing something: if (existingNetwork.getVpcId() != null && network.getGuestType

Re: Review Request 16361: CLOUDSTACK-5535: Do not allow addNetwork to create NIC across VPC tiers and Isolated Networks

2014-01-08 Thread Alena Prokharchyk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16361/#review31417 --- One more check is needed: don't let to add vm to VPC network if its

Review Request 16361: CLOUDSTACK-5535: Do not allow addNetwork to create NIC across VPC tiers and Isolated Networks

2013-12-18 Thread Saksham Srivastava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16361/ --- Review request for cloudstack and Alena Prokharchyk. Bugs: CLOUDSTACK-5535