Re: Review Request 18733: Refactor DbUpgradeUtils

2014-03-06 Thread daan Hoogland
On March 4, 2014, 7:49 p.m., daan Hoogland wrote: tests fail: Running com.cloud.upgrade.dao.DatabaseAccessObjectTest Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.139 sec FAILURE! Running com.cloud.upgrade.dao.DbUpgradeUtilsTest Tests run: 2, Failures: 0,

Re: Review Request 18733: Refactor DbUpgradeUtils

2014-03-06 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18733/#review36356 --- Ship it! ea0dec77d98e14e47ca715c46cd0316faa37844c (not that

Review Request 18733: Refactor DbUpgradeUtils

2014-03-04 Thread Miguel Ferreira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18733/ --- Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo

Re: Review Request 18733: Refactor DbUpgradeUtils

2014-03-04 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18733/#review36151 --- tests fail: Running com.cloud.upgrade.dao.DatabaseAccessObjectTest