Review Request 19034: Assigning LB rule to vm nic secondary ip

2014-03-11 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19034/ --- Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, Kishan Kava

Re: Review Request 19034: Assigning LB rule to vm nic secondary ip

2014-03-14 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19034/#review37257 --- api/src/com/cloud/network/lb/LoadBalancingRulesService.java

Re: Review Request 19034: Assigning LB rule to vm nic secondary ip

2014-03-20 Thread Jayapal Reddy
> On March 14, 2014, 7:38 p.m., Chiradeep Vittal wrote: > > api/src/com/cloud/network/lb/LoadBalancingRulesService.java, line 97 > > > > > > HoW ABOUT DESCRIBING THE ADDITIONAL PARAMETER IN THE COMMENTS updated the com

Re: Review Request 19034: Assigning LB rule to vm nic secondary ip

2014-03-24 Thread Jayapal Reddy
> On March 14, 2014, 7:38 p.m., Chiradeep Vittal wrote: > > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java, line 984 > > > > > > where is the test for this? Added test - Jayapal ---