Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review47133 --- Thanks! Also, thanks for opening a JIRA ticket. We can track this go

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On July 1, 2014, 6:19 p.m., Mike Tutkowski wrote: > > http://i.imgur.com/PW7lqbs.png > > > > Six fields have been removed from the volume_view and five of those six are > > still in use. Hi Mike, Thank you for let me know. I reproduced the issue. It seems this commit made change to the sche

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review47114 --- http://i.imgur.com/PW7lqbs.png Six fields have been removed from th

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review47040 --- Hi Noji, Is it possible for you to take a look at this issue? If y

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review47037 --- It looks like we're missing two columns in volume_view: +vm

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review40019 --- Ship it! Ship It! - Marcus Sorensen On April 9, 2014, 10:58 p.m.

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On April 10, 2014, 3:29 p.m., Marcus Sorensen wrote: > > Ship It! commit 11f5bdd78de4121331b07995800f6e9e7c22f2c0 Author: Marcus Sorensen Date: Thu Apr 10 09:23:04 2014 -0600 CLOUDSTACK-6191 Add support for specifying volume provisioning type (thin, sparse, fat) in disk/compute off

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review40017 --- Commit 11f5bdd78de4121331b07995800f6e9e7c22f2c0 in cloudstack's bran

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On April 10, 2014, 5:55 a.m., Marcus Sorensen wrote: > > I verified that CLVM, Local, and NFS storage all work. From the agent side > > the code looks fine. I'll defer to Mike regarding the offering changes > > since he's done some work there before. The Disk Offering logic seems to follow o

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review39986 --- I verified that CLVM, Local, and NFS storage all work. From the agen

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On April 10, 2014, 12:16 a.m., Marcus Sorensen wrote: > > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java, > > line 1270 > > > > > > Building to test now. > > > >

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review39968 --- engine/orchestration/src/org/apache/cloudstack/engine/orchestration

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/ --- (Updated April 9, 2014, 10:58 p.m.) Review request for cloudstack, Mike Tutkows

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On March 28, 2014, 1:46 a.m., Mike Tutkowski wrote: > > api/src/com/cloud/storage/Storage.java, line 94 > > > > > > Not a big deal, but do we want to maybe make constants for "thin", > > "sparse" and "fat" and use th

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On March 28, 2014, 12:33 a.m., Mike Tutkowski wrote: > > api/src/com/cloud/offering/DiskOffering.java, line 66 > > > > > > By the way, it would really benefit CloudStack if we were to come up > > with a generic way o

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On March 28, 2014, 12:19 a.m., Mike Tutkowski wrote: > > api/src/com/cloud/offering/DiskOffering.java, line 20 > > > > > > I haven't had a chance to look through your code yet, but have some > > high-level questions.

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On March 27, 2014, 11:27 p.m., Marcus Sorensen wrote: > > So far I'm getting this. I want to go back and test without the patch, > > because with LVM it should be 'lvcreate' follwed by 'qemu-img convert', and > > I want to see if it's due to the patch, or another change: > > > > 2014-03-27 1

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On March 27, 2014, 11:41 p.m., Marcus Sorensen wrote: > > I'm also seeing some strange behavior on normal qcow2 (local) storage. When > > it is installing the template to primary storage, in the past it has > > detected we are going from qcow2 to qcow2 and simply copies the image > > rather

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review38862 --- api/src/com/cloud/storage/Storage.java

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review38855 --- api/src/com/cloud/offering/DiskOffering.java

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review38853 --- api/src/com/cloud/offering/DiskOffering.java

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review38852 --- I have verified that LVM still works without this patch. - Marcus S

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review38845 --- I'm also seeing some strange behavior on normal qcow2 (local) storag

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On March 27, 2014, 11:27 p.m., Marcus Sorensen wrote: > > So far I'm getting this. I want to go back and test without the patch, > > because with LVM it should be 'lvcreate' follwed by 'qemu-img convert', and > > I want to see if it's due to the patch, or another change: > > > > 2014-03-27 1

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On March 27, 2014, 11:27 p.m., Marcus Sorensen wrote: > > So far I'm getting this. I want to go back and test without the patch, > > because with LVM it should be 'lvcreate' follwed by 'qemu-img convert', and > > I want to see if it's due to the patch, or another change: > > > > 2014-03-27 1

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review38838 --- So far I'm getting this. I want to go back and test without the patc

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/ --- (Updated March 26, 2014, 11:24 p.m.) Review request for cloudstack, Mike Tutkow

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

> On March 21, 2014, 5:08 a.m., Marcus Sorensen wrote: > > Looks good for the most part, however due to the major changes in > > LibvirtStorageAdaptor I'd like to run through some testing (particularly on > > LVM). It may take me a few days to get to that. Mike may also want to chime > > in si

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review38122 --- engine/orchestration/pom.xml

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/ --- (Updated March 21, 2014, 5:02 p.m.) Review request for cloudstack, Mike Tutkows

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review38055 --- Looks good for the most part, however due to the major changes in L

Re: Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/#review38053 --- engine/orchestration/pom.xml

Review Request 19446: CLOUDSTACK-6191: Volume provisioning type option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19446/ --- Review request for cloudstack, Mike Tutkowski, Marcus Sorensen, and Wido den Hol