Re: Review Request 19460: Check for returned null, throw exception rather than continue.

2014-03-20 Thread Alex Hitchins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19460/ --- (Updated March 20, 2014, 2:42 p.m.) Review request for cloudstack. Changes --

Re: Review Request 19460: Check for returned null, throw exception rather than continue.

2014-03-20 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19460/#review37891 --- Ship it! Ship It! - Chris Suich On March 20, 2014, 2:42 p.m., Al

Re: Review Request 19460: Check for returned null, throw exception rather than continue.

2014-03-20 Thread Alex Hitchins
> On March 20, 2014, 1:29 p.m., Chris Suich wrote: > > It looks like VolumeServiceImpl.takeSnapshot() is the method who isn't > > properly handling the exception. It is also called from multiple places > > (namely VolumeApiServiceImpl.takeSnapshot() and > > VolumeApiServiceImpl.orchestrateTake

Re: Review Request 19460: Check for returned null, throw exception rather than continue.

2014-03-20 Thread Chris Suich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19460/#review37881 --- It looks like VolumeServiceImpl.takeSnapshot() is the method who isn

Review Request 19460: Check for returned null, throw exception rather than continue.

2014-03-20 Thread Alexander Hitchins
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19460/ --- Review request for cloudstack. Repository: cloudstack-git Description ---