Re: Review Request 22717: refactor StoragePoolAllocator#filter logic

2014-07-07 Thread Mike Tutkowski
I found one issue related to this change. I had to amend the logic in the filter method of AbstractStoragePoolAllocator to include a check for HypervisorType.Any (otherwise zone-wide storage with the type of Any is skipped, which is what's happening to me right now): } else if (pool.getHyp

Re: Review Request 22717: refactor StoragePoolAllocator#filter logic

2014-06-27 Thread Mike Tutkowski
> On June 26, 2014, 11:46 p.m., Mike Tutkowski wrote: > > I first had a chance to run this patch through a sophisticated test tonight > > and noticed an issue with zone-wide primary storage that's based on the > > iSCSI protocol. > > > > This patch leads to iSCSI storage being filtered out for

Re: Review Request 22717: refactor StoragePoolAllocator#filter logic

2014-06-26 Thread Yoshikazu Nojima
> On June 27, 2014, 5:46 a.m., Mike Tutkowski wrote: > > I first had a chance to run this patch through a sophisticated test tonight > > and noticed an issue with zone-wide primary storage that's based on the > > iSCSI protocol. > > > > This patch leads to iSCSI storage being filtered out for

Re: Review Request 22717: refactor StoragePoolAllocator#filter logic

2014-06-26 Thread Mike Tutkowski
> On June 26, 2014, 11:46 p.m., Mike Tutkowski wrote: > > I first had a chance to run this patch through a sophisticated test tonight > > and noticed an issue with zone-wide primary storage that's based on the > > iSCSI protocol. > > > > This patch leads to iSCSI storage being filtered out for

Re: Review Request 22717: refactor StoragePoolAllocator#filter logic

2014-06-26 Thread Yoshikazu Nojima
> On June 27, 2014, 5:46 a.m., Mike Tutkowski wrote: > > I first had a chance to run this patch through a sophisticated test tonight > > and noticed an issue with zone-wide primary storage that's based on the > > iSCSI protocol. > > > > This patch leads to iSCSI storage being filtered out for

Re: Review Request 22717: refactor StoragePoolAllocator#filter logic

2014-06-26 Thread Mike Tutkowski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22717/#review46838 --- I first had a chance to run this patch through a sophisticated test

Review Request 22717: refactor StoragePoolAllocator#filter logic

2014-06-17 Thread Yoshikazu Nojima
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22717/ --- Review request for cloudstack, Mike Tutkowski and Prachi Damle. Repository: clo