Re: Review Request 22727: CLOUDSTACK-6847 . Link.java and ConsoleProxySecureServerFactoryImpl.java have hardcoded value

2014-06-20 Thread upendra moturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22727/ --- (Updated June 20, 2014, 10:02 a.m.) Review request for cloudstack and daan

Re: Review Request 22727: CLOUDSTACK-6847 . Link.java and ConsoleProxySecureServerFactoryImpl.java have hardcoded value

2014-06-20 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22727/#review46261 --- looks good, changes in 'tests' stuff needs to be tested - Rohit

Re: Review Request 22727: CLOUDSTACK-6847 . Link.java and ConsoleProxySecureServerFactoryImpl.java have hardcoded value

2014-06-20 Thread daan Hoogland
On June 20, 2014, 10:04 a.m., Rohit Yadav wrote: looks good, changes in 'tests' stuff needs to be tested please explain Rohit, Upendra didn't upload any changes to tests. - daan --- This is an automatically generated e-mail. To

Re: Review Request 22727: CLOUDSTACK-6847 . Link.java and ConsoleProxySecureServerFactoryImpl.java have hardcoded value

2014-06-20 Thread daan Hoogland
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22727/#review46264 --- Ship it! 918c320438980f070150f872e3a3ba907572af83 in master -

Re: Review Request 22727: CLOUDSTACK-6847 . Link.java and ConsoleProxySecureServerFactoryImpl.java have hardcoded value

2014-06-20 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22727/#review46263 --- Commit 918c320438980f070150f872e3a3ba907572af83 in cloudstack's