Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52853 --- Ship it! Thanks. I merged them on 4.3 and master, sent out request

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

> On Sept. 10, 2014, 10:29 a.m., Rohit Yadav wrote: > > Just want to check with other reviewers, if this contribution is good to > > merge on master? Bharat, if you may confirm that it is well tested on > > Xen/KVM? The fix looks correct and it can be merged. The issue was that with custom of

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52852 --- Ship it! Ship It! - Devdeep Singh On Sept. 8, 2014, 1:55 p.m., b

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52846 --- Just want to check with other reviewers, if this contribution is goo

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/ --- (Updated Sept. 8, 2014, 1:55 p.m.) Review request for cloudstack, Alena Prokhar

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

> On Sept. 8, 2014, 11:39 a.m., Rohit Yadav wrote: > > LGTM Additional notes: this looks like there are other methods in VirtualMachineManagerImpl.java that can possibly have the same issue. One way is that we do set service offering in VirtualMachineProfileImpl() contructor from passed vm ob

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52582 --- Ship it! LGTM - Rohit Yadav On Sept. 8, 2014, 10:52 a.m., bharat

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52581 --- Looks good, have you tested it with Xen, KVM? What was the issue cau

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

> On Sept. 8, 2014, 9:27 a.m., Rohit Yadav wrote: > > server/src/com/cloud/server/ManagementServerImpl.java, lines 1160-1161 > > > > > > Why not fix VirtualMachineProfileImpl constructor where we're passing > > the o

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/ --- (Updated Sept. 8, 2014, 10:52 a.m.) Review request for cloudstack and Koushik D

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52578 --- engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.jav

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52577 --- engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.ja

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52576 --- server/src/com/cloud/server/ManagementServerImpl.java

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/#review52575 --- server/src/com/cloud/server/ManagementServerImpl.java

Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25430/ --- Review request for cloudstack and Koushik Das. Bugs: CLOUDSTACK-6099 https: