Re: Squeeze another PR (#2398) in 4.11 milestone

.apache.org Subject: Squeeze another PR (#2398) in 4.11 milestone Hi community We've found [1] and fixed [2] an issue in 4.10 regarding snapshots remaining on primary storage (XenServer + Swift) which causes VDI chain gets full after some time and user cannot take another snapshot. Please incl

Re: Squeeze another PR (#2398) in 4.11 milestone

Rafael, It got changed on this PR: https://github.com/apache/cloudstack/pull/1749/files#diff-6eeb1a2fb818cccb14785ee80c93a561R560 On Tue, Jan 9, 2018 at 4:44 PM, Khosrow Moossavi wrote: > That is correct Mike. The quoted part above was misleading, it should have > been "at any given point in

Re: Squeeze another PR (#2398) in 4.11 milestone

That is correct Mike. The quoted part above was misleading, it should have been "at any given point in time *when transaction finished*" Removal of "other" or "current failed" snapshot happens at the very end of the method. The state of SR throughout time would be something like: 1) snapshot-01 (a

Re: Squeeze another PR (#2398) in 4.11 milestone

Yes. That is actually what we do. Looking at the code of "Xenserver625StorageProcessor.java ", it feels that we were already doing this even before this PR #2398. However, I might not be understanding the c

Re: Squeeze another PR (#2398) in 4.11 milestone

“technically we should only have "one" on primary storage at any given point in time” I just wanted to follow up on this one. When we are copying a delta from the previous snapshot, we should actually have two snapshots on primary storage for a time. If the delta copy is successful, then we de

Re: Squeeze another PR (#2398) in 4.11 milestone

"We are already deleting snapshots in the primary storage, but we always leave behind the last one" This issue doesn't happen only when something fails. We are not deleting the snapshots from primary storage (not on XenServer 6.25+ and not since Feb 2017) The fix of this PR is: 1) when transferr

Re: Squeeze another PR (#2398) in 4.11 milestone

Khosrow, I have seen this issue as well. It happens when there are problems to transfer the snapshot from the primary to the secondary storage. However, we need to clarify one thing. We are already deleting snapshots in the primary storage, but we always leave behind the last one. The problem is th

Squeeze another PR (#2398) in 4.11 milestone

Hi community We've found [1] and fixed [2] an issue in 4.10 regarding snapshots remaining on primary storage (XenServer + Swift) which causes VDI chain gets full after some time and user cannot take another snapshot. Please include this in 4.11 milestone if you see fit. [1]: https://issues.apach