Re: WTF: Difference between schemas across branches?

2014-12-02 Thread Rohit Yadav
Thanks for replying Nitin. I've picked the latest fix, both schema files are semantically same now. If we're fixing/back-porting bug-fixes to all branches where a bug exists and making sure we're not introducing differences in schema, by doing that in a way we're helping the overall community (an

Re: WTF: Difference between schemas across branches?

2014-12-02 Thread Daan Hoogland
Nitin, On Tue, Dec 2, 2014 at 6:38 AM, Nitin Mehta wrote: > The changes from the commit 0e2e6995 are right, but this is not exactly > schema change but view definition changes. > This has been fixed in 4.5 through acc9c79 so that any one upgrading to > 4.5 do not miss these changes. Do note that

Re: WTF: Difference between schemas across branches?

2014-12-01 Thread Nitin Mehta
The changes from the commit 0e2e6995 are right, but this is not exactly schema change but view definition changes. This has been fixed in 4.5 through acc9c79 so that any one upgrading to 4.5 do not miss these changes. Do note that this change is idempotent so even if you do or do not make this chan

Re: WTF: Difference between schemas across branches?

2014-12-01 Thread Daan Hoogland
Rohit, You are quite right to complain about this, as in +1. There was a similar thing in the 44to45 files between 4.5 and master. Hugo mailed about it and half of it got resolved! WTF indeed. mobile dev with bilingual spelling checker used (read at your own risk) Op 1 dec. 2014 09:18 schreef "Ro

WTF: Difference between schemas across branches?

2014-12-01 Thread Rohit Yadav
Hi, While I’m working to backport changes on 4.3 branch, I discovered some changes between 4.3 branch’s schema-421to431.sql and master branch’s 421to431.sql files. While most changes are inserts/update related which may not severely harm a user upgrading from a previous version of CloudStack, b