code formatting for enums

2013-07-17 Thread Daan Hoogland
H, I am working on Networks with the eclipse.epf file loaded. Now the enum BroadcastDomainType gets saved as Native(null, null), Vlan("vlan", Integer.class), Vswitch("vs", String.class), LinkLocal(null, null), Vnet("vnet", Long.class), Storage( "storage", In

RE: code formatting for enums

2013-07-17 Thread Alex Huang
ssage- > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] > Sent: Wednesday, July 17, 2013 6:22 AM > To: dev > Subject: code formatting for enums > > H, > > I am working on Networks with the eclipse.epf file loaded. Now the enum > BroadcastDomainType gets saved as >

Re: code formatting for enums

2013-07-17 Thread Daan Hoogland
rapping tab > Look for 'enum' declaration->Constants > Select Wrap all elements, every element on a new line in the "Line > Wrapping policy:" drop down > > --Alex > > > > -Original Message- > > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]

RE: code formatting for enums

2013-07-17 Thread Alex Huang
com] > Sent: Wednesday, July 17, 2013 8:23 AM > To: dev > Subject: Re: code formatting for enums > > thanks, > it doesn't correct back to the one per line format, but at least it doesn't > garble the enum when right anymore. > > > > On Wed, Jul 17, 2013 at 4

Re: code formatting for enums

2013-07-18 Thread John Burwell
way. > > --Alex > >> -Original Message- >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] >> Sent: Wednesday, July 17, 2013 8:23 AM >> To: dev >> Subject: Re: code formatting for enums >> >> thanks, >> it doesn't correct b

RE: code formatting for enums

2013-07-18 Thread Alex Huang
ohn Burwell [mailto:jburw...@basho.com] > Sent: Thursday, July 18, 2013 12:33 PM > To: dev@cloudstack.apache.org > Subject: Re: code formatting for enums > > All, > > Another thing I have noticed is that enum values are not capitalized. General > coding convention is that

RE: code formatting for enums

2013-07-18 Thread Frank Zhang
5 PM > To: dev@cloudstack.apache.org > Subject: RE: code formatting for enums > > Actually, that's more of a C/C++ coding convention. (Speaking of which, > please > don't use "I" to start interfaces.) > > I prefer to have enums as follows >

Re: code formatting for enums

2013-07-18 Thread John Burwell
ts if the only reason is to follow some name > convention. > >> -Original Message- >> From: Alex Huang [mailto:alex.hu...@citrix.com] >> Sent: Thursday, July 18, 2013 3:55 PM >> To: dev@cloudstack.apache.org >> Subject: RE: code formatting for enums >>

RE: code formatting for enums

2013-07-18 Thread Alex Huang
uldn't expose states directly to end users. That really does require a discussion thread. --Alex > -Original Message- > From: John Burwell [mailto:jburw...@basho.com] > Sent: Thursday, July 18, 2013 4:39 PM > To: dev@cloudstack.apache.org > Subject: Re: code

RE: code formatting for enums

2013-07-18 Thread Frank Zhang
4:39 PM > To: dev@cloudstack.apache.org > Subject: Re: code formatting for enums > > Alex and Frank, > > In terms of conventions, the APIs exposed Java SDK and many other common > APIs following this convention. Hence, the reason for my suggestion. > > The notion that

RE: code formatting for enums

2013-07-19 Thread Donal Lafferty
> -Original Message- > From: Frank Zhang [mailto:frank.zh...@citrix.com] > Sent: 19 July 2013 12:19 AM > To: dev@cloudstack.apache.org > Subject: RE: code formatting for enums > > Then the most important factor of name > convention is user experience where Runni

Re: code formatting for enums

2013-07-19 Thread Daan Hoogland
2013 12:19 AM > > To: dev@cloudstack.apache.org > > Subject: RE: code formatting for enums > > > > Then the most important factor of name > > convention is user experience where Running is more user friendly than > > IS_RUNNING or whatever all capitalized sentence

Re: code formatting for enums

2013-07-19 Thread John Burwell
--Original Message- >> From: John Burwell [mailto:jburw...@basho.com] >> Sent: Thursday, July 18, 2013 4:39 PM >> To: dev@cloudstack.apache.org >> Subject: Re: code formatting for enums >> >> Alex and Frank, >> >> In terms of conventions, the

RE: code formatting for enums

2013-07-19 Thread Alex Huang
o.com] > Sent: Friday, July 19, 2013 6:33 AM > To: dev@cloudstack.apache.org > Subject: Re: code formatting for enums > > Frank, > > I expect that renaming an enum value to be a minor change (i.e. once the > codebase compiles, the change is good). However, i can say I am surp

RE: code formatting for enums

2013-07-19 Thread Frank Zhang
m convention is all capitalized. > -Original Message- > From: Alex Huang [mailto:alex.hu...@citrix.com] > Sent: Friday, July 19, 2013 8:38 AM > To: dev@cloudstack.apache.org > Subject: RE: code formatting for enums > > John, > > Just to be clear. Not doing enu

RE: code formatting for enums

2013-07-19 Thread Alex Huang
amework like the DAO layer that already defined how to deal with enums. And also, API also needs i18n etc. That side probably require a discussion. --Alex > -Original Message- > From: John Burwell [mailto:jburw...@basho.com] > Sent: Friday, July 19, 2013 12:06 PM > To:

Re: code formatting for enums

2013-07-19 Thread John Burwell
ginal Message- >> From: Alex Huang [mailto:alex.hu...@citrix.com] >> Sent: Friday, July 19, 2013 8:38 AM >> To: dev@cloudstack.apache.org >> Subject: RE: code formatting for enums >> >> John, >> >> Just to be clear. Not doing enum change correctly can

RE: code formatting for enums

2013-07-19 Thread Frank Zhang
Yes. we do need to fix such kind of typo > -Original Message- > From: Donal Lafferty [mailto:donal.laffe...@citrix.com] > Sent: Friday, July 19, 2013 12:28 AM > To: dev@cloudstack.apache.org > Subject: RE: code formatting for enums > > > -Original Message---