Re: create_schema.sql

2014-06-28 Thread David Nalley
On Sat, Jun 28, 2014 at 1:26 AM, Rohit Yadav rohityada...@gmail.com wrote: On Sat, Jun 28, 2014 at 2:43 AM, David Nalley da...@gnsa.us wrote: we could always add it to .gitignore That wouldn't stop changes from being made, but it would stop changes from propagating to the repo itself. But

Re: create_schema.sql

2014-06-27 Thread Daan Hoogland
Rohit, sorry for the late reaction. this works for defending yourself and maybe we should all do it, it doesn't defend the repo from checkins. I would prefer that. On Tue, Jun 24, 2014 at 10:07 PM, Rohit Yadav rohityada...@gmail.com wrote: Hi Daan and others, Let me share a way to guard files

Re: create_schema.sql

2014-06-27 Thread David Nalley
we could always add it to .gitignore That wouldn't stop changes from being made, but it would stop changes from propagating to the repo itself. On Fri, Jun 27, 2014 at 5:05 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Rohit, sorry for the late reaction. this works for defending yourself and

Re: create_schema.sql

2014-06-27 Thread Daan Hoogland
good call, we'll have to remember to temporarily remove it as we start on 5.0 On Fri, Jun 27, 2014 at 11:13 PM, David Nalley da...@gnsa.us wrote: we could always add it to .gitignore That wouldn't stop changes from being made, but it would stop changes from propagating to the repo itself. On

Re: create_schema.sql

2014-06-27 Thread Rohit Yadav
On Sat, Jun 28, 2014 at 2:43 AM, David Nalley da...@gnsa.us wrote: we could always add it to .gitignore That wouldn't stop changes from being made, but it would stop changes from propagating to the repo itself. But David, one can git add -f or something. Can we put a git hook (post

create_schema.sql

2014-06-24 Thread Hugo Trippaers
Dear committers, When either committing or reviewing, please pay attention to the fact the create_schema.sql should NOT be modified under any circumstances. Since release 4.1 this file is considered frozen and updates to the schema will be in the upgrade scripts for the versions

Re: create_schema.sql

2014-06-24 Thread Prasanna Santhanam
On Tue, Jun 24, 2014 at 10:27:56AM +0200, Hugo Trippaers wrote: Dear committers, When either committing or reviewing, please pay attention to the fact the create_schema.sql should NOT be modified under any circumstances. Since release 4.1 this file is considered frozen and updates

Re: create_schema.sql

2014-06-24 Thread Daan Hoogland
It should be included in any release On Tue, Jun 24, 2014 at 10:44 AM, Prasanna Santhanam t...@apache.org wrote: On Tue, Jun 24, 2014 at 10:27:56AM +0200, Hugo Trippaers wrote: Dear committers, When either committing or reviewing, please pay attention to the fact the create_schema.sql

Re: create_schema.sql

2014-06-24 Thread Prasanna Santhanam
On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote: It should be included in any release so packaging can bring it back i thought. just a thought. -- Prasanna., Powered by BigRock.com

Re: create_schema.sql

2014-06-24 Thread Daan Hoogland
including the source release? I don't like:( I do agree that some kind of guard would help, though On Tue, Jun 24, 2014 at 10:57 AM, Prasanna Santhanam t...@apache.org wrote: On Tue, Jun 24, 2014 at 10:51:31AM +0200, Daan Hoogland wrote: It should be included in any release so packaging can

Re: create_schema.sql

2014-06-24 Thread Rajani Karuturi
how about calculating the md5 checksum of the file and a build failure incase the checksum changes? liquibase(http://www.liquibase.org/) manages its changesets using md5 hash. ~Rajani On 24-Jun-2014, at 2:48 pm, Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com wrote:

Re: create_schema.sql

2014-06-24 Thread Ian Duffy
Apologizes for my commit to it yesterday. Was removing erroneous lines brought in by the other commit. On 24 June 2014 10:27, Rajani Karuturi rajani.karut...@citrix.com wrote: how about calculating the md5 checksum of the file and a build failure incase the checksum changes?

Re: create_schema.sql

2014-06-24 Thread Rohit Yadav
Hi Daan and others, Let me share a way to guard files that interest us by alerting us using the following shell script git hook: Put the following your .git/hooks/post-merge (make sure to chmod +x the following shell script): # START OF SCRIPT #/usr/bin/env bash changed_files=$(git diff-tree