download template -> delete vhd

2014-07-23 Thread Tomasz Zięba
Hello, Could someone confirm that download template deletes the vhd file from secondary storage. We are testing on the ACS version 4.2.1 but the code responsible for removing is the same in version 4.4 https://github.com/apache/cloudstack/blob/8b6dc7ce2f0058b9cf29bd9c72e4e0db9162fe6e/services/se

Re: download template -> delete vhd

2014-07-23 Thread Min Chen
In current ACS master, Template is not deleted from secondary storage when extractTemplate is called, just its symlink is deleted. Thanks -min On 7/23/14 4:15 AM, "Tomasz Zięba" wrote: >Hello, > >Could someone confirm that download template deletes the vhd file from >secondary storage. > >We ar

Re: download template -> delete vhd

2014-07-23 Thread Nitin Mehta
Tomas - Its not the same, there have been fixes made in ACS master/4.4. But as Min pointed out in current ACS it works fine and deletes only the symlink. To work around the situation in 4.2.1 you can try setting extract.url.expiration.interval (the value is in seconds ) in global settings to a larg

Re: download template -> delete vhd

2014-07-24 Thread Tomasz Zięba
Hello, https://github.com/apache/cloudstack/blob/master/services/secondary-storage/server/src/org/apache/cloudstack/storage/template/UploadManagerImpl.java We analyzed that the problem is in this line: if (cmd.getType() == Upload.Type.VOLUME) { This line is always true because cmd.getTy

Re: download template -> delete vhd

2014-07-24 Thread Nitin Mehta
Tomasz - This fix works but you should rather make the fix on the MS code which sends the deletion command rather than on the systemvm side. Moreover if you stop/start ssvm you would loose this jar. You have to rebuild systemvm.iso and put it back on the host (depends on hypervisor in use). My sug