Re: git commit: updated refs/heads/4.3 to 386b467

2014-01-16 Thread David Nalley
Why do this in 410to420? It won't get corrected on upgrades that are already at 4.2.x - realistically it probably needs to be in a 421to422 if we plan on a 4.2.2 or 421to430. --David On Thu, Jan 16, 2014 at 2:22 PM, d...@apache.org wrote: Updated Branches: refs/heads/4.3 c375ec62e -

Re: git commit: updated refs/heads/4.3 to 386b467

2014-01-16 Thread Daan Hoogland
On Thu, Jan 16, 2014 at 8:32 PM, David Nalley da...@gnsa.us wrote: Why do this in 410to420? It won't get corrected on upgrades that are already at 4.2.x - realistically it probably needs to be in a 421to422 if we plan on a 4.2.2 or 421to430. it doesn't mean it won't be done. alter table

Re: git commit: updated refs/heads/4.3 to 386b467

2014-01-16 Thread Daan Hoogland
On Thu, Jan 16, 2014 at 8:46 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: but that won't help people doing an upgrade as they will pass by the 410to420 script. reading the source we are both right. I will add the alter table statement as well (to 4.3 and 4.4 scripts)

Re: git commit: updated refs/heads/4.3 to 386b467

2014-01-16 Thread Wei ZHOU
alter table is good enough. 2014/1/16 Daan Hoogland daan.hoogl...@gmail.com On Thu, Jan 16, 2014 at 8:46 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: but that won't help people doing an upgrade as they will pass by the 410to420 script. reading the source we are both right. I will

Re: git commit: updated refs/heads/4.3 to 386b467

2014-01-16 Thread Daan Hoogland
it seems to me it is not for those who will run into a to large cidr list. For those installations the management server upgrade step will fail and the ms will stop. both the alter table and the altered create statement are needed. On Thu, Jan 16, 2014 at 9:23 PM, Wei ZHOU ustcweiz...@gmail.com

Re: git commit: updated refs/heads/4.3 to 386b467

2014-01-16 Thread Daan Hoogland
sorry Wei Zou, David, I take that back. only people with large cidr lists that upgrade to 4.2.1 will suffer indeed. On Thu, Jan 16, 2014 at 9:36 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: it seems to me it is not for those who will run into a to large cidr list. For those installations