Build failed in Jenkins: build-master-slowbuild #3398

2016-03-06 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-systemvm64-master #769

2016-03-06 Thread jenkins
See -- [...truncated 3364 lines...] 100% [Packages 28.5 MB] 100% [Working] 100% [Packages 28.5 MB] 100% [Packages 28.5 MB] 100% [

[GitHub] cloudstack pull request: CLOUDSTACK-9285 - Agent throws an excepti...

2016-03-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1429#issuecomment-192864151 @kiwiflyer your change makes sense to me, (un)fortunately we have quite strict checkstyle settings. Can you replace the tab with spaces? --- If your project i

[GitHub] cloudstack pull request: ADD be explicit about the underlying limi...

2016-03-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1426#issuecomment-192865339 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Build failed in Jenkins: build-master-slowbuild #3399

2016-03-06 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-03-06 Thread cristofolini
Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-192893991 This looks like a sensible fix to me. Code LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9269: Missing field for Switch...

2016-03-06 Thread cristofolini
Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1396#issuecomment-192911909 @nitin-maharana I don't see anything wrong with the code. You might want to push this again so that Jenkins can have another go at it, and if it fails again we

Build failed in Jenkins: build-master-slowbuild #3400

2016-03-06 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

2016-03-06 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-192913387 Daan, Sorry about that. I've fixed it, pushed the commit and checks are now passing. - Simon --- If your project is set up for it, you can repl

[GitHub] cloudstack pull request: CLOUDSTACK-9285 - Agent throws an excepti...

2016-03-06 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1429#issuecomment-192913591 Daan, Sorry about that. I've fixed it, pushed the commit and checks are now passing. Simon --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

2016-03-06 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-192928078 We've tested this patch against master. Snapshots work correctly and data is displayed in UI when using supported storage backend (NFS), so nice work! We

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

2016-03-06 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-192928201 ![snapshot_list](https://cloud.githubusercontent.com/assets/17278194/1319/dab4ae2e-e387-11e5-9b51-dfe6300b63f5.png) --- If your project is set up for it, you

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

2016-03-06 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-192928190 ![unexpected_exception](https://cloud.githubusercontent.com/assets/17278194/1314/d00ca0e4-e387-11e5-9274-7b8605489484.png) --- If your project is set up for

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

2016-03-06 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-192928225 ![snapshot_nodelete](https://cloud.githubusercontent.com/assets/17278194/1323/e508d76a-e387-11e5-976f-d03437b1eab1.png) --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9184: [VMware] vmware.ports.pe...

2016-03-06 Thread GabrielBrascher
Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/1253#issuecomment-192951641 @sureshanaparti Although it might be a bit tricky, I believe that the ideal solution would be to check for the hypervisor version; if it is 4.1/4.0 then the

Build failed in Jenkins: build-master-slowbuild #3401

2016-03-06 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8746: VM Snapshotting im...

2016-03-06 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-192958023 @kiwiflyer Simon, Thanks for your bug report, I will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

Build failed in Jenkins: build-master-slowbuild #3402

2016-03-06 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Build failed in Jenkins: build-master-slowbuild #3403

2016-03-06 Thread jenkins
See -- [...truncated 824 lines...] at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) at org.apache.maven.surefire.booter.ForkedBooter

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

2016-03-06 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1417#discussion_r55153415 --- Diff: test/integration/component/test_deploy_vm_from_snapshot.py --- @@ -0,0 +1,644 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: CLOUDSTACK-8611. CS waits indefinitely fo...

2016-03-06 Thread GabrielBrascher
Github user GabrielBrascher commented on the pull request: https://github.com/apache/cloudstack/pull/561#issuecomment-193063329 Shouldn't the class throw a less generic Exception? A good choice might be the **com.cloud.utils.ssh.SshException.SshException(String)**. Although this ch

Build failed in Jenkins: build-master-slowbuild #3404

2016-03-06 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

2016-03-06 Thread nitt10prashant
Github user nitt10prashant commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1417#discussion_r55160105 --- Diff: test/integration/component/test_deploy_vm_from_snapshot.py --- @@ -0,0 +1,644 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

2016-03-06 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1417#discussion_r55160508 --- Diff: test/integration/component/test_deploy_vm_from_snapshot.py --- @@ -0,0 +1,644 @@ +# Licensed to the Apache Software Foundation (ASF)

Build failed in Jenkins: build-master-slowbuild #3405

2016-03-06 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack

Re: [DISCUSS] Request for comments: Out-of-band Management for CloudStack (new feature)

2016-03-06 Thread Koushik Das
Thanks Rohit for the clarifications. I will get back if there are additional questions. -Koushik From: Rohit Yadav Sent: Friday, March 4, 2016 3:29 PM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] Request for comments: Out-of-band Management for CloudS

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

2016-03-06 Thread alexandrelimassantana
Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1254#discussion_r55169349 --- Diff: framework/quota/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -358,10 +358,11 @@ public QuotaUsageVO updateQuotaDi

[GitHub] cloudstack pull request: CLOUDSTACK-9182: Some running VMs turned ...

2016-03-06 Thread alexandrelimassantana
Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1252#discussion_r55169762 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -4468,6 +4472,16 @@ private boolean checkIfHostIsDedicated(HostVO host) {

[GitHub] cloudstack pull request: CLOUDSTACK-8611. CS waits indefinitely fo...

2016-03-06 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/561#issuecomment-193139382 @GabrielBrascher If you want to work on this I suggest you pull in the pr branch and push it to your own clone to make a new PR. @likitha has left the community