[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62754671 --- Diff: api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java --- @@ -0,0 +1,207 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62754742 --- Diff: api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java --- @@ -0,0 +1,207 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62754845 --- Diff: api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java --- @@ -0,0 +1,207 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62754948 --- Diff: api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java --- @@ -0,0 +1,207 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62755020 --- Diff: api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java --- @@ -0,0 +1,207 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62755100 --- Diff: api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java --- @@ -0,0 +1,207 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62756570 --- Diff: api/src/org/apache/cloudstack/api/command/user/vpc/CreateVPCCmd.java --- @@ -143,7 +149,17 @@ public Boolean getDisplayVpc() {

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62757226 --- Diff: api/test/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigCmdTest.java --- @@ -0,0 +1,72 @@ +// Licensed to the Apache Software F

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62757346 --- Diff: client/tomcatconf/commands.properties.in --- @@ -485,6 +485,10 @@ updateVPCOffering=1 deleteVPCOffering=1 listVPCOfferings=15

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62757726 --- Diff: core/src/com/cloud/agent/api/routing/QuaggaConfigCommand.java --- @@ -0,0 +1,86 @@ +// +// Licensed to the Apache Software Foundation (

[GitHub] cloudstack-cloudmonkey pull request: fix bug in using readline in ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/13#issuecomment-218304743 LGTM, based on the changes I think it should work on all Python versions --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62762933 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java --- @@ -0,0 +1,93 @@ +// +// Licensed to the Apache Sof

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62763000 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java --- @@ -0,0 +1,93 @@ +// +// Licensed to the Apache Sof

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62763147 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java --- @@ -0,0 +1,93 @@ +// +// Licensed to the Apache Sof

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62763200 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java --- @@ -0,0 +1,93 @@ +// +// Licensed to the Apache Sof

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62763274 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java --- @@ -0,0 +1,93 @@ +// +// Licensed to the Apache Sof

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62763423 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/facade/QuaggaConfigItem.java --- @@ -0,0 +1,93 @@ +// +// Licensed to the Apache Sof

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62763676 --- Diff: engine/components-api/src/com/cloud/network/vpc/VpcManager.java --- @@ -161,8 +161,9 @@ * @param gateway * @param networkO

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62764156 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -1445,28 +1466,31 @@ public void prepareA

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62764350 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -1445,28 +1466,31 @@ public void prepareA

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218321496 Done, now it passed but somehow Jenkins test was not executed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62779198 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -1445,28 +1466,31 @@ public void prepareA

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62779378 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -1476,22 +1500,22 @@ public void prepareA

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62779835 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -2024,8 +2047,25 @@ public Network create

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62780074 --- Diff: engine/schema/src/com/cloud/dc/DataCenterVO.java --- @@ -365,6 +366,18 @@ public void setLocalStorageEnabled(boolean enabled) { }

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62780203 --- Diff: engine/schema/src/com/cloud/network/dao/PhysicalNetworkServiceProviderVO.java --- @@ -308,15 +331,21 @@ public void setEnabledServices(List

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62780405 --- Diff: engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java --- @@ -62,7 +62,31 @@ protected VpcServiceMapDaoImpl() {

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62780467 --- Diff: engine/schema/src/com/cloud/network/vpc/dao/VpcServiceMapDaoImpl.java --- @@ -62,7 +62,31 @@ protected VpcServiceMapDaoImpl() {

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62780557 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -138,7 +138,8 @@ public QuotaTariffRespons

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62780906 --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java --- @@ -2111,8 +2098,9 @@ public Network updateGuestNetwork(final long networkId, String

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62781171 --- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java --- @@ -482,8 +474,8 @@ public boolean applyIps(final Network network, final

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62781348 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -1048,4 +1052,33 @@ protected String getGuestDhcpRange(final NicProfile gue

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62781459 --- Diff: server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java --- @@ -198,14 +199,26 @@ public boolean removeVpcRouterFromGu

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62781596 --- Diff: server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java --- @@ -455,16 +471,26 @@ protected void finalizeNetworkRulesF

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62781651 --- Diff: server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java --- @@ -455,16 +471,26 @@ protected void finalizeNetworkRulesF

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62781709 --- Diff: server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java --- @@ -455,16 +471,26 @@ protected void finalizeNetworkRulesF

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62781813 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -309,6 +314,19 @@ public void doInTransactionWithoutResult(final TransactionStatus

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782035 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -309,6 +314,19 @@ public void doInTransactionWithoutResult(final TransactionStatus

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782148 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -501,7 +517,7 @@ private void validateConnectivtyServiceCapabilities(final Set pro

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782162 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -529,14 +545,14 @@ private boolean findCapabilityForService(final Map serviceCapab

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782392 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -705,6 +744,30 @@ public boolean deleteVpcOffering(final long offId) { }

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782438 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -705,6 +744,30 @@ public boolean deleteVpcOffering(final long offId) { }

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782496 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long vpcOffId, final

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782579 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long vpcOffId, final

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782681 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long vpcOffId, final

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782819 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long vpcOffId, final

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782870 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long vpcOffId, final

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62782933 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long vpcOffId, final

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62783039 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -809,15 +945,22 @@ public Vpc createVpc(final long zoneId, final long vpcOffId, fi

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62783052 --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java --- @@ -809,15 +945,22 @@ public Vpc createVpc(final long zoneId, final long vpcOffId, fi

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62783380 --- Diff: server/src/com/cloud/server/ConfigurationServerImpl.java --- @@ -1236,18 +1218,34 @@ public void doInTransactionWithoutResult(TransactionStatu

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62783468 --- Diff: server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java --- @@ -212,4 +214,20 @@ public boolean visit(final AdvancedVpn

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62783518 --- Diff: server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java --- @@ -316,4 +317,9 @@ public boolean visit(final StaticRoutesRule

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62785317 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py --- @@ -0,0 +1,85 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62785361 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py --- @@ -0,0 +1,85 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62785576 --- Diff: test/integration/component/test_ospf.py --- @@ -0,0 +1,477 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62785711 --- Diff: test/integration/component/test_ospf.py --- @@ -0,0 +1,477 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62785662 --- Diff: test/integration/component/test_ospf.py --- @@ -0,0 +1,477 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62785806 --- Diff: test/integration/component/test_ospf.py --- @@ -0,0 +1,477 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62785864 --- Diff: test/integration/component/test_ospf.py --- @@ -0,0 +1,477 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62785940 --- Diff: test/integration/component/test_ospf.py --- @@ -0,0 +1,477 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786006 --- Diff: test/integration/component/test_ospf.py --- @@ -0,0 +1,477 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786093 --- Diff: test/integration/component/test_ospf.py --- @@ -0,0 +1,477 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786148 --- Diff: test/integration/smoke/test_ospf_zone_config.py --- @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786188 --- Diff: test/integration/smoke/test_ospf_zone_config.py --- @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786232 --- Diff: test/integration/smoke/test_ospf_zone_config.py --- @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786260 --- Diff: test/integration/smoke/test_ospf_zone_config.py --- @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786345 --- Diff: test/integration/smoke/test_ospf_zone_config.py --- @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786497 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -903,6 +906,10 @@ static boolean areCidrsNotEmpty(String cidrA, String cidrB) {

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786538 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -1135,6 +1142,21 @@ public static boolean isSameIpRange(final String cidrA, final

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786638 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String cidr) {

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786731 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String cidr) {

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786802 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/BadCIDRException.java --- @@ -0,0 +1,33 @@ +// +// Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62786873 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/BadCIDRException.java --- @@ -0,0 +1,33 @@ +// +// Licensed to the Apache Software Founda

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787032 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java --- @@ -0,0 +1,98 @@ +// +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787065 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java --- @@ -0,0 +1,98 @@ +// +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787123 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java --- @@ -0,0 +1,98 @@ +// +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787129 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java --- @@ -0,0 +1,98 @@ +// +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787143 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java --- @@ -0,0 +1,98 @@ +// +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787136 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java --- @@ -0,0 +1,98 @@ +// +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787151 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java --- @@ -0,0 +1,98 @@ +// +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787378 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java --- @@ -0,0 +1,98 @@ +// +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787416 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787426 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787493 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787530 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787612 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787677 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787904 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62787923 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62788152 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62788201 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62788312 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62788397 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: L10n update 4.8 20160422

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218354565 Can you re-push to try to get Jenkins green. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62788491 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java --- @@ -0,0 +1,98 @@ +// +// Licensed to the Apache Software Foundation (ASF) un

[GitHub] cloudstack pull request: CID-1338387: Deletion of method endPointS...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62788572 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software Foundation (ASF)

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62788636 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR6.java --- @@ -0,0 +1,95 @@ +// +// Licensed to the Apache Software Foundation (ASF) u

  1   2   3   >