[GitHub] [cloudstack-primate] rhtyd commented on pull request #599: Fix page navigation error when delete template.

2020-08-20 Thread GitBox
rhtyd commented on pull request #599: URL: https://github.com/apache/cloudstack-primate/pull/599#issuecomment-677462989 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #599: Fix page navigation error when delete template.

2020-08-20 Thread GitBox
blueorangutan commented on pull request #599: URL: https://github.com/apache/cloudstack-primate/pull/599#issuecomment-677463276 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd commented on pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
rhtyd commented on pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677463488 cc @davidjumani @shwstppr @blueorangutan package This is an automated message from the Apache Git Se

[GitHub] [cloudstack-primate] rhtyd commented on pull request #594: [WIP] Bug Fixes

2020-08-20 Thread GitBox
rhtyd commented on pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#issuecomment-677464559 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
blueorangutan commented on pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677464143 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd merged pull request #587: Allow creating snapshot from VM snapshot

2020-08-20 Thread GitBox
rhtyd merged pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #591: [BUG] VM state in UI not updated when deployment failure

2020-08-20 Thread GitBox
andrijapanicsb commented on issue #591: URL: https://github.com/apache/cloudstack-primate/issues/591#issuecomment-677465341 This is (was, hopefully) definitively an issue even with successful deployments (Firefox, Windows 10) --

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #594: [WIP] Bug Fixes

2020-08-20 Thread GitBox
blueorangutan commented on pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#issuecomment-677465330 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] davidjumani commented on issue #591: [BUG] VM state in UI not updated when deployment failure

2020-08-20 Thread GitBox
davidjumani commented on issue #591: URL: https://github.com/apache/cloudstack-primate/issues/591#issuecomment-677467310 @andrijapanicsb Fixes for vm failed as well as successfully deployed This is an automated message from

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #599: Fix page navigation error when delete template.

2020-08-20 Thread GitBox
blueorangutan commented on pull request #599: URL: https://github.com/apache/cloudstack-primate/pull/599#issuecomment-677468956 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/599 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
blueorangutan commented on pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677470075 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/600 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #594: [WIP] Bug Fixes

2020-08-20 Thread GitBox
blueorangutan commented on pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#issuecomment-677470890 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/594 (JID-3

[GitHub] [cloudstack-primate] davidjumani commented on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering

2020-08-20 Thread GitBox
davidjumani commented on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-677471798 Discussed with @andrijapanicsb Will be working on this This is an automated message from the Apache Git

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #599: Fix page navigation error when delete template.

2020-08-20 Thread GitBox
davidjumani commented on a change in pull request #599: URL: https://github.com/apache/cloudstack-primate/pull/599#discussion_r473788523 ## File path: src/views/image/TemplateZones.vue ## @@ -266,7 +266,10 @@ export default { jobId, successMethod: result =

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
davidjumani commented on a change in pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r473791803 ## File path: src/views/compute/wizard/ComputeSelection.vue ## @@ -21,31 +21,21 @@ -

[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #599: Fix page navigation error when delete template.

2020-08-20 Thread GitBox
utchoang commented on a change in pull request #599: URL: https://github.com/apache/cloudstack-primate/pull/599#discussion_r473804872 ## File path: src/views/image/TemplateZones.vue ## @@ -266,7 +266,10 @@ export default { jobId, successMethod: result => {

[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
utchoang commented on a change in pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#discussion_r473805327 ## File path: src/views/compute/wizard/ComputeSelection.vue ## @@ -21,31 +21,21 @@ - -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #599: Fix page navigation error when delete template.

2020-08-20 Thread GitBox
davidjumani commented on pull request #599: URL: https://github.com/apache/cloudstack-primate/pull/599#issuecomment-677494057 @rhtyd Good to go! Thanks @utchoang This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack-primate] davidjumani commented on pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
davidjumani commented on pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677494429 @rhtyd Good to go! Thanks @utchoang This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack-primate] rhtyd closed issue #598: [BUG] the "job querying" message-box will redirect users back to the previos page

2020-08-20 Thread GitBox
rhtyd closed issue #598: URL: https://github.com/apache/cloudstack-primate/issues/598 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd merged pull request #599: Fix page navigation error when delete template.

2020-08-20 Thread GitBox
rhtyd merged pull request #599: URL: https://github.com/apache/cloudstack-primate/pull/599 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on issue #598: [BUG] the "job querying" message-box will redirect users back to the previos page

2020-08-20 Thread GitBox
rhtyd commented on issue #598: URL: https://github.com/apache/cloudstack-primate/issues/598#issuecomment-677499209 @andrijapanicsb can you test against latest master This is an automated message from the Apache Git Service.

[GitHub] [cloudstack-primate] rhtyd commented on pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
rhtyd commented on pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677500151 Ping @shwstppr - can you check review the changes @davidjumani can you test the cases for (a) normal offering, (b) contrainst offering, (c) uncontr... offering; also t

[GitHub] [cloudstack-primate] rhtyd commented on pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
rhtyd commented on pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677500204 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
blueorangutan commented on pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677500947 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes

2020-08-20 Thread GitBox
rhtyd commented on a change in pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r473834363 ## File path: src/config/eventBus.js ## @@ -0,0 +1,2 @@ +import Vue from 'vue' Review comment: can you add a license --

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes

2020-08-20 Thread GitBox
rhtyd commented on a change in pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r473835438 ## File path: src/views/compute/DeployVM.vue ## @@ -193,7 +193,7 @@ :isConstrained="'serviceofferingdetails' in serviceOffe

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes

2020-08-20 Thread GitBox
rhtyd commented on a change in pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r473835850 ## File path: src/views/compute/wizard/ComputeSelection.vue ## @@ -106,7 +104,7 @@ export default { }, minMemory: { type: Number,

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes

2020-08-20 Thread GitBox
rhtyd commented on a change in pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r473837733 ## File path: src/views/AutogenView.vue ## @@ -143,7 +143,6 @@

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #601: [BUG] minor - label it "Data disks, not "Disk Offerings"

2020-08-20 Thread GitBox
andrijapanicsb opened a new issue #601: URL: https://github.com/apache/cloudstack-primate/issues/601 ![image](https://user-images.githubusercontent.com/45762285/90756354-8c22e100-e2dc-11ea-97ed-3cbf94bb9576.png) Deploying a VM from a template, this section should say Data disks, not

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
blueorangutan commented on pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677505345 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/600 (JID-3

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #15: Maintenance

2020-08-20 Thread GitBox
onitake commented on issue #15: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/15#issuecomment-677505424 @iamcryptoki You can also take a look at https://hub.docker.com/repository/docker/swisstxt/cloudstack-kubernetes-provider - I'm occasionally pushing development v

[GitHub] [cloudstack-primate] rhtyd merged pull request #484: Some Spanish translations

2020-08-20 Thread GitBox
rhtyd merged pull request #484: URL: https://github.com/apache/cloudstack-primate/pull/484 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #484: Some Spanish translations

2020-08-20 Thread GitBox
rhtyd commented on pull request #484: URL: https://github.com/apache/cloudstack-primate/pull/484#issuecomment-677597615 Merging this based on @nvazquez 's comments; any more changes can be submitted by a new PR This is an a

[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation

2020-08-20 Thread GitBox
rhtyd commented on pull request #320: URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-677598964 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation

2020-08-20 Thread GitBox
rhtyd closed pull request #320: URL: https://github.com/apache/cloudstack-primate/pull/320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation

2020-08-20 Thread GitBox
blueorangutan commented on pull request #320: URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-677600702 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #320: Explore Test Automation

2020-08-20 Thread GitBox
blueorangutan commented on pull request #320: URL: https://github.com/apache/cloudstack-primate/pull/320#issuecomment-677612050 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/320 (JID-3

[GitHub] [cloudstack-primate] shwstppr commented on pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-20 Thread GitBox
shwstppr commented on pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600#issuecomment-677632936 @rhtyd tried to test deployment with different constrained and unconstrained offerings This is an au

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #9: Support loadBalancerSourceRanges

2020-08-20 Thread GitBox
onitake commented on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-677652349 I flipped the logic around. Firewall rules are now deleted _before_ the new rules are added. This should resolve the issue. -

[GitHub] [cloudstack-primate] utchoang opened a new pull request #602: Fixes an issue that could not search on zone select

2020-08-20 Thread GitBox
utchoang opened a new pull request #602: URL: https://github.com/apache/cloudstack-primate/pull/602 @rhtyd cc @svenvogel I found 1 issue: We can't search on zone select input in creating/upload templates/isos. I've fixed it. Thanks. * Before: ![1](https://user-images.githubuserconten

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #594: [WIP] Bug Fixes

2020-08-20 Thread GitBox
davidjumani commented on a change in pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r474414311 ## File path: src/views/AutogenView.vue ## @@ -143,7 +143,6 @@

[GitHub] [cloudstack-primate] davidjumani commented on pull request #594: [WIP] Bug Fixes

2020-08-20 Thread GitBox
davidjumani commented on pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#issuecomment-678044896 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] davidjumani commented on issue #601: [BUG] minor - label it "Data disks, not "Disk Offerings"

2020-08-20 Thread GitBox
davidjumani commented on issue #601: URL: https://github.com/apache/cloudstack-primate/issues/601#issuecomment-678049922 Fixed in https://github.com/apache/cloudstack-primate/pull/594/commits/89b3d4d33a297854a90ffc48a7eda8abda0a7e62 ---