[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme

2020-09-23 Thread GitBox
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697173747 * For select project ![image](https://user-images.githubusercontent.com/13766648/93977569-e2d07e80-fda4-11ea-9e40-2ccf1c608ef8.png) --

[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme

2020-09-23 Thread GitBox
rhtyd commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697174341 Thanks @utchoang pl update the customize.md and send a doc PR to the documentation repo This is an auto

[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme

2020-09-23 Thread GitBox
rhtyd commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697174576 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme

2020-09-23 Thread GitBox
blueorangutan commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697174598 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme

2020-09-23 Thread GitBox
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697175875 @rhtyd I've updated customize.md on this PR and a document on https://github.com/apache/cloudstack-documentation/pull/159 ---

[GitHub] [cloudstack-primate] rhtyd commented on pull request #718: FIX - customize theme

2020-09-23 Thread GitBox
rhtyd commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697178296 Thanks @utchoang I'll review, test and merge shortly This is an automated message from the Apache Git S

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme

2020-09-23 Thread GitBox
blueorangutan commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-697178510 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3

[GitHub] [cloudstack-primate] rhtyd commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-23 Thread GitBox
rhtyd commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697178990 @andrijapanicsb can you check the behaviour against old UI? This is an automated message from the Apache Git

[GitHub] [cloudstack-primate] rhtyd commented on issue #650: [BUG] After session expire the page reloads once more

2020-09-23 Thread GitBox
rhtyd commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-697179344 @davidjumani instead of change route and the do a reload, can't we just reload directly to the login page?

[GitHub] [cloudstack-primate] utchoang commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-23 Thread GitBox
utchoang commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697194602 @rhtyd @davidjumani Currently I don't know which field to rely on to hide the Load Balancer Rule or PortFowardRule tab. ![image](https://user-images.githubusercontent.c

[GitHub] [cloudstack-primate] davidjumani commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-23 Thread GitBox
davidjumani commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697203929 It is based on the `listPortForwardingRules` and `listLoadBalancerRules` apis, while the vpcid filed indicates whether it belongs to a vpc

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-23 Thread GitBox
davidjumani edited a comment on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697203929 @utchoang It is based on the `listPortForwardingRules` and `listLoadBalancerRules` apis, while the vpcid filed indicates whether it belongs to a vpc --

[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #738: Storage type defaults to shared even on setting to local

2020-09-23 Thread GitBox
Pearl1594 opened a new pull request #738: URL: https://github.com/apache/cloudstack-primate/pull/738 By default, the following parameters are passed : ``` {"GET":{"scheme":"http","host":"10.10.3.155:8080","filename":"/client/api/","query":{"issystem":"false","name":"test2","displaytex

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #738: Storage type defaults to shared even on setting to local

2020-09-23 Thread GitBox
Pearl1594 commented on pull request #738: URL: https://github.com/apache/cloudstack-primate/pull/738#issuecomment-697204321 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #738: Storage type defaults to shared even on setting to local

2020-09-23 Thread GitBox
blueorangutan commented on pull request #738: URL: https://github.com/apache/cloudstack-primate/pull/738#issuecomment-697204758 @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #738: Storage type defaults to shared even on setting to local

2020-09-23 Thread GitBox
blueorangutan commented on pull request #738: URL: https://github.com/apache/cloudstack-primate/pull/738#issuecomment-697209386 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/738 (JID-3

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #739: addcomputeoffering: Fix typo in storagetype and network rate

2020-09-23 Thread GitBox
davidjumani opened a new pull request #739: URL: https://github.com/apache/cloudstack-primate/pull/739 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack-primate] davidjumani commented on issue #650: [BUG] After session expire the page reloads once more

2020-09-23 Thread GitBox
davidjumani commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-697213545 If it's a direct reload, the notification that the session has expired won't popup (or will for half a second and then reload to the login page). I think it will be fin

[GitHub] [cloudstack-primate] DaanHoogland opened a new issue #740: [BUG] user with special role can not log on

2020-09-23 Thread GitBox
DaanHoogland opened a new issue #740: URL: https://github.com/apache/cloudstack-primate/issues/740 **Describe the bug** After creating a new role with all permissions except for updateZone, and creating an account with that role, the user can not log on. **To Reproduce** Steps

[GitHub] [cloudstack-primate] davidjumani commented on issue #740: [BUG] user with special role can not log on

2020-09-23 Thread GitBox
davidjumani commented on issue #740: URL: https://github.com/apache/cloudstack-primate/issues/740#issuecomment-697228288 @DaanHoogland That's because the user doesn't have access to `listApis` and `listCapabilities` APIs which are needed by primate ---

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #9: Support loadBalancerSourceRanges

2020-09-23 Thread GitBox
onitake commented on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-697230091 @joschi36 Is this working as expected now, or do I need to take another look? This is an autom

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #6: [WIP] Improved Ingress Controller example to be clearer and more complete

2020-09-23 Thread GitBox
onitake commented on pull request #6: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/6#issuecomment-697231932 @rhtyd I think it's ok to merge this now. The example should be good enough to get people started. -

[GitHub] [cloudstack-primate] rhtyd merged pull request #718: FIX - customize theme

2020-09-23 Thread GitBox
rhtyd merged pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd closed issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section

2020-09-23 Thread GitBox
rhtyd closed issue #712: URL: https://github.com/apache/cloudstack-primate/issues/712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on issue #713: [BUG] '@processing' color does not affect the page loading progress or circular 'I'm thinking' graphic

2020-09-23 Thread GitBox
rhtyd commented on issue #713: URL: https://github.com/apache/cloudstack-primate/issues/713#issuecomment-697232696 Vefied and close in PR #718 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack-primate] rhtyd closed issue #714: [BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view

2020-09-23 Thread GitBox
rhtyd closed issue #714: URL: https://github.com/apache/cloudstack-primate/issues/714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd closed issue #713: [BUG] '@processing' color does not affect the page loading progress or circular 'I'm thinking' graphic

2020-09-23 Thread GitBox
rhtyd closed issue #713: URL: https://github.com/apache/cloudstack-primate/issues/713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on issue #712: [BUG] '@link-color' does not effect the mouse-over color in details section

2020-09-23 Thread GitBox
rhtyd commented on issue #712: URL: https://github.com/apache/cloudstack-primate/issues/712#issuecomment-697232644 Vefied and close in PR #718 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack-primate] rhtyd commented on issue #714: [BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view

2020-09-23 Thread GitBox
rhtyd commented on issue #714: URL: https://github.com/apache/cloudstack-primate/issues/714#issuecomment-697233056 Vefied and close in PR #718 Caveat - the navigation bar background colour is the same across default and project view

[GitHub] [cloudstack-documentation] rhtyd merged pull request #159: Menu/link background color customization

2020-09-23 Thread GitBox
rhtyd merged pull request #159: URL: https://github.com/apache/cloudstack-documentation/pull/159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-documentation] rhtyd merged pull request #152: Update to java 11

2020-09-23 Thread GitBox
rhtyd merged pull request #152: URL: https://github.com/apache/cloudstack-documentation/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-documentation] rhtyd merged pull request #156: Adding docs for noVNC

2020-09-23 Thread GitBox
rhtyd merged pull request #156: URL: https://github.com/apache/cloudstack-documentation/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-documentation] rhtyd opened a new pull request #160: Update to java 11 (#152)

2020-09-23 Thread GitBox
rhtyd opened a new pull request #160: URL: https://github.com/apache/cloudstack-documentation/pull/160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack-documentation] rhtyd merged pull request #160: Update to java 11 (#152)

2020-09-23 Thread GitBox
rhtyd merged pull request #160: URL: https://github.com/apache/cloudstack-documentation/pull/160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-primate] davidjumani commented on pull request #739: addcomputeoffering: Fix typo in storagetype and network rate

2020-09-23 Thread GitBox
davidjumani commented on pull request #739: URL: https://github.com/apache/cloudstack-primate/pull/739#issuecomment-697236381 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #740: [BUG] user with special role can not log on

2020-09-23 Thread GitBox
DaanHoogland commented on issue #740: URL: https://github.com/apache/cloudstack-primate/issues/740#issuecomment-697236306 @davidjumani why would he not have access to those APIs? This is an automated message from the Apache

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #739: addcomputeoffering: Fix typo in storagetype and network rate

2020-09-23 Thread GitBox
blueorangutan commented on pull request #739: URL: https://github.com/apache/cloudstack-primate/pull/739#issuecomment-697236897 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #740: [BUG] user with special role can not log on

2020-09-23 Thread GitBox
DaanHoogland commented on issue #740: URL: https://github.com/apache/cloudstack-primate/issues/740#issuecomment-697239673 btw, it seems this is not primate specific. lopg on fails on the old UI as well. It seems to be a genuine bug though. even when mentioned API are added as allow and *

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #739: addcomputeoffering: Fix typo in storagetype and network rate

2020-09-23 Thread GitBox
blueorangutan commented on pull request #739: URL: https://github.com/apache/cloudstack-primate/pull/739#issuecomment-697241794 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/739 (JID-3

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #8: Some fixes for Go 1.13

2020-09-23 Thread GitBox
onitake commented on pull request #8: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-697241611 Hi @rhtyd it's actually not necessary to require Go 1.15. go.mod should reflect the minimum version required to build the module, which is 1.13. See here: ht

[GitHub] [cloudstack-primate] DaanHoogland edited a comment on issue #740: [BUG] user with special role is denied log on without sensible message

2020-09-23 Thread GitBox
DaanHoogland edited a comment on issue #740: URL: https://github.com/apache/cloudstack-primate/issues/740#issuecomment-697239673 btw, it seems this is not primate specific. log on fails on the old UI as well. It seems to be a genuine bug though. even when mentioned API are added as allow

[GitHub] [cloudstack-primate] rhtyd merged pull request #738: Storage type defaults to shared even on setting to local

2020-09-23 Thread GitBox
rhtyd merged pull request #738: URL: https://github.com/apache/cloudstack-primate/pull/738 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #9: Support loadBalancerSourceRanges

2020-09-23 Thread GitBox
joschi36 commented on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-697263875 Works like a charm. This is an automated message from the Apache Git Service. To respond to t

[GitHub] [cloudstack-primate] DaanHoogland opened a new issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-23 Thread GitBox
DaanHoogland opened a new issue #741: URL: https://github.com/apache/cloudstack-primate/issues/741 **Describe the bug** when deleting a domain with cleanup any child is expected to be gone (subdomains or other things like accounts) **To Reproduce** Steps to reproduce the behavi

[GitHub] [cloudstack-primate] rhtyd merged pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template

2020-09-23 Thread GitBox
rhtyd merged pull request #737: URL: https://github.com/apache/cloudstack-primate/pull/737 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template

2020-09-23 Thread GitBox
rhtyd commented on pull request #737: URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697284475 LGTM @andrijapanicsb can you test latest master now, thnx This is an automated message from the Apache G

[GitHub] [cloudstack-primate] DaanHoogland opened a new issue #742: [BUG] hint/helptext is not fully displayed in empty field

2020-09-23 Thread GitBox
DaanHoogland opened a new issue #742: URL: https://github.com/apache/cloudstack-primate/issues/742 **Describe the bug** when creating an account/user it is expected that help is shown in empty fields. When a field is too short for the full help text, only part is shown and no pop-up on

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #151: cks: root disk controller and nic adapter for CoreOS VMware

2020-09-23 Thread GitBox
rhtyd commented on pull request #151: URL: https://github.com/apache/cloudstack-documentation/pull/151#issuecomment-697284799 cc @andrijapanicsb @nvazquez @Pearl1594 - can you check This is an automated message from the Apac

[GitHub] [cloudstack-primate] rhtyd merged pull request #739: addcomputeoffering: Fix typo in storagetype and network rate

2020-09-23 Thread GitBox
rhtyd merged pull request #739: URL: https://github.com/apache/cloudstack-primate/pull/739 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #650: [BUG] After session expire the page reloads once more

2020-09-23 Thread GitBox
davidjumani edited a comment on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-697213545 @rhtyd If it's a direct reload, the notification that the session has expired won't popup (or will for half a second and then reload to the login page). I think

[GitHub] [cloudstack-primate] DaanHoogland closed issue #742: [BUG] hint/helptext is not fully displayed in empty field

2020-09-23 Thread GitBox
DaanHoogland closed issue #742: URL: https://github.com/apache/cloudstack-primate/issues/742 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #742: [BUG] hint/helptext is not fully displayed in empty field

2020-09-23 Thread GitBox
DaanHoogland commented on issue #742: URL: https://github.com/apache/cloudstack-primate/issues/742#issuecomment-697294320 not a bug , doh: ![image](https://user-images.githubusercontent.com/2486961/94004933-bf560580-fd9d-11ea-9ec9-132b135a7ac0.png) hovering needs to be over the (i)

[GitHub] [cloudstack-primate] rhtyd commented on issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-23 Thread GitBox
rhtyd commented on issue #741: URL: https://github.com/apache/cloudstack-primate/issues/741#issuecomment-697320217 I think we've fixed it, perhaps a regression. @utchoang can you review and fix it? Thanks This is an automat

[GitHub] [cloudstack-primate] rhtyd commented on issue #740: [BUG] user with special role is denied log on without sensible message

2020-09-23 Thread GitBox
rhtyd commented on issue #740: URL: https://github.com/apache/cloudstack-primate/issues/740#issuecomment-697321204 @davidjumani @utchoang maybe if it fails we should log a sensible message that unable to discover features as listApis (or any other essential APIs we expect) is not allowed?

[GitHub] [cloudstack-primate] rhtyd commented on issue #740: [BUG] user with special role is denied log on without sensible message

2020-09-23 Thread GitBox
rhtyd commented on issue #740: URL: https://github.com/apache/cloudstack-primate/issues/740#issuecomment-697321577 There are a bunch of APIs we call on login that "we" expect to work but don't have an error handler - https://github.com/apache/cloudstack-primate/blob/master/src/store/modul

[GitHub] [cloudstack-primate] rhtyd commented on issue #650: [BUG] After session expire the page reloads once more

2020-09-23 Thread GitBox
rhtyd commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-697322265 @davidjumani a lot of apps redirect to login page and don't necessarily announce that the session has expired. One workaround is to show a modal with background blocked/hidde

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #740: [BUG] user with special role is denied log on without sensible message

2020-09-23 Thread GitBox
davidjumani edited a comment on issue #740: URL: https://github.com/apache/cloudstack-primate/issues/740#issuecomment-697323090 @rhtyd There's also the issue of the user being logged out if there's a call being made to a blacklisted API rather than being told that the API doesn't exist or

[GitHub] [cloudstack-primate] davidjumani commented on issue #740: [BUG] user with special role is denied log on without sensible message

2020-09-23 Thread GitBox
davidjumani commented on issue #740: URL: https://github.com/apache/cloudstack-primate/issues/740#issuecomment-697323090 @rhtyd There's also the issue of the user being logged out if there's a call being made to a blacklisted API rather than being told that the API doesn't exist or denied

[GitHub] [cloudstack-primate] rhtyd commented on issue #736: [BUG] Show ISO info/name, instead of just UUID

2020-09-23 Thread GitBox
rhtyd commented on issue #736: URL: https://github.com/apache/cloudstack-primate/issues/736#issuecomment-697331631 I don't see any bug here, we're showing the ISO name (clickable too) and the ISO ID: ![Screenshot from 2020-09-23 17-58-59](https://user-images.githubusercontent.com/95203

[GitHub] [cloudstack-primate] rhtyd commented on issue #736: [BUG] Show ISO info/name, instead of just UUID

2020-09-23 Thread GitBox
rhtyd commented on issue #736: URL: https://github.com/apache/cloudstack-primate/issues/736#issuecomment-697331953 @andrijapanicsb I'm closing this as indeed we show the ISO name, if there's anything else you'd like to add pl reopen. --

[GitHub] [cloudstack-primate] rhtyd closed issue #736: [BUG] Show ISO info/name, instead of just UUID

2020-09-23 Thread GitBox
rhtyd closed issue #736: URL: https://github.com/apache/cloudstack-primate/issues/736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-23 Thread GitBox
rhtyd commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697336281 @utchoang I've created/tested the cases that you can check and fix. Here are the cases: (@andrijapanicsb appreciate if you can be more specific while filing bugs, thanks)

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #736: [BUG] Show ISO info/name, instead of just UUID

2020-09-23 Thread GitBox
andrijapanicsb commented on issue #736: URL: https://github.com/apache/cloudstack-primate/issues/736#issuecomment-697336052 Um... 🤦 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack-primate] rhtyd commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-23 Thread GitBox
rhtyd commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697337277 @utchoang the real issue are only case 2 and 3; it may need tweaking here https://github.com/apache/cloudstack-primate/blob/master/src/components/view/ResourceView.vue#L115 (

[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-23 Thread GitBox
rhtyd edited a comment on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697337277 @utchoang the real issue are only case 2 and 3; it may need tweaking here https://github.com/apache/cloudstack-primate/blob/master/src/components/view/ResourceView.vue#

[GitHub] [cloudstack-primate] rhtyd commented on issue #740: [BUG] user with special role is denied log on without sensible message

2020-09-23 Thread GitBox
rhtyd commented on issue #740: URL: https://github.com/apache/cloudstack-primate/issues/740#issuecomment-697338755 @DaanHoogland usually we require that the following APIs are enabled for Primate to atleast show something (what you're hitting, you'll hit on old UI as well): listApis, list

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #8: Some fixes for Go 1.13

2020-09-23 Thread GitBox
rhtyd commented on pull request #8: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-697339828 I'm okay with the changes, but unable to review or test this. I can merge if you or any other collaborators can do a single review/lgtm and show any tests. Happy

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #6: Improved Ingress Controller example to be clearer and more complete

2020-09-23 Thread GitBox
rhtyd merged pull request #6: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #9: Support loadBalancerSourceRanges

2020-09-23 Thread GitBox
rhtyd commented on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-697340438 Is this ready for merging @onitake @joschi36 ? I can merge after #8 This is an automated messag

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #9: Support loadBalancerSourceRanges

2020-09-23 Thread GitBox
onitake commented on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-697404337 @rhtyd Please go ahead and merge #8 and #9. This is an automated message from the Apache Git S

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #678: [BUG] With VPC - LoadBalancing tab should be hidden if the IP is already used for i.e. Port Forwarding or Static NAT

2020-09-23 Thread GitBox
andrijapanicsb commented on issue #678: URL: https://github.com/apache/cloudstack-primate/issues/678#issuecomment-697418481 > > > @andrijapanicsb can you check the behaviour against old UI? I did check, and went with @davidjumani in details through the old UI etc. This is

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #743: [BUG] Edit instance - offer existing Groups

2020-09-23 Thread GitBox
andrijapanicsb opened a new issue #743: URL: https://github.com/apache/cloudstack-primate/issues/743 ![image](https://user-images.githubusercontent.com/45762285/94028255-08b54d80-fdbc-11ea-9a93-6667ca8eb1cc.png) We fixed this in the VM deployment wizard, but not in the "edit VM" form -

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template

2020-09-23 Thread GitBox
andrijapanicsb commented on pull request #737: URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697477397 LGTM (though it is just a partial solution - hiding those while regiostering template, but can be added later in tempalte/VM details etc.) -

[GitHub] [cloudstack-documentation] shwstppr commented on pull request #151: cks: root disk controller and nic adapter for CoreOS VMware

2020-09-23 Thread GitBox
shwstppr commented on pull request #151: URL: https://github.com/apache/cloudstack-documentation/pull/151#issuecomment-697841753 Was facing issue with root disk resize with other disk controller and nic controller combinations.

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #650: [BUG] After session expire the page reloads once more

2020-09-23 Thread GitBox
DaanHoogland commented on issue #650: URL: https://github.com/apache/cloudstack-primate/issues/650#issuecomment-697923584 @rhtyd that would be very user friendly ;) an short display of an error, that disappears to quick to read is very disturbing. btw, i don't think we should hold relea

[GitHub] [cloudstack-primate] utchoang opened a new pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-23 Thread GitBox
utchoang opened a new pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744 Fixes #678 @rhtyd cc @svenvogel This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack-primate] utchoang commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-23 Thread GitBox
utchoang commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698074843 - Case 1: ![image](https://user-images.githubusercontent.com/13766648/94093917-89ba2680-fe48-11ea-87f7-377cd8d7ae01.png) - Case 2: ![image](https://user-

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-23 Thread GitBox
blueorangutan commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698125525 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-23 Thread GitBox
rhtyd commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698125324 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-23 Thread GitBox
blueorangutan commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698131550 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/744 (JID-3

[GitHub] [cloudstack-primate] utchoang commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-23 Thread GitBox
utchoang commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698142524 Control the` enable static NAT` button - PF or LB rules: ![image](https://user-images.githubusercontent.com/13766648/94108542-b3377a00-fe69-11ea-8564-d9de138f7d0

[GitHub] [cloudstack-primate] utchoang commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-23 Thread GitBox
utchoang commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698142687 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-23 Thread GitBox
blueorangutan commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698143005 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #744: FIX - Networks: Control show/hide PF & LB rules tabs

2020-09-23 Thread GitBox
blueorangutan commented on pull request #744: URL: https://github.com/apache/cloudstack-primate/pull/744#issuecomment-698146835 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/744 (JID-3

[GitHub] [cloudstack-primate] utchoang commented on issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-23 Thread GitBox
utchoang commented on issue #741: URL: https://github.com/apache/cloudstack-primate/issues/741#issuecomment-698147434 @DaanHoogland @rhtyd cc @svenvogel I tried with http://primate-qa.cloudstack.cloud:8080/client/master/ but I can't reproduce the error. When I removed the `sub` domain

[GitHub] [cloudstack-primate] utchoang edited a comment on issue #741: [BUG] when deleting a domain with a subdomain, it remains visible

2020-09-23 Thread GitBox
utchoang edited a comment on issue #741: URL: https://github.com/apache/cloudstack-primate/issues/741#issuecomment-698147434 @DaanHoogland @rhtyd cc @svenvogel I tried with http://primate-qa.cloudstack.cloud:8080/client/master/ but I can't reproduce the error. When I removed the `sub`

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #9: Support loadBalancerSourceRanges

2020-09-23 Thread GitBox
rhtyd merged pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack-kubernetes-provider] rhtyd closed issue #3: [OLD] Implement IP whitelists

2020-09-23 Thread GitBox
rhtyd closed issue #3: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #8: Some fixes for Go 1.13

2020-09-23 Thread GitBox
rhtyd merged pull request #8: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #16: [DISCUSS] Work on next release

2020-09-23 Thread GitBox
rhtyd commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-698153003 ping @onitake - pl advise whenever it's ready for the next release? Thanks This is an automated mes