Re: [PR] Add hostname annotation to set loadbalancer ingress hostname [cloudstack-kubernetes-provider]

2024-05-28 Thread via GitHub
weizhouapache merged PR #48: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-u

Re: [PR] Strip domain from node.Name before matching with vm names [cloudstack-kubernetes-provider]

2024-05-28 Thread via GitHub
weizhouapache merged PR #47: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-u

Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]

2024-05-28 Thread via GitHub
weizhouapache commented on PR #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2135116093 @hrak @vishesh92 it looks this requires some other changes like https://github.com/Leaseweb/cloudstack-kubernetes-provider/commit/323b493f9d35dc0b6c0f6c09