Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818022462 ## cloudstack/service_offering_models.go: ## @@ -0,0 +1,70 @@ +package cloudstack + +import "github.com/hashicorp/terraform-plugin-framework/type

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818021536 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#issuecomment-2439927211 @poddm I haven' tested but PR looks good. Left some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818019962 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818019873 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818019905 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818020077 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +

Re: [PR] service offering. sdk framework rewrite [cloudstack-terraform-provider]

2024-10-27 Thread via GitHub
vishesh92 commented on code in PR #138: URL: https://github.com/apache/cloudstack-terraform-provider/pull/138#discussion_r1818020162 ## cloudstack/service_offering_constrained_resource.go: ## @@ -0,0 +1,270 @@ +package cloudstack + +import ( + "context" + "fmt" + +