Re: svn commit: r563610 - /cocoon/trunk/blocks/cocoon-serializers/cocoon-serializers-charsets/pom.xml

2007-08-07 Thread Carsten Ziegeler
Grzegorz Kossakowski wrote >> >> >> + javax.servlet >> + servlet-api >> + > > > Shouldn't this dependency had scope "provided"? > Good catch, yes, I fixed this in our root pom, so the scope is now "provided" for every use in one of our modules. Carsten -- Carsten Z

[jira] Closed: (COCOON-2095) Make Object Model a Spring bean

2007-08-07 Thread Grzegorz Kossakowski (JIRA)
[ https://issues.apache.org/jira/browse/COCOON-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grzegorz Kossakowski closed COCOON-2095. Resolution: Fixed The goal has been accomplished. Closing issue. > Make Object Mo

[jira] Closed: (COCOON-2092) Switch to new Object Model implementation in cocoon-template

2007-08-07 Thread Grzegorz Kossakowski (JIRA)
[ https://issues.apache.org/jira/browse/COCOON-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grzegorz Kossakowski closed COCOON-2092. Resolution: Fixed The goal has been accomplished. Closing issue. > Switch to new

Re: Strange dependencies in 2.2

2007-08-07 Thread Grzegorz Kossakowski
Carsten Ziegeler pisze: Hi, while briefly looking at current 2.2 I noticed some strange dependencies, for example cocoon-expression-api depends on another impl and cocoon-expression-impl (being part of the core packages) depends on a block impl. If this is just a transient state ignore my messa

Re: svn commit: r563610 - /cocoon/trunk/blocks/cocoon-serializers/cocoon-serializers-charsets/pom.xml

2007-08-07 Thread Grzegorz Kossakowski
[EMAIL PROTECTED] pisze: Author: cziegeler Date: Tue Aug 7 11:37:04 2007 New Revision: 563610 URL: http://svn.apache.org/viewvc?view=rev&rev=563610 Log: Add missing dependency. Modified: cocoon/trunk/blocks/cocoon-serializers/cocoon-serializers-charsets/pom.xml Modified: cocoon/trunk/blo

Re: [vote] Let our environment abtractions extend the http servlet ones

2007-08-07 Thread Alfred Nathaniel
On Tue, 2007-08-07 at 09:46 +0200, Daniel Fagerstrom wrote: > Unfortunately it is more complicated than that. The non-compatible > change is that Request.getSession switches return value from > o.a.c.environment.Session to javax.servlet.http.HttpSession and that > Request.getCookie switch return

[jira] Created: (COCOON-2107) It should be possible to choose which ELs one wants to use and avoid unnecessary dependencies

2007-08-07 Thread Grzegorz Kossakowski (JIRA)
It should be possible to choose which ELs one wants to use and avoid unnecessary dependencies - Key: COCOON-2107 URL: https://issues.apache.org/jira/browse/COCOON-2107

Re: Strange dependencies in 2.2

2007-08-07 Thread Grzegorz Kossakowski
Carsten Ziegeler pisze: I would also be great if the cocoon-expression-impl could be split up into separate modules, so only if I want to use the javascript stuff I have a dep on rhino etc. Yes, that is on my TODO list and with current design (where ELs are just Spring beans) it's really easy t

Re: Strange dependencies in 2.2

2007-08-07 Thread Carsten Ziegeler
I would also be great if the cocoon-expression-impl could be split up into separate modules, so only if I want to use the javascript stuff I have a dep on rhino etc. Carsten Carsten Ziegeler wrote: > Hi, > > while briefly looking at current 2.2 I noticed some strange > dependencies, for example

Re: [jira] Commented: (COCOON-2106) DatabaseReader and SQLTransformer cannot obtain datasource

2007-08-07 Thread Carsten Ziegeler
Discussions should better take place in the mailing list :) Carsten Grzegorz Kossakowski (JIRA) wrote: > [ > https://issues.apache.org/jira/browse/COCOON-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518179 > ] > > Grzegorz Kossakowski commented on CO

Strange dependencies in 2.2

2007-08-07 Thread Carsten Ziegeler
Hi, while briefly looking at current 2.2 I noticed some strange dependencies, for example cocoon-expression-api depends on another impl and cocoon-expression-impl (being part of the core packages) depends on a block impl. If this is just a transient state ignore my message, but if not this has to

[jira] Commented: (COCOON-2106) DatabaseReader and SQLTransformer cannot obtain datasource

2007-08-07 Thread Grzegorz Kossakowski (JIRA)
[ https://issues.apache.org/jira/browse/COCOON-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518179 ] Grzegorz Kossakowski commented on COCOON-2106: -- If registration of wrapper is implemented that bridge w

[jira] Commented: (COCOON-2106) DatabaseReader and SQLTransformer cannot obtain datasource

2007-08-07 Thread JIRA
[ https://issues.apache.org/jira/browse/COCOON-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518178 ] Kazó Csaba commented on COCOON-2106: For the bridge implementation, see commit 553872: http://svn.apache.org/vi

[jira] Commented: (COCOON-2106) DatabaseReader and SQLTransformer cannot obtain datasource

2007-08-07 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/COCOON-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518175 ] Carsten Ziegeler commented on COCOON-2106: -- Hmm where is this SpringToAvalonDataSourceBridge? But apart fr

Re: ObjectModel bug

2007-08-07 Thread Grzegorz Kossakowski
Kazó Csaba pisze: The test should be the other way round. :) Gosh, you are right, of course! Many thanks. :) Fixed permanently, I hope. -- Grzegorz Kossakowski http://reflectingonthevicissitudes.wordpress.com/

[jira] Updated: (COCOON-2106) DatabaseReader and SQLTransformer cannot obtain datasource

2007-08-07 Thread Grzegorz Kossakowski (JIRA)
[ https://issues.apache.org/jira/browse/COCOON-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grzegorz Kossakowski updated COCOON-2106: - Argh, I forgot that DataSourceComponent and DataSource are incompatible. This prove

Re: ObjectModel bug

2007-08-07 Thread Kazó Csaba
The test should be the other way round. :) > Log: > If context object is null do nothing in fillContext method. > > +if (contextObject != null) > +//nothing to do > +return;

Re: ObjectModel bug

2007-08-07 Thread Grzegorz Kossakowski
Kazó Csaba pisze: Hi Grek, Hi, I've spotted a small regression in the stuff you're working on (ObjectModel). It breaks functionality, so I thought I'd make sure you know about it. It happens when using the PipelineUtil functions. These save the current context object, overwrite it with the

Re: What's the use of fillContext method

2007-08-07 Thread Grzegorz Kossakowski
Daniel Fagerstrom pisze: I'm wondering why not to the FlowHelper where context bean is set up? I meant that the code should be *called* from AbstractInterpreter.forwardTo. Done r562896. I'm already moving most of the code of Template and Flow Object Model helpers. Being more explicit

Re: [vote] Let our environment abtractions extend the http servlet ones

2007-08-07 Thread Daniel Fagerstrom
Joerg Heinicke skrev: On 04.08.2007 9:03 Uhr, Daniel Fagerstrom wrote: I don't want this to collide with releasing 2.2, so I'll wait with introducing the changes if there is any risk for that. Can you please clarify what exactly this vote is now about? It is about "letting our environment abt