[jira] Commented: (COCOON-1879) Make fd:field whitespace trimming behavior configurable

2006-07-10 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1879?page=comments#action_12420112 ] Bruno Dumon commented on COCOON-1879: - Looks good. I'd validate the value of the whitespace attribute so that it gives an error when using an unsupported value (to prot

[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator builder

2006-03-23 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371557 ] Bruno Dumon commented on COCOON-1806: - @andrew: save the patch files (javavalidator2.diff and javavalidator-conf.diff) in the cocoon source tree root and do patch -p0

[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator builder

2006-03-23 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371554 ] Bruno Dumon commented on COCOON-1806: - Forgot to mention this: It would be nice if you could add some docs on this new validator on http://cocoon.zones.apache.org/daisy

[jira] Closed: (COCOON-1806) [PATCH] Java class custom validator builder

2006-03-23 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1806?page=all ] Bruno Dumon closed COCOON-1806: --- Fix Version: 2.2-dev (Current SVN) 2.1.9-dev (current SVN) Resolution: Fixed Applied. Thanks for your contribution. PS: the forms blo

[jira] Commented: (COCOON-1806) [PATCH] Java class custom validator builder

2006-03-23 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1806?page=comments#action_12371529 ] Bruno Dumon commented on COCOON-1806: - Hi Simone, If you would let the ValidatorBuilder implement LogEnabled and Contextualizable, you could pass the logger and context

[jira] Commented: (COCOON-1804) Javascript FOM_SCOPE issue when using Java as the flow engine - ReferenceError: "cocoon" is not defined

2006-03-22 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1804?page=comments#action_12371398 ] Bruno Dumon commented on COCOON-1804: - Implementing a WidgetValidator + Builder + adding it to cocoon.xconf should IMO only be done for providing entirely new types of v

[jira] Commented: (COCOON-1777) fd:on-value-changed does not work with fd:multivaluefield

2006-03-10 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1777?page=comments#action_12369858 ] Bruno Dumon commented on COCOON-1777: - I applied your patch, with the submit-on-change change. > fd:on-value-changed does not work with fd:multivaluefield >

[jira] Commented: (COCOON-1777) fd:on-value-changed does not work with fd:multivaluefield

2006-03-10 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1777?page=comments#action_12369849 ] Bruno Dumon commented on COCOON-1777: - Hi, Thanks for your patch. If I understand it correctly, the following will cause auto-submit to be enabled if there are value c

[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file

2006-02-22 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367361 ] Bruno Dumon commented on COCOON-1780: - > If you want to use an image as a button, you can use an > it works fine ! Well yes, but try to combine an image and text in on

[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file

2006-02-22 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367344 ] Bruno Dumon commented on COCOON-1780: - Hi Vincent, It's not really useless code, since it allows more flexibility in rendering. For example, it would allow to use the H

[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file

2006-02-22 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367334 ] Bruno Dumon commented on COCOON-1780: - good you noticed, it's fixed now, I hope. > [PATCH] Upload Widget : Can not change selected file > ---

[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file

2006-02-22 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367320 ] Bruno Dumon commented on COCOON-1780: - @vincent: I don't think there's a problem with that, but since it worked with 'button' before, the real cause of the bug had to be

[jira] Closed: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file

2006-02-21 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1780?page=all ] Bruno Dumon closed COCOON-1780: --- Fix Version: 2.1.9-dev (current SVN) Resolution: Fixed > [PATCH] Upload Widget : Can not change selected file > ---

[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file

2006-02-21 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367248 ] Bruno Dumon commented on COCOON-1780: - I just committed a patch. The cause of the problem is that the submitWidget is now assigned after the readFromRequest processing.

[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file

2006-02-21 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367223 ] Bruno Dumon commented on COCOON-1780: - Thanks for quick follow up. The change in the cforms.js seems related to Ajax, while I'm not using Ajax at all. Also, the upload

[jira] Commented: (COCOON-1780) [PATCH] Upload Widget : Can not change selected file

2006-02-21 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367218 ] Bruno Dumon commented on COCOON-1780: - Hmm, I have exactly the same problem and the patch suggested above, changing button to submit, solves it. How is the provided li

[jira] Commented: (COCOON-1777) fd:on-value-changed does not work with fd:multivaluefield

2006-02-16 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1777?page=comments#action_12366600 ] Bruno Dumon commented on COCOON-1777: - About the docs: you're right. Apparently they were republished just very recently. Yes, 2.1.9-dev supports this, as the forms cod

[jira] Commented: (COCOON-1777) fd:on-value-changed does not work with fd:multivaluefield

2006-02-15 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1777?page=comments#action_12366550 ] Bruno Dumon commented on COCOON-1777: - I have recently added support for value changed listeners for multivaluefields. Cocoon 2.1.8 does not yet support this (as also me

[jira] Commented: (COCOON-1571) [PATCH] NullPointerException in MultiValueField

2006-01-20 Thread Bruno Dumon (JIRA)
[ http://issues.apache.org/jira/browse/COCOON-1571?page=comments#action_12363408 ] Bruno Dumon commented on COCOON-1571: - IMO the locale parameter should not be null. Otherwise we might need to add such a check to every widget. I think it would be bett