Re: [ognl] internal cache performance improvement

2011-06-06 Thread Antonio Petrelli
2011/6/6 Simone Tripodi > my today's topic is about internal cache, that can be IMHO improved in > therms of performance; its implementation is a multi-value map alike, > based on a fixed-size array, a function is applied to each key to > calculate the array index, each array element is a Collect

Re: [pool] getNumActive returning -1

2011-06-06 Thread Phil Steitz
On 6/5/11 7:32 PM, Phil Steitz wrote: > The AbandonedObjectPool test case that I just commented out in > [dbcp] trunk is failing because GOP getNumActive returns -1. My > first thought was that this is a timing issue due to lack of > synchronization in invalidate and general non-protection of > _a

[GUMP@vmgump]: Project commons-lang3 (in module apache-commons) failed

2011-06-06 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-lang3 has an issue affecting its community integration. This issue

[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed

2011-06-06 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-proxy-test has an issue affecting its community integration. This

Re: [ognl] internal cache performance improvement

2011-06-06 Thread Simone Tripodi
Hi Antonio, thanks for reviewing and providing feedbacks! In the existing codebase I don't see any eviction policy, I wonder if that data structure purpose is not for storing large amount of data, but rather just a memory area where quickly looking-up already processed Class related data - I know t

Re: [ognl] internal cache performance improvement

2011-06-06 Thread Antonio Petrelli
2011/6/6 Simone Tripodi > TreeMap sounds reasonable, it's an RB Tree implementation and > insert/retrieve operations have both O(log n) complexity[1], I'd > suggest to start with it and see how things are going, then switch to > LRU if needed. > WDYT? Many thanks in advance! > +1, TreeMap is fin

Re: [GUMP@vmgump]: Project commons-lang3 (in module apache-commons) failed

2011-06-06 Thread sebb
On 6 June 2011 09:24, Gump wrote: > To whom it may engage... > > This is an automated request, but not an unsolicited one. For > more information please visit http://gump.apache.org/nagged.html, > and/or contact the folk at gene...@gump.apache.org. > > Project commons-lang3 has an issue affecting

Travel Assistance applications open for ApacheCon North America 2011

2011-06-06 Thread Matt Benson
The Apache Software Foundation (ASF)'s Travel Assistance Committee (TAC) is now accepting applications for ApacheCon North America 2011, 7-11 November in Vancouver BC, Canada. The TAC is seeking individuals from the Apache community at-large --users, developers, educators, students, Committers, an

[ANNOUNCE] Commons NET 3.0.1 released

2011-06-06 Thread sebb
The Apache Commons Net team are pleased to announce the release of Commons Net version 3.0.1. *** This is a bug-fix release which corrects a regression in 3.0 *** * NET-409: FTPClient truncates file (storeFile method). All users are encouraged to upgrade to 3.0.1. This release is binary compati

Re: [ognl] internal cache performance improvement

2011-06-06 Thread Gary Gregory
Does concurrency need to be taken into account for the cache? If so, you need to consider how access to the cache will be synchronized. An intrinsic lock? A ConcurrentHashMap? and so on. Gary On Mon, Jun 6, 2011 at 2:36 AM, Simone Tripodi wrote: > Hi all OGNL folks, > my today's topic is about i

Re: [ognl] internal cache performance improvement

2011-06-06 Thread Maurizio Cucchiara
Gary hit the nail on the head, considering that OGNL usually runs in a multi-thread environment like struts, concurrency is a must. At first glance LRUMap would seem the appropriate choice (it was thought for this purpose), unfortunately LRUMap is not thread safe, surely we can wrap using Collectio

RE: [ognl] internal cache performance improvement

2011-06-06 Thread Jason Pyeron
> -Original Message- > From: maurizio.cucchi...@gmail.com > [mailto:maurizio.cucchi...@gmail.com] On Behalf Of Maurizio Cucchiara > Sent: Monday, June 06, 2011 12:14 > To: Commons Developers List > Subject: Re: [ognl] internal cache performance improvement > > Gary hit the nail on the hea

Re: [ognl] internal cache performance improvement

2011-06-06 Thread Maurizio Cucchiara
Jason, you're right there is one OGNL context per request in struts, but at the time that the OGNL code was written, concurrency was taken into account, so at this point I think we don't have other choice (there could be other projects that rely on the OGNL thread-safety). On 6 June 2011 18:24, Ja

Re: [GUMP@vmgump]: Project commons-lang3 (in module apache-commons) failed

2011-06-06 Thread Jörg Schaible
sebb wrote: > On 6 June 2011 09:24, Gump wrote: >> To whom it may engage... >> >> This is an automated request, but not an unsolicited one. For >> more information please visit http://gump.apache.org/nagged.html, >> and/or contact the folk at gene...@gump.apache.org. >> >> Project commons-lang3 h

Re: [GUMP@vmgump]: Project commons-lang3 (in module apache-commons) failed

2011-06-06 Thread sebb
On 6 June 2011 22:47, Jörg Schaible wrote: > sebb wrote: > >> On 6 June 2011 09:24, Gump wrote: >>> To whom it may engage... >>> >>> This is an automated request, but not an unsolicited one. For >>> more information please visit http://gump.apache.org/nagged.html, >>> and/or contact the folk at g

Re: [ognl] internal cache performance improvement

2011-06-06 Thread Maurizio Cucchiara
Simone, > a look at put( Class key, T value )[1] implementation of Aside that put method is public, IIUC the only class that calls "put" is only the OgnlRuntime one (and almost every time it invokes inside a sync block). > ClassCacheImpl: the whole block should be controlled by a concurrency > p

Travel Assistance applications now open for ApacheCon NA 2011

2011-06-06 Thread Phil Steitz
The Apache Software Foundation (ASF)'s Travel Assistance Committee (TAC) is now accepting applications for ApacheCon North America 2011, 7-11 November in Vancouver BC, Canada. The TAC is seeking individuals from the Apache community at-large --users, developers, educators, students, Committers, an

Re: [ognl] internal cache performance improvement

2011-06-06 Thread Maurizio Cucchiara
Forget about key collision, obviously there is no collisions fro a non-hash functions. On 7 June 2011 02:43, Maurizio Cucchiara wrote: > Simone, > >> a look at put( Class key, T value )[1] implementation of > > Aside that put method is public, IIUC the only class that calls "put" > is only the Og