[GUMP@vmgump]: Project commons-vfs2-test (in module apache-commons) failed

2012-03-16 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-vfs2-test has an issue affecting its community integration. This i

[GUMP@vmgump]: Project commons-id (in module commons-sandbox) failed

2012-03-16 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-id has an issue affecting its community integration. This issue af

[GUMP@vmgump]: Project commons-proxy-test (in module apache-commons) failed

2012-03-16 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-proxy-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-configuration-test (in module apache-commons) failed

2012-03-16 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-configuration-test has an issue affecting its community integrati

Re: [GUMP@vmgump]: Project commons-graph (in module commons-sandbox) failed

2012-03-16 Thread Stefan Bodewig
This is Gump running on commons-graph for the first time it has re-entered the Sandbox. I've set it up to run mvn2's install goal on trunk of commons-graph. vmgump runs openjdk6. Stefan - To unsubscribe, e-mail: dev-unsubscr...@

[continuum] BUILD FAILURE: Apache Commons - Commons Pool - Default Maven 2 Build Definition (Java 1.5)

2012-03-16 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=20221&projectId=98 Build statistics: State: Failed Previous State: Failed Started at: Sat 17 Mar 2012 05:23:27 + Finished at: Sat 17 Mar 2012 05:23:34 + Total time: 6s Build Trigger: Schedule Buil

[GUMP@vmgump]: Project commons-scxml-test (in module apache-commons) failed

2012-03-16 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-scxml-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-collections4-testframework (in module apache-commons) failed

2012-03-16 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-collections4-testframework has an issue affecting its community i

[GUMP@vmgump]: Project commons-graph (in module commons-sandbox) failed

2012-03-16 Thread commons-graph development
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-graph has an issue affecting its community integration. This issue

[GUMP@vmgump]: Project commons-exec-test (in module apache-commons) failed

2012-03-16 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-exec-test has an issue affecting its community integration. This i

[GUMP@vmgump]: Project commons-digester3 (in module apache-commons) failed

2012-03-16 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-digester3 has an issue affecting its community integration. This i

Re: [VOTE] Release Commons IO 2.2-RC1

2012-03-16 Thread sebb
On 16 March 2012 05:02, Gary Gregory wrote: > Hello All: > > This is a VOTE to release Commons IO 2.2-RC1 > > This VOTE is open for at least 72 hours until March 19 2012 at 01:30 EST. > > The files: > > https://repository.apache.org/content/repositories/orgapachecommons-080/ The jars were not bui

Re: [graph] exporter migration in branch

2012-03-16 Thread Simone Tripodi
Hi Thomas, please see r1301848 - this is something prototypal and suggestions are much more than welcome! I'd encourage all [graph] people on experimenting stuff on a proper branch, everybody shall feel free to setup a branch and working on it! All the best, -Simo http://people.apache.org/~simon

Re: [graph] exporter migration in branch

2012-03-16 Thread Simone Tripodi
Hi Thomas, I have a proposal almost ready on my local machine, I'll show you as soon as possible in order you can review and share your thoughts. The GraphML exporter was an external contribution - I never used Thinkerpop stuff and don't know details, apologize... which action you suggest to take

[continuum] BUILD FAILURE: Apache Commons - Apache Commons Digester - Default Maven 2 Build Definition (Java 1.5)

2012-03-16 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=20205&projectId=75 Build statistics: State: Failed Previous State: Failed Started at: Fri 16 Mar 2012 23:20:06 + Finished at: Fri 16 Mar 2012 23:21:04 + Total time: 57s Build Trigger: Schedule Bui

Re: [lang] static methods with final keyword

2012-03-16 Thread Matt Benson
On Fri, Mar 16, 2012 at 5:40 PM, Christian Grobmeier wrote: > In langs StringEscapeUtils are some static methods marked with > final... it makes no sense to me to do that. I would like to remove > the final keywords. Any objections? not sure if this breaks bc (cannot > imagine) > +1 There is tec

[lang] static methods with final keyword

2012-03-16 Thread Christian Grobmeier
In langs StringEscapeUtils are some static methods marked with final... it makes no sense to me to do that. I would like to remove the final keywords. Any objections? not sure if this breaks bc (cannot imagine) Cheers -- http://www.grobmeier.de https://www.timeandbill.de ---

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread Emmanuel Bourg
Choice is good I agree. Commons CSV will also support annotated POJO, that will give two ways to use the API. Emmanuel Bourg Le 16/03/2012 22:26, Simone Tripodi a écrit : Hi all, whatever name/pattern is called what we intend to apply, the result doesn't change :P Jokes a part, given the pa

Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

2012-03-16 Thread Gary Gregory
On Fri, Mar 16, 2012 at 5:04 PM, Thomas Neidhart wrote: > On 03/16/2012 09:54 PM, Gary Gregory wrote: > > >> not exactly, there is a mistake ;-) > >> > >> CODEC-63 (NYSIIS) was initially reported (with patch) by Henri. > >> CODEC-121 (QuotedPrintableCodec) was reported by javajohn. > >> > >> I did

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread Simone Tripodi
Hi all, whatever name/pattern is called what we intend to apply, the result doesn't change :P Jokes a part, given the past experience of Digester3, as reported by Matt and James, I can suggest you to not limit to users the possibilities to chose their preferred approaches. Digester3 - which of c

Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

2012-03-16 Thread Thomas Neidhart
On 03/16/2012 09:54 PM, Gary Gregory wrote: >> not exactly, there is a mistake ;-) >> >> CODEC-63 (NYSIIS) was initially reported (with patch) by Henri. >> CODEC-121 (QuotedPrintableCodec) was reported by javajohn. >> >> I did enquire myself for a due-to but rather giving the correct one for >> NY

Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

2012-03-16 Thread Gary Gregory
On Fri, Mar 16, 2012 at 4:06 PM, Thomas Neidhart wrote: > On 03/16/2012 08:59 PM, Gary Gregory wrote: > > On Fri, Mar 16, 2012 at 3:52 PM, Thomas Neidhart > > wrote: > > > >> On 03/16/2012 08:48 PM, ggreg...@apache.org wrote: > >>> Author: ggregory > >>> Date: Fri Mar 16 19:48:48 2012 > >>> New Re

Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

2012-03-16 Thread Thomas Neidhart
On 03/16/2012 08:59 PM, Gary Gregory wrote: > On Fri, Mar 16, 2012 at 3:52 PM, Thomas Neidhart > wrote: > >> On 03/16/2012 08:48 PM, ggreg...@apache.org wrote: >>> Author: ggregory >>> Date: Fri Mar 16 19:48:48 2012 >>> New Revision: 1301719 >>> >>> URL: http://svn.apache.org/viewvc?rev=1301719&vi

Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

2012-03-16 Thread Gary Gregory
On Fri, Mar 16, 2012 at 3:52 PM, Thomas Neidhart wrote: > On 03/16/2012 08:48 PM, ggreg...@apache.org wrote: > > Author: ggregory > > Date: Fri Mar 16 19:48:48 2012 > > New Revision: 1301719 > > > > URL: http://svn.apache.org/viewvc?rev=1301719&view=rev > > Log: > > Set issue to add, not fix. > >

Re: svn commit: r1301719 - /commons/proper/codec/trunk/src/changes/changes.xml

2012-03-16 Thread Thomas Neidhart
On 03/16/2012 08:48 PM, ggreg...@apache.org wrote: > Author: ggregory > Date: Fri Mar 16 19:48:48 2012 > New Revision: 1301719 > > URL: http://svn.apache.org/viewvc?rev=1301719&view=rev > Log: > Set issue to add, not fix. > > Modified: > commons/proper/codec/trunk/src/changes/changes.xml > >

Re: [VOTE] Release Commons IO 2.2-RC1

2012-03-16 Thread Gary Gregory
On Fri, Mar 16, 2012 at 1:45 PM, Luc Maisonobe wrote: > Le 16/03/2012 06:02, Gary Gregory a écrit : > > Hello All: > > Hi Gary, > > Minor nitpicking: > > - the copyright header on NOTICE is 2002-2011 instead of 2002-2012 > - the title of the release notes refers to Commons IO 2.1 (but a few >

Re: [VOTE] Release Commons IO 2.2-RC1

2012-03-16 Thread Luc Maisonobe
Le 16/03/2012 06:02, Gary Gregory a écrit : > Hello All: Hi Gary, Minor nitpicking: - the copyright header on NOTICE is 2002-2011 instead of 2002-2012 - the title of the release notes refers to Commons IO 2.1 (but a few lines after title, 2.2 is correctly referenced) This seems minor to me

[graph] exporter migration in branch

2012-03-16 Thread Thomas Neidhart
Hi, I have looked into the issue with the graph exporters in the branch, and as we now store any kind of object as Vertex / Edge, it is not obvious how to export such objects. When looking at something like tinkerpop/blueprints, they have a PropertyGraph that can store arbitrary properties for ea

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread James Carman
Did I say they were the same? On Mar 16, 2012 12:22 PM, "Emmanuel Bourg" wrote: > Le 16/03/2012 13:34, James Carman a écrit : > >> +1 for builder pattern and fluent API >> > > Fluent API != Builder Pattern > > They are similar because they use method chaining, but that's not > equivalent. > > htt

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread Emmanuel Bourg
Le 16/03/2012 13:34, James Carman a écrit : +1 for builder pattern and fluent API Fluent API != Builder Pattern They are similar because they use method chaining, but that's not equivalent. http://martinfowler.com/bliki/FluentInterface.html http://en.wikipedia.org/wiki/Fluent_interface ht

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread James Carman
Yes this reminds me very much of the digester3 scenario. Let's start coding and quit talking! As sebb pointed out, this is unreleased (at least from our pmc) code. Let's try on a few of the alternatives and see which one looks/feels better (does this API make my butt look big?). On Mar 16, 2012

Re: [csv] Improving readability in CSVLexer

2012-03-16 Thread Emmanuel Bourg
Le 16/03/2012 17:01, Emmanuel Bourg a écrit : 2. add additional convenience methods Right now we have some methods for char handling like isEndOfFile(c). There are some methods missing like isDelimiter(c) or isEncapsulator(c). There is not much to say about this. I just think that isDelimiter(c)

Re: [csv] Improving readability in CSVLexer

2012-03-16 Thread Emmanuel Bourg
Le 16/03/2012 13:33, Benedikt Ritter a écrit : 1. eliminate Token input parameter on nextToken() To me it looks like the token input parameter on nextToken() has the purpose of sparing object creation. How about a private field 'currentToken' that can be reused. No method parameters are better t

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread sebb
On 16 March 2012 14:53, Matt Benson wrote: > The votes show that several of us in the Commons community are leaning > more and more toward fluent APIs these days.  But rather than wasting > time going back and forth arguing about it, why not build the fluent > API separately from the rest of the p

Re: [csv] Improving readability in CSVLexer

2012-03-16 Thread sebb
On 16 March 2012 12:33, Benedikt Ritter wrote: > Hey, > > I'm thinking of ways to improve the readability of CSVLexer. I think > that it might be easier to improve performance if the code is easier > to understand. Here is, what I think can be improved: > > 1. eliminate Token input parameter on ne

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread Matt Benson
The votes show that several of us in the Commons community are leaning more and more toward fluent APIs these days. But rather than wasting time going back and forth arguing about it, why not build the fluent API separately from the rest of the package and leave the choice up to the user? I don't

[GUMP@vmgump]: Project commons-exec-test (in module apache-commons) failed

2012-03-16 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-exec-test has an issue affecting its community integration. This i

[continuum] BUILD FAILURE: Apache Commons - Apache Commons Digester - Default Maven 2 Build Definition (Java 1.5)

2012-03-16 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=20186&projectId=75 Build statistics: State: Failed Previous State: Failed Started at: Fri 16 Mar 2012 14:20:10 + Finished at: Fri 16 Mar 2012 14:21:28 + Total time: 1m 17s Build Trigger: Schedule

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread James Carman
+1 for builder pattern and fluent API On Mar 16, 2012 4:24 AM, "Benedikt Ritter" wrote: > Am 15. März 2012 21:20 schrieb Emmanuel Bourg : > > Le 15/03/2012 20:26, Benedikt Ritter a écrit : > > > > > >> How about you Emmanuel? Could sebb convince you? ;-) How about this: > >> I'll create a patch a

[csv] Improving readability in CSVLexer

2012-03-16 Thread Benedikt Ritter
Hey, I'm thinking of ways to improve the readability of CSVLexer. I think that it might be easier to improve performance if the code is easier to understand. Here is, what I think can be improved: 1. eliminate Token input parameter on nextToken() To me it looks like the token input parameter on n

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread sebb
Have a look at the sample builder implementation in https://issues.apache.org/jira/browse/CSV-68 On 16 March 2012 09:45, Emmanuel Bourg wrote: > Hi Benedikt, > > >> I accept that, and I respect your decision. I don't want to argue with >> you on this, I just want to understand your decision. Fro

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread Emmanuel Bourg
Hi Benedikt, I accept that, and I respect your decision. I don't want to argue with you on this, I just want to understand your decision. From Effective Java, I learned "if you are facing a constructor with lots of optional arguments, consider using the builder pattern". Can you explain, why you

Re: [csv] Why does CSVFormat provide a validate() method instead of validating parameters passed to its constructor?

2012-03-16 Thread Benedikt Ritter
Am 15. März 2012 21:20 schrieb Emmanuel Bourg : > Le 15/03/2012 20:26, Benedikt Ritter a écrit : > > >> How about you Emmanuel? Could sebb convince you? ;-) How about this: >> I'll create a patch and attach it to JIRA. Then we'll have a better >> basis for discussion. > > > Sorry but I'm not convin

Re: svn commit: r1301177 - /commons/proper/digester/trunk/core/src/main/java/org/apache/commons/digester3/binder/AbstractRulesModule.java

2012-03-16 Thread Simone Tripodi
Hi Seb! > If the problem is due to multi-threading issues, isn't that because > the same instance is being shared between threads, presumably on > purpose? > while it is known that the Digester is not thread-safety, the DigesterLoader (that corresponds to its Factory, or Builder) shall allow user