Re: [OGNL] A new release

2013-03-07 Thread Christian Grobmeier
On Wed, Mar 6, 2013 at 10:11 AM, sebb wrote: > On 6 March 2013 06:49, Lukasz Lenart wrote: >> Hi, >> >> I was checking out what should be solved before releasing a new >> version and in my opinion most of PMD [1] errors can be omitted, maybe >> "These nested if statements could be combined" shoul

Re: svn commit: r1454037 - /commons/proper/math/trunk/src/main/assembly/src.xml

2013-03-07 Thread Thomas Neidhart
On 03/08/2013 01:49 AM, sebb wrote: > On 7 March 2013 19:29, wrote: >> Author: tn >> Date: Thu Mar 7 19:29:41 2013 >> New Revision: 1454037 >> >> URL: http://svn.apache.org/r1454037 >> Log: >> Exclude download cgi from source distribution. >> >> Modified: >> commons/proper/math/trunk/src/mai

Re: svn commit: r853535 [1/2] - /websites/production/commons/content/proper/commons-math/

2013-03-07 Thread Thomas Neidhart
On 03/08/2013 01:54 AM, sebb wrote: > On 7 March 2013 20:35, wrote: >> Author: tn >> Date: Thu Mar 7 20:35:01 2013 >> New Revision: 853535 >> >> Log: >> Update javadoc links. > > I assume this is to correct a faulty site build? > > Or will this have to be done after every site build/deploy? >

Re: svn commit: r1453990 - /commons/proper/math/trunk/doc/release/release.howto.txt

2013-03-07 Thread Thomas Neidhart
On 03/08/2013 01:45 AM, sebb wrote: > On 7 March 2013 18:36, wrote: >> Author: tn >> Date: Thu Mar 7 18:36:15 2013 >> New Revision: 1453990 >> >> URL: http://svn.apache.org/r1453990 >> Log: >> Fix first step in release howto. >> >> Modified: >> commons/proper/math/trunk/doc/release/release.h

Re: [CANCEL][VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-07 Thread Thomas Neidhart
On 03/08/2013 01:25 AM, sebb wrote: > On 7 March 2013 18:49, Thomas Neidhart wrote: >> On 03/05/2013 11:08 PM, Thomas Neidhart wrote: >>> Hi, >>> >>> I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC1. >>> >>> This release candidate has the following changes compared to 1.1.1

Re: svn commit: r1454057 - /commons/proper/fileupload/trunk/pom.xml

2013-03-07 Thread Simone Tripodi
>> releng: added RC profile for staging site deployment > > Is that intended to merge with / override the rc profile in parent, or > does it have a different function? > If so, it should have a different name. to be merged in the one defined in the parent - IIUC the parent in RC doesn't provide th

Re: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-07 Thread Benedikt Ritter
Hi, Niall, thanks for stepping in for me. It felt harsh to me too to see the veto, especially when having the the committers guide [1] in mind that states "In extreme situations, it may be necessary to veto (-1) a commit but please beware that this is an extreme sanction and rarely warranted." Thi

Re: svn commit: r1454057 - /commons/proper/fileupload/trunk/pom.xml

2013-03-07 Thread sebb
On 7 March 2013 19:52, wrote: > Author: simonetripodi > Date: Thu Mar 7 19:52:39 2013 > New Revision: 1454057 > > URL: http://svn.apache.org/r1454057 > Log: > releng: added RC profile for staging site deployment Is that intended to merge with / override the rc profile in parent, or does it have

Re: svn commit: r1454037 - /commons/proper/math/trunk/src/main/assembly/src.xml

2013-03-07 Thread sebb
On 7 March 2013 19:29, wrote: > Author: tn > Date: Thu Mar 7 19:29:41 2013 > New Revision: 1454037 > > URL: http://svn.apache.org/r1454037 > Log: > Exclude download cgi from source distribution. > > Modified: > commons/proper/math/trunk/src/main/assembly/src.xml > > Modified: commons/proper/

Re: svn commit: r1453990 - /commons/proper/math/trunk/doc/release/release.howto.txt

2013-03-07 Thread sebb
On 7 March 2013 18:36, wrote: > Author: tn > Date: Thu Mar 7 18:36:15 2013 > New Revision: 1453990 > > URL: http://svn.apache.org/r1453990 > Log: > Fix first step in release howto. > > Modified: > commons/proper/math/trunk/doc/release/release.howto.txt > > Modified: commons/proper/math/trunk

Re: [CANCEL][VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-07 Thread sebb
On 7 March 2013 18:49, Thomas Neidhart wrote: > On 03/05/2013 11:08 PM, Thomas Neidhart wrote: >> Hi, >> >> I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC1. >> >> This release candidate has the following changes compared to 1.1.1 >> (copied from the release notes): >> >> F

Re: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-07 Thread Niall Pemberton
On Thu, Mar 7, 2013 at 11:54 PM, Mark Thomas wrote: > On 07/03/2013 23:39, Niall Pemberton wrote: >> On Sun, Mar 3, 2013 at 3:32 PM, sebb wrote: >>> On 3 March 2013 13:25, wrote: Author: britter Date: Sun Mar 3 13:25:24 2013 New Revision: 1452037 URL: http://svn.apache

Re: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-07 Thread Mark Thomas
On 07/03/2013 23:39, Niall Pemberton wrote: > On Sun, Mar 3, 2013 at 3:32 PM, sebb wrote: >> On 3 March 2013 13:25, wrote: >>> Author: britter >>> Date: Sun Mar 3 13:25:24 2013 >>> New Revision: 1452037 >>> >>> URL: http://svn.apache.org/r1452037 >>> Log: >>> Add JavaDoc and SVN Keywords >> >>

Re: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-07 Thread Niall Pemberton
On Sun, Mar 3, 2013 at 3:32 PM, sebb wrote: > On 3 March 2013 13:25, wrote: >> Author: britter >> Date: Sun Mar 3 13:25:24 2013 >> New Revision: 1452037 >> >> URL: http://svn.apache.org/r1452037 >> Log: >> Add JavaDoc and SVN Keywords > > -1 > > Please don't use $Date$ - it is rendered using th

Re: [logging] IBM JDK and ReferenceQueue

2013-03-07 Thread Jörg Schaible
Hi Thomas, Thomas Neidhart wrote: [snip] > Anyway, the logic in WeakHashtable is flawed, as it relies on the queue > to purge elements from the table. When considering for example the > elements method: > > public Enumeration elements() { > purge(); > return super.elements()

Re: [logging] IBM JDK and ReferenceQueue

2013-03-07 Thread Thomas Neidhart
On 03/07/2013 11:09 PM, Thomas Neidhart wrote: > Hi, > > I have installed the following JDK on my machine: > > java version "1.6.0" > Java(TM) SE Runtime Environment (build pxi3260sr12-20121025_01(SR12)) > IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux x86-32 > jvmxi3260sr12-20121024_126067 (JI

Re: [logging] IBM JDK and ReferenceQueue

2013-03-07 Thread Jörg Schaible
Hi Thomas, Thomas Neidhart wrote: > Hi, > > I have installed the following JDK on my machine: > > java version "1.6.0" > Java(TM) SE Runtime Environment (build pxi3260sr12-20121025_01(SR12)) > IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux x86-32 > jvmxi3260sr12-20121024_126067 (JIT enabled,

Re: [logging] IBM JDK and ReferenceQueue

2013-03-07 Thread Thomas Neidhart
On 03/07/2013 11:09 PM, Thomas Neidhart wrote: > Hi, > > I have installed the following JDK on my machine: > > java version "1.6.0" > Java(TM) SE Runtime Environment (build pxi3260sr12-20121025_01(SR12)) > IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux x86-32 > jvmxi3260sr12-20121024_126067 (JI

[logging] IBM JDK and ReferenceQueue

2013-03-07 Thread Thomas Neidhart
Hi, I have installed the following JDK on my machine: java version "1.6.0" Java(TM) SE Runtime Environment (build pxi3260sr12-20121025_01(SR12)) IBM J9 VM (build 2.4, JRE 1.6.0 IBM J9 2.4 Linux x86-32 jvmxi3260sr12-20121024_126067 (JIT enabled, AOT enabled) J9VM - 20121024_126067 JIT - r9_201209

Re: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-07 Thread Benedikt Ritter
2013/3/7 Simone Tripodi > > I have changed this for Jira422TestCase.java in r1453986. As I said there > > are a lot of classes that also use the combination of $Revision$ and > > $Date$. I think I can go ahead and replace those also? > > Consistency is IMHO a good thing, and in that specific case

Re: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-07 Thread Simone Tripodi
> I have changed this for Jira422TestCase.java in r1453986. As I said there > are a lot of classes that also use the combination of $Revision$ and > $Date$. I think I can go ahead and replace those also? Consistency is IMHO a good thing, and in that specific case I'd go ahead for $Id$ only my 2 c

[CANCEL][VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-07 Thread Thomas Neidhart
On 03/05/2013 11:08 PM, Thomas Neidhart wrote: > Hi, > > I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC1. > > This release candidate has the following changes compared to 1.1.1 > (copied from the release notes): > > Fixed Bugs: > o LOGGING-124: The jar manifest now cont

Re: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java

2013-03-07 Thread Benedikt Ritter
I have changed this for Jira422TestCase.java in r1453986. As I said there are a lot of classes that also use the combination of $Revision$ and $Date$. I think I can go ahead and replace those also? Benedikt 2013/3/5 Benedikt Ritter > I'm a bit short on time right now. I'll try to have another

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread Simone Tripodi
> Done, but it will take some while to find out if the changes are > correct, as Gump runs take several days at present. > > There's a problem that causes the Maven repo proxy to hang sometimes. > See Gump list for details > > http://mail-archives.apache.org/mod_mbox/gump-general/201301.mbox/%3C87e

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread sebb
On 7 March 2013 16:16, sebb wrote: > On 7 March 2013 16:02, Simone Tripodi wrote: I agree the build file cannot be dropped whilst it is still used by Gump, but can't we update FileUpload to use Maven for Gump builds? [Most other components now use Maven with Gump] If so,

Re: [collections] Raising issues for IBM JDK

2013-03-07 Thread Thomas Neidhart
On Thu, Mar 7, 2013 at 5:23 PM, Mark Thomas wrote: > On 07/03/2013 16:19, Thomas Neidhart wrote: > > Hi, > > > > after testing ours tests with IBM JDK 6 I found several bugs in the > TreeMap > > imlementation of this JRE. > > Some of them I could work-around (e.g. non-synced Map.Entry setValue wi

Re: [collections] Raising issues for IBM JDK

2013-03-07 Thread Davanum Srinivas
Thomas, the web page indicates. i'd suggest doing that to see if it helps * Post a message on the Java Runtimes and SDKs Java Runtimes and SDKs Forum. * Send an email directly to us at our Java Tools email. -- dims On Thu, Mar 7, 2013 at 11:19 AM, Thomas Neidhart wrote: > Hi, > > after testing

Re: [collections] Raising issues for IBM JDK

2013-03-07 Thread Mark Thomas
On 07/03/2013 16:19, Thomas Neidhart wrote: > Hi, > > after testing ours tests with IBM JDK 6 I found several bugs in the TreeMap > imlementation of this JRE. > Some of them I could work-around (e.g. non-synced Map.Entry setValue with > backing map), but some are more serious and would also requir

[collections] Raising issues for IBM JDK

2013-03-07 Thread Thomas Neidhart
Hi, after testing ours tests with IBM JDK 6 I found several bugs in the TreeMap imlementation of this JRE. Some of them I could work-around (e.g. non-synced Map.Entry setValue with backing map), but some are more serious and would also require that certain tests to be disabled when run with an IBM

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread sebb
On 7 March 2013 16:02, Simone Tripodi wrote: >>> I agree the build file cannot be dropped whilst it is still used by Gump, >>> but can't we update FileUpload to use Maven for Gump builds? >>> [Most other components now use Maven with Gump] >>> >>> If so, that would surely satisfy the dependencies?

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread Simone Tripodi
>> I agree the build file cannot be dropped whilst it is still used by Gump, >> but can't we update FileUpload to use Maven for Gump builds? >> [Most other components now use Maven with Gump] >> >> If so, that would surely satisfy the dependencies? > > Sure, but that wasn't what was being proposed.

Re: svn commit: r1453909 - /commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml

2013-03-07 Thread Simone Tripodi
> > Is there a check to ensure package-info.java exists? > yes, just plugged, it is the http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ - To

Re: [fileupload] suppressing "Line is longer than 80 characters." rules

2013-03-07 Thread Simone Tripodi
> OK to change Checkstyle/PMD to eliminate warnings. > > But I would avoid rewrapping to the new line length unless it's > obviously easier to read. sure, just to suppress warnings, no more additional work intended http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ htt

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread Mark Thomas
On 07/03/2013 15:43, sebb wrote: > On 7 March 2013 15:34, Mark Thomas wrote: >> On 07/03/2013 12:11, Simone Tripodi wrote: >>> Hi all guys, >>> >>> while the Maven parent and specific component pom continue to evolve >>> during the time, last update on Ant files is back to 2010, gump >>> related f

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread sebb
On 7 March 2013 15:34, Mark Thomas wrote: > On 07/03/2013 12:11, Simone Tripodi wrote: >> Hi all guys, >> >> while the Maven parent and specific component pom continue to evolve >> during the time, last update on Ant files is back to 2010, gump >> related files to 2007, I think it would make sense

Re: svn commit: r1453831 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java

2013-03-07 Thread sebb
On 7 March 2013 12:52, wrote: > Author: simonetripodi > Date: Thu Mar 7 12:52:04 2013 > New Revision: 1453831 > > URL: http://svn.apache.org/r1453831 > Log: > checkstyle: Avoid inline conditionals. I think Checkstyle is wrong in this case. > Modified: > > commons/proper/fileupload/trunk/s

Re: [fileupload] suppressing "Line is longer than 80 characters." rules

2013-03-07 Thread Mark Thomas
On 07/03/2013 12:33, Simone Tripodi wrote: > Hi all, > > I am going to increase the Line length up to 120 chars - any objections? I prefer 80 but I don't do anywhere near enough work on FileUpload for my views to carry much weight. Mark -

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread Mark Thomas
On 07/03/2013 12:11, Simone Tripodi wrote: > Hi all guys, > > while the Maven parent and specific component pom continue to evolve > during the time, last update on Ant files is back to 2010, gump > related files to 2007, I think it would make sense to drop them > > Opinions? -1 build-gump.xml i

Re: svn commit: r1453909 - /commons/proper/fileupload/trunk/src/checkstyle/fileupload_checks.xml

2013-03-07 Thread sebb
On 7 March 2013 15:05, wrote: > Author: simonetripodi > Date: Thu Mar 7 15:05:17 2013 > New Revision: 1453909 > > URL: http://svn.apache.org/r1453909 > Log: > checkstyle: PackageHtml module no longer needed, package documentation moved > from package.html to package-info.java Is there a check

Re: [fileupload] suppressing "Line is longer than 80 characters." rules

2013-03-07 Thread sebb
On 7 March 2013 12:33, Simone Tripodi wrote: > Hi all, > > I am going to increase the Line length up to 120 chars - any objections? OK to change Checkstyle/PMD to eliminate warnings. But I would avoid rewrapping to the new line length unless it's obviously easier to read. > TIA, > -Simo > > htt

Re: [fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread sebb
OK by me. On 7 March 2013 12:11, Simone Tripodi wrote: > Hi all guys, > > while the Maven parent and specific component pom continue to evolve > during the time, last update on Ant files is back to 2010, gump > related files to 2007, I think it would make sense to drop them > > Opinions? > TIA! >

Re: [fileupload] suppressing "Line is longer than 80 characters." rules

2013-03-07 Thread Gary Gregory
On Mar 7, 2013, at 7:34, Simone Tripodi wrote: > Hi all, > > I am going to increase the Line length up to 120 chars +1 Gary > - any objections? > > TIA, > -Simo > > http://people.apache.org/~simonetripodi/ > http://simonetripodi.livejournal.com/ > http://twitter.com/simonetripodi > http://www.

[fileupload] suppressing "Line is longer than 80 characters." rules

2013-03-07 Thread Simone Tripodi
Hi all, I am going to increase the Line length up to 120 chars - any objections? TIA, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/

[fileupload] dropping ant/gump related XML descriptors

2013-03-07 Thread Simone Tripodi
Hi all guys, while the Maven parent and specific component pom continue to evolve during the time, last update on Ant files is back to 2010, gump related files to 2007, I think it would make sense to drop them Opinions? TIA! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.liv

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-07 Thread sebb
Remember there is a -Ptest-deploy profile that can be used to test what will be deployed. This puts the output in target/deploy I've found it's sometimes necessary to use "package" as well as "deploy" to ensure everything is included in the deploy phase. On 7 March 2013 11:36, Thomas Neidhart w

Re: [fileupload] dropping the 'tasks' page

2013-03-07 Thread Simone Tripodi
Good, cleaning it right now :) best, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Thu, Mar 7, 2013 at 1:03 PM, sebb wrote: > OK by me > > On 7 March 2013 11:29, Simone Tripodi wrote: >> thoughts?

Re: [fileupload] dropping the 'tasks' page

2013-03-07 Thread sebb
OK by me On 7 March 2013 11:29, Simone Tripodi wrote: > thoughts? :) > > http://people.apache.org/~simonetripodi/ > http://simonetripodi.livejournal.com/ > http://twitter.com/simonetripodi > http://www.99soft.org/ > > > On Wed, Mar 6, 2013 at 4:21 PM, Simone Tripodi > wrote: >> Hi all mates, >>

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-07 Thread Thomas Neidhart
On Thu, Mar 7, 2013 at 10:53 AM, luc wrote: > Le 2013-03-07 10:05, Thomas Neidhart a écrit : > > On Tue, Mar 5, 2013 at 11:08 PM, Thomas Neidhart >> **wrote: >> >> Hi, >>> >>> I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC1. >>> >>> This release candidate has the follow

Re: [fileupload] dropping the 'tasks' page

2013-03-07 Thread Simone Tripodi
thoughts? :) http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Wed, Mar 6, 2013 at 4:21 PM, Simone Tripodi wrote: > Hi all mates, > I am going to drop the 'tasks' page[1] since TODOs are tracked in JIRA. > B

Re: [BeanUtils] Update to Java 1.5 for next release?

2013-03-07 Thread Benedikt Ritter
I have create BEANUTILS-432 [1] for this. [1] https://issues.apache.org/jira/browse/BEANUTILS-432 2013/3/6 Oliver Heger > Am 06.03.2013 13:35, schrieb sebb: > > On 6 March 2013 11:32, Benedikt Ritter wrote: >> >>> Hi, >>> >>> I have recently learned that changing the required Java version fo

Re: [fileupload] Uploading large files - DONE

2013-03-07 Thread Felix Meschberger
Hi Simo Thanks for confirming. Very much appreciated. Regards Felix Am 06.03.2013 um 16:16 schrieb Simone Tripodi: > Hi Felix! > > indeed, we are putting effort on NOT breaking the backwards > compatibility with 1.2.X, we updated to version 1.3 - due to some APIs > update - and I personally pl

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-07 Thread luc
Le 2013-03-07 10:05, Thomas Neidhart a écrit : On Tue, Mar 5, 2013 at 11:08 PM, Thomas Neidhart wrote: Hi, I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC1. This release candidate has the following changes compared to 1.1.1 (copied from the release notes): Fixed Bug

Re: [BeanUtils] Removing @author tags?

2013-03-07 Thread Benedikt Ritter
FYI: Craig is fine with having his authors tags removed from BeanUtils (and any other Apache source code) I'll make the necessary changes this weekend. 2013/3/6 Gary Gregory > On Wed, Mar 6, 2013 at 8:23 AM, Christian Grobmeier >wrote: > > > On Wed, Mar 6, 2013 at 1:01 PM, Gary Gregory > > w

Re: [VOTE] Release of Commons Logging 1.1.2 based on RC1

2013-03-07 Thread Thomas Neidhart
On Tue, Mar 5, 2013 at 11:08 PM, Thomas Neidhart wrote: > Hi, > > I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC1. > > This release candidate has the following changes compared to 1.1.1 > (copied from the release notes): > > Fixed Bugs: > o LOGGING-124: The jar manifest n