Re: Bugs in Apache commons collections, version 4.0

2014-04-10 Thread Dipanjan Laha
Hi, The only issue here is then Collection's equals implementation would need to check individually whether the Collection also implements List, Set or Bag (more such interfaces may come up in the future). This is kind of a hard coupling between Collections equals and other implementations which w

Re: [VOTE] Release Commons Proxy 2.0 based on RC1

2014-04-10 Thread Matt Benson
On Mon, Apr 7, 2014 at 2:50 PM, Matt Benson wrote: > I would like to release Commons Proxy 2.0. > > Commons Proxy 2.0 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/proxy/ (svn revision 4960) > > Maven artifacts are here: > https://repository.apache.

Re: [VOTE] Release Commons Proxy 2.0 based on RC1

2014-04-10 Thread Matt Benson
So is this a +0, +1, abstain...? Thanks, Matt On Wed, Apr 9, 2014 at 2:40 PM, Oliver Heger wrote: > Build works fine with Java 1.7 on Windows 8.1. Artifacts look good. > > The site does a good job in explaining basic principles, but it is > missing some concrete examples how proxy objects can be

Re: svn commit: r1586293 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSequenceUtils.java

2014-04-10 Thread Benedikt Ritter
Nice! 2014-04-10 15:15 GMT+02:00 : > Author: ggregory > Date: Thu Apr 10 13:15:20 2014 > New Revision: 1586293 > > URL: http://svn.apache.org/r1586293 > Log: > Refactor magic number into constant. > > Modified: > > commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/CharSequenceUtil

Re: svn commit: r1586300 - in /commons/proper/codec/trunk/src: changes/ main/java/org/apache/commons/codec/binary/ main/java/org/apache/commons/codec/language/ test/java/org/apache/commons/codec/langu

2014-04-10 Thread Gary Gregory
On Thu, Apr 10, 2014 at 10:14 AM, sebb wrote: > On 10 April 2014 14:51, wrote: > > Author: ggregory > > Date: Thu Apr 10 13:51:06 2014 > > New Revision: 1586300 > > > > URL: http://svn.apache.org/r1586300 > > Log: > > NullPointerException in DoubleMetaPhone.isDoubleMetaphoneEqual when > using e

Re: svn commit: r1586300 - in /commons/proper/codec/trunk/src: changes/ main/java/org/apache/commons/codec/binary/ main/java/org/apache/commons/codec/language/ test/java/org/apache/commons/codec/langu

2014-04-10 Thread sebb
On 10 April 2014 14:51, wrote: > Author: ggregory > Date: Thu Apr 10 13:51:06 2014 > New Revision: 1586300 > > URL: http://svn.apache.org/r1586300 > Log: > NullPointerException in DoubleMetaPhone.isDoubleMetaphoneEqual when > using empty strings > > Added: > > commons/proper/codec/trunk/src

Re: svn commit: r1586283 - /commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/DoubleMetaphoneTest.java

2014-04-10 Thread sebb
On 10 April 2014 13:38, wrote: > Author: ggregory > Date: Thu Apr 10 12:38:15 2014 > New Revision: 1586283 > > URL: http://svn.apache.org/r1586283 > Log: > Sort methods in AB order. -0.9 This really messes up SVN history. Makes it very difficult to use the annotation view. +0 It also changes th

[continuum] BUILD FAILURE: Apache Commons Codec - Apache Commons (Group (shared) Maven 3 Build Definition (Java 1.6))

2014-04-10 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=29092&projectId=70 Build statistics: State: Failed Previous State: Ok Started at: Thu 10 Apr 2014 13:20:11 + Finished at: Thu 10 Apr 2014 13:20:48 + Total time: 36s Build Trigger: Schedule B

Re: Bugs in Apache commons collections, version 4.0

2014-04-10 Thread Julien Aymé
Hi, As specified by Collection#equals(Object) javadoc ( http://docs.oracle.com/javase/7/docs/api/java/util/Collection.html#equals(java.lang.Object) ), equals must be symmetric. That's why Collection.equals(List) must return false, as well as Collection.equals(Set), while Collection.equals(Collecti

Re: Bugs in Apache commons collections, version 4.0

2014-04-10 Thread Dipanjan Laha
Hello, I checked the equals symmetry mismatch issue in https://issues.apache.org/jira/browse/COLLECTIONS-512. I haven't checked the hascode mismatch or any other issue yet. The test in BugReport1_1.java initializes AbstractIterableGetMapDecorator which is meant to be abstract but is not. So imho