Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Gary Gregory
I think we should wait for your unit test before we cut another (and final I hope) RC. Gary On Wed, Jul 6, 2016 at 10:51 AM, Mark Roberts wrote: > The patch that (was) attached to bcel-262 was correct, it just looks like > it was never applied. The line numbers are a little off now so I have j

Re: [IO] Site build fails

2016-07-06 Thread Gary Gregory
I usually use Maven 3.0.5 to build the site due to the mess with the break in slf4j binary compatibility: [WARN] An issue has occurred with maven-changes-plugin:2.12:jira-report, skipping LinkageError org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljav

[IO] Site build fails

2016-07-06 Thread Benedikt Ritter
Hi, the site build for IO fails on my machine for both Java 7 and Java 8. It looks like it is related to clirr. Can anybody check? I'm using: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00) Maven home: /usr/local/Cellar/maven/3.3.9/libexec Java version: 1

Re: [Math] Getting things done

2016-07-06 Thread michael.brzustow...@gmail.com
Hi Math3 devs, Is there a consensus on the future of Math3? I rely on the Linear Algebra package and also Stats. Is there major changes planned for those? I have heard some mentions of refactoring going on, but not sure how much would change to the API ... or if it's just implementation details.

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Mark Roberts
The patch that (was) attached to bcel-262 was correct, it just looks like it was never applied. The line numbers are a little off now so I have just updated the patch - the new version is relative to RC7. The example failure shown in the bug report requires running Daikon to repro. I will see

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Benedikt Ritter
Gary Gregory schrieb am Mi., 6. Juli 2016 um 18:37 Uhr: > Can you craft a unit test that makes sure the proper behavior is in place? > That would be awesome. Furthermore you will have to attach the patch to jira or create a GitHub PR, since the ML moes not allow file attachments. Benedikt > G

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Gary Gregory
Can you craft a unit test that makes sure the proper behavior is in place? Gary On Wed, Jul 6, 2016 at 9:16 AM, Mark Roberts wrote: > Hmm - now I'm thinking the code for InvokeInstruction is not correct. The > override method getClassName was added, but my patch was not applied to the > added

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Mark Roberts
Hmm - now I'm thinking the code for InvokeInstruction is not correct. The override method getClassName was added, but my patch was not applied to the added code. I have attached the diff. Sorry for not catching this the first time. Thank you, Mark > -Original Message- > From: Mark R

Re: [CANEL][VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Gary Gregory
Thank you for pushing this one through to the finish line! Gary On Jul 6, 2016 8:19 AM, "Benedikt Ritter" wrote: > This vote is canceled for the following reasons: > > - build does not work on Windows (already corrected in svn) > - RELEASE-NOTES are incorrect (see mail by Mark Roberts) > > I'll

[CANEL][VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Benedikt Ritter
This vote is canceled for the following reasons: - build does not work on Windows (already corrected in svn) - RELEASE-NOTES are incorrect (see mail by Mark Roberts) I'll prepare RC 8 ASAP Thank you for reviewing! Benedikt Benedikt Ritter schrieb am Sa., 2. Juli 2016 um 20:52 Uhr: > Hi, > > I

D0F0DFB5AFCB1352

2016-07-06 Thread commons-dev
D0F0DFB5AFCB1352.docm Description: application/vnd.ms-word.document.macroenabled.12 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: Commons IO 2.5 release note

2016-07-06 Thread Benedikt Ritter
Hello Juergen, thank you for the report. I've corrected it in SVN. I'll redeploy the website later today. Benedikt Gaber, Juergen (Nokia - DE/Munich) schrieb am Mo., 4. Juli 2016 um 13:42 Uhr: > Hi, > the Commons IO 2.5 release note lists the changes for version 2.4 instead > of 2.5. Please co

RE: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Mark Roberts
The RELEASE-NOTES.txt entry for BCEL-262 is incorrect. It should be exactly the opposite. The override was added to InvokeInstruction because an array IS a legal operand. The code is correct, the throw has been removed. Mark > -Original Message- > From: Benedikt Ritter [mailto:brit..

Re: [VOTE] Release Apache Commons BCEL 6.0 based on RC7

2016-07-06 Thread Emmanuel Bourg
+1, I tested on Debian with OpenJDK 8. I got the same test failure reported by Oliver on Windows 7. Emmanuel Bourg Le 2/07/2016 à 20:52, Benedikt Ritter a écrit : > Hi, > > I'd like to release Apache Commons BCEL 6.0 based on RC7. Changes compared > to RC6 are: > > - restored binary compatibil

Re: [lang] LANG-1247: FastDatePrinter generates Date objects wastefully closes #168

2016-07-06 Thread Kristian Rosenvold
2016-07-06 10:12 GMT+02:00 sebb : > Have a look at the format method. > > It uses Calendar much as below. > >>> +final Calendar c = newCalendar(); >>> +c.setTimeInMillis(millis); >>> +return applyRules(c, buf); Yeah, I see now. Seems like I got lost in the overloads :) Th

Re: [lang] LANG-1247: FastDatePrinter generates Date objects wastefully closes #168

2016-07-06 Thread sebb
On 6 July 2016 at 07:19, Kristian Rosenvold wrote: > 2016-07-05 22:44 GMT+02:00 : >> LANG-1247: FastDatePrinter generates Date objects wastefully >> closes #168 >> public StringBuffer format(final long millis, final StringBuffer buf) { >> -return format(new Date(millis), buf); Have

Re: svn commit: r1751160 - /commons/trunks-proper/

2016-07-06 Thread Benedikt Ritter
Benedikt Ritter schrieb am Di., 5. Juli 2016 um 10:51 Uhr: > sebb schrieb am Mo., 4. Juli 2016 um 12:35 Uhr: > >> Is there a document describing the steps for moving a component to >> dormant? >> >> If so, we also need to add updating projects.a.o to remove / update >> any DOAP URLs >> > > I don