Re: [configuration] Checkstyle settings

2016-07-31 Thread Matt Sicker
Fixing all the checkstyle errors first is kind of a prerequisite to enabling it by default. On 31 July 2016 at 15:10, Charles Honton wrote: > Why wouldn’t we want build to fail early if incorrect style is used? > > chas > > > On Jul 31, 2016, at 11:09 AM, Oliver Heger > wrote: > > > > Hi, > > >

Re: [configuration] Checkstyle settings

2016-07-31 Thread Charles Honton
Why wouldn’t we want build to fail early if incorrect style is used? chas > On Jul 31, 2016, at 11:09 AM, Oliver Heger > wrote: > > Hi, > > in revision 1742698 the checkstyle configuration has been changed. The > log says "fixed checkstyle violations, updated to latest version of > checkstyle

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

2016-07-31 Thread Rob Tompkins
I figured that I would run an analogous test to the original with isParsable and createNumber, and I ran into the following: System.out.println(NumberUtils.isParsable("+2")); > false System.out.println(NumberUtils.createNumber("+2")); ---> 2 I’m not sure if we should tackle that in this Jira

[configuration] Checkstyle settings

2016-07-31 Thread Oliver Heger
Hi, in revision 1742698 the checkstyle configuration has been changed. The log says "fixed checkstyle violations, updated to latest version of checkstyle-maven-plugin, ensure correct checkstyle configuration is applied in all cases". I think with the new configuration checkstyle is now run on eve

Re: [VOTE] Release CRYPTO 1.0.0 based on RC1

2016-07-31 Thread Jochen Wiedmann
A bit late, but here's my +1- On Wed, Jul 27, 2016 at 8:13 PM, Benedikt Ritter wrote: > Hello Dapeng, > > first of all: Great work moving Crypto to Apache Commons and creating your > first release candidate for the Apache Commons Project. I'm very happy to > see this happening and I hope you and

Re: [VOTE] Release DBCP 2.2 based on RC1

2016-07-31 Thread Matt Sicker
Looks like the sidebar on the site needs a link to the 2.2 javadocs. However, there is a link to the javadocs on the home page, so it's not inaccessible. On 31 July 2016 at 07:09, Benedikt Ritter wrote: > Hello Matt, > > good work pushing your first RC at Apache Commons! > > - signs and hashes l

Re: Build failed in Jenkins: commons-imaging #12

2016-07-31 Thread Matt Sicker
There are some filters you can add to exclude all the experimental build slaves. Not sure why they're letting primary builds use them (I'd understand doing it in parallel to the actual builds for testing purposes). On 31 July 2016 at 07:09, Benedikt Ritter wrote: > This is a joke. Currently it l

Re: [All] Please don't commit while repos are moving

2016-07-31 Thread Jochen Wiedmann
On Fri, Jul 29, 2016 at 6:51 PM, Gary Gregory wrote: > Don't commit even to git? That's a different story, of course. But doesn't really match the "while moving" subject, does it? Jochen -- The next time you hear: "Don't reinvent the wheel!" http://www.keystonedevelopment.co.uk/wp-content/up

Re: svn commit: r1754667 - in /commons/proper/fileupload: .project FileuploadNowUsesGit.txt

2016-07-31 Thread Jochen Wiedmann
On Sun, Jul 31, 2016 at 6:02 PM, Benedikt Ritter wrote: > looks like you accedentially commited an IDE file. Fixed. Thanks for the hint, Jochen - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional comman

Re: Moving components to git - what to do with the SVN tree

2016-07-31 Thread Jochen Wiedmann
On Sun, Jul 31, 2016 at 1:14 PM, Benedikt Ritter wrote: > I've talked to infra and they have set up permission so that PMC members > can write to https://svn.apache.org/repos/asf/commons/_moved_to_git The > process of migrating a component to git is now as follows: Thanks for the hint. After the

Re: svn commit: r1754667 - in /commons/proper/fileupload: .project FileuploadNowUsesGit.txt

2016-07-31 Thread Benedikt Ritter
Hi Jochen, looks like you accedentially commited an IDE file. Regards, Benedikt schrieb am So., 31. Juli 2016 um 17:34: > Author: jochen > Date: Sun Jul 31 15:34:53 2016 > New Revision: 1754667 > > URL: http://svn.apache.org/viewvc?rev=1754667&view=rev > Log: > Fileupload has been moved to Git

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

2016-07-31 Thread Rob Tompkins
> On Jul 31, 2016, at 6:23 AM, Benedikt Ritter wrote: > > How about deprecating and renaming? > > isNumber -> isJavaNumberLiteral > createNumber -> parseNumber > > this way there would be a clearer connection between isParsebale and the > method that parses the number. Furthermore it is clear

Re: [VOTE] Release DBCP 2.2 based on RC1

2016-07-31 Thread Benedikt Ritter
Hello Matt, good work pushing your first RC at Apache Commons! - signs and hashes look good - website looks good - build works with Java 7 and Java 8 Minor nits: - release notes don't document minimum required Java version - release pom points to http://svn.apache.org/viewvc/commons/proper/dbcp/

Re: Build failed in Jenkins: commons-imaging #12

2016-07-31 Thread Benedikt Ritter
This is a joke. Currently it looks like you need some luck to get a build slave which can acutally build something. I will talk to infra about our build jobs after my vacation. Benedikt Apache Jenkins Server schrieb am So., 31. Juli 2016 um 14:06 Uhr: > See

Build failed in Jenkins: commons-imaging #12

2016-07-31 Thread Apache Jenkins Server
See Changes: [britter] IMAGING-186: Add sCAL support to PNG reading and writing. Thanks to Ric Emery. This also closes #23 from GitHub. -- [...truncated 511 lines...] A src/main/java/org/a

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-07-31 Thread Benedikt Ritter
Hello Oliver, mvn clean install still fails when building with: Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T18:29:23+01:00) Maven home: /usr/local/Cellar/maven/3.2.5/libexec Java version: 1.6.0_65, vendor: Apple Inc. Java home: /Library/Java/JavaVirtualMachines/1.6.0.

Moving components to git - what to do with the SVN tree

2016-07-31 Thread Benedikt Ritter
Hi, I've talked to infra and they have set up permission so that PMC members can write to https://svn.apache.org/repos/asf/commons/_moved_to_git The process of migrating a component to git is now as follows: - create infra ticket for migration - wait for infra to migrate the code - update SCM loc

Re: [LANG] LANG-1252 - NumberUtils.isNumber and NumberUtils.createNumber resolve inconsistently

2016-07-31 Thread Benedikt Ritter
How about deprecating and renaming? isNumber -> isJavaNumberLiteral createNumber -> parseNumber this way there would be a clearer connection between isParsebale and the method that parses the number. Furthermore it is clearer what isNumber really does. Benedikt Rob Tompkins schrieb am Sa., 30.

Re: commons-csv git commit: [CSV-189] CSVParser: Add factory method accepting InputStream.

2016-07-31 Thread Benedikt Ritter
Nice, thank you! Gary Gregory schrieb am So., 31. Juli 2016 um 01:25: > Nope, not both, fixed as you suggested which matches the ticket title > anyway. > > Gary > > On Sat, Jul 30, 2016 at 12:16 PM, Gary Gregory > wrote: > > > Sure, or provide both? > > > > Gary > > > > On Jul 30, 2016 11:13 AM

Re: [VOTE] Release Configuration 2.1 based on RC2

2016-07-31 Thread Dennis Kieselhorst
+1 Am 30.07.2016 um 22:02 schrieb Oliver Heger: > Hi all, > > after the failed vote for RC1 a new RC has been created. The only > difference is that the checkstyle plugin has been downgraded which > should allow building the project on Java 1.6. > > Configuration 2.1 RC2 is available for review he

Build failed in Jenkins: commons-csv #19

2016-07-31 Thread Apache Jenkins Server
See Changes: [ggregory] [CSV-171] Negative numeric values in the first column are always quoted [ggregory] Add testRfc4180QuoteSingleChar(). -- Started by an SCM change [EnvInject] - Loading node env

Re: [VOTE] Release DBCP 2.2 based on RC1

2016-07-31 Thread Gary Gregory
+1 Tested with: Apache Maven 3.4.0-SNAPSHOT (90f26c279af9738735be8f84f60dcf21b6244e24; 2016-07-22T08:23:04-07:00) Maven home: E:\Java\apache-maven-3.4.0-SNAPSHOT\bin\.. Java version: 1.7.0_79, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_79\jre Default locale: en_US, platf

Jenkins build is back to normal : commons-csv #18

2016-07-31 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org