Re: [lang] new method: ObjectsUtils.equalsOneOf()

2016-08-06 Thread Stian Soiland-Reyes
+1 for the proposal! I think ObjectUtils is a good home, the implied array or collection is an implementation detail. What is your reasoning for null != null ? If you accept a Function to compare with, that would break the varargs mechanism (or always require a Function), perhaps such a

Re: [lang] new method: ObjectsUtils.equalsOneOf()

2016-08-06 Thread Gary Gregory
I think we should stick with the contains prefix. Gary On Aug 6, 2016 2:43 PM, "Paul Benedict" wrote: > Hi Thomas. The only issue I see with introducing a "equalsOneOf" is that it > setups the pondering for other uses... greater than one of, less than one > of, and

Re: [VOTE][RESULT] DBCP 2.2 rc1

2016-08-06 Thread Gary Gregory
Thank you Matt! Gary On Aug 6, 2016 1:55 PM, "Matt Sicker" wrote: > This release has not gained enough +1 votes to pass due to a blocker found > related to OSGi . Voting > record: > > +1 Benedikt Ritter > +1 Oliver Heger > -1

Re: [lang] new method: ObjectsUtils.equalsOneOf()

2016-08-06 Thread Paul Benedict
Hi Thomas. The only issue I see with introducing a "equalsOneOf" is that it setups the pondering for other uses... greater than one of, less than one of, and whatever of one of. With that said, I would rather see the proposed method accept a function/visitor callback to determine the check. If

[VOTE][RESULT] DBCP 2.2 rc1

2016-08-06 Thread Matt Sicker
This release has not gained enough +1 votes to pass due to a blocker found related to OSGi . Voting record: +1 Benedikt Ritter +1 Oliver Heger -1 Gary Gregory -1 Matt Sicker (non-binding) I'll be working on an RC2 this weekend, and hopefully

[lang] new method: ObjectsUtils.equalsOneOf()

2016-08-06 Thread thomas menzel
Hi folks, I'm proposing a new function on ObjectsUtils: /** * Checks if the given {@code ref} is contained at least once in * {@code others}. If {@code} is null or empty then {@code false} is * returned. * * This is a more readable replacement for the

Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

2016-08-06 Thread Emmanuel Bourg
Le 6/08/2016 à 20:46, Dennis E. Hamilton a écrit : > Oh, and is there a JIRA about this (the Math.round contract) or some other > way to tie in whatever scholarship and traceability is involved in the > specialized case of [MATH] software? (I may have missed this - sorry for > asking if

RE: [5/7] [math] Fix "FastMath#round(..)" to comply to changed contract of "Math#round()" in Java 8

2016-08-06 Thread Dennis E. Hamilton
> -Original Message- > From: Gilles [mailto:gil...@harfang.homelinux.org] > Sent: Friday, August 5, 2016 09:11 > To: Commons Developers List > Subject: Re: [5/7] [math] Fix "FastMath#round(..)" to comply to changed > contract of "Math#round()" in Java 8 > > Hi.

Re: [configuration] Checkstyle settings

2016-08-06 Thread Emmanuel Bourg
Le 2/08/2016 à 21:17, Oliver Heger a écrit : > Well, for me style is not that important. (We cannot even agree on a > common style for the Commons project.) Therefore, seeing the violations > in the report is sufficient for me. +1, the build shouldn't fail due to style issues. Emmanuel Bourg