Re: svn commit: r1781587 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java

2017-02-04 Thread Gary Gregory
which of course https://www.youtube.com/watch?v=G2eUopy9sd8 G On Sat, Feb 4, 2017 at 3:22 PM, Gary Gregory wrote: > Good one Matt ;-) > > G > > On Fri, Feb 3, 2017 at 5:06 PM, Matt Sicker wrote: > >> Yup, found it: < >> https://lists.apache.org/thread.html/095664f9bb67602f308cf1a >> 0d492de662

Re: svn commit: r1781587 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java

2017-02-04 Thread Gary Gregory
Good one Matt ;-) G On Fri, Feb 3, 2017 at 5:06 PM, Matt Sicker wrote: > Yup, found it: < > https://lists.apache.org/thread.html/095664f9bb67602f308cf1a0d492de > 662992462314eb1e97fbd34ec6@%3Cdev.commons.apache.org%3E > > > > On 3 February 2017 at 19:05, Matt Sicker wrote: > > > I'm pretty sur

Re: svn commit: r1781587 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java

2017-02-04 Thread Benedikt Ritter
Matt, you just made my day! :-) Matt Sicker schrieb am Sa. 4. Feb. 2017 um 02:07: > Yup, found it: < > > https://lists.apache.org/thread.html/095664f9bb67602f308cf1a0d492de662992462314eb1e97fbd34ec6@%3Cdev.commons.apache.org%3E > > > > On 3 February 2017 at 19:05, Matt Sicker wrote: > > > I'm p

Re: [CONFIGURATION] Ready for 2.2 release?

2017-02-04 Thread Benedikt Ritter
Hello Rob, many thanks for the offer! I have some spare time tomorrow, so I'm probably going to push out RC1 myself. Regards Benedikt Rob Tompkins schrieb am Sa. 4. Feb. 2017 um 15:36: > > > On Feb 3, 2017, at 3:18 PM, Oliver Heger > wrote: > > > > > > > > Am 03.02.2017 um 12:24 schrieb Bened

[GitHub] commons-compress issue #13: BZip2: Use BitInputStream

2017-02-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/commons-compress/pull/13 @thomasmey I've made some minor changes and pushed it to the branch PR13 My benchmarks at https://github.com/bodewig/commons-compress-benchmarks/wiki/PR13 sees the changed code with

[GitHub] commons-compress pull request #16: Don't duplicate count() functionality.

2017-02-04 Thread thomasmey
Github user thomasmey closed the pull request at: https://github.com/apache/commons-compress/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] commons-compress issue #16: Don't duplicate count() functionality.

2017-02-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/commons-compress/pull/16 True, a unit-test wouldn't hurt. I'm afraid I can't close the PR myself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] commons-compress issue #13: BZip2: Use BitInputStream

2017-02-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/commons-compress/pull/13 For starters, https://github.com/bodewig/commons-compress-benchmarks - right now I'm not sure where it'll end up. --- If your project is set up for it, you can reply to this email and have

[GitHub] commons-compress issue #16: Don't duplicate count() functionality.

2017-02-04 Thread thomasmey
Github user thomasmey commented on the issue: https://github.com/apache/commons-compress/pull/16 Oops. True, my mistake. Maybe we should cover this with a unit test... Sorry for the fuss. --- If your project is set up for it, you can reply to this email and have your

[GitHub] commons-compress issue #16: Don't duplicate count() functionality.

2017-02-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/commons-compress/pull/16 Hmm, the no-arg `read` returns the byte read. So when reading an `'A'` your code would count 65 bytes rather than 1, wouldn't it? --- If your project is set up for it, you can reply to this

[GitHub] commons-compress issue #13: BZip2: Use BitInputStream

2017-02-04 Thread bodewig
Github user bodewig commented on the issue: https://github.com/apache/commons-compress/pull/13 I'm planning to set up a JMH based benchmark soonish and would like to get some statistical information before merging this. --- If your project is set up for it, you can reply to this emai

[Commons Wiki] Update of "Compress" by StefanBodewig

2017-02-04 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The "Compress" page has been changed by StefanBodewig: https://wiki.apache.org/commons/Compress?action=diff&rev1=8&rev2=9 Comment: COMPRESS-381 - improve performance by buffering Sa

Jenkins build is back to stable : commons-validator #18

2017-02-04 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Jenkins build is back to stable : commons-validator » Apache Commons Validator #18

2017-02-04 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [CONFIGURATION] Ready for 2.2 release?

2017-02-04 Thread Rob Tompkins
> On Feb 3, 2017, at 3:18 PM, Oliver Heger wrote: > > > > Am 03.02.2017 um 12:24 schrieb Benedikt Ritter: >> Hi, >> >> I need some fixes from trunk in one of my projects. Since I’ve not been >> involved in the development of [CONFIGURATION], I’d like to ask what is >> blocking the 2.2 relea

Jenkins build became unstable: commons-validator #17

2017-02-04 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Jenkins build became unstable: commons-validator » Apache Commons Validator #17

2017-02-04 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org