Re: [IO] Releasing 2.6

2017-09-27 Thread Pascal Schumacher
Strange. I just ran the commons-io test three times on windows 10 and every run was successful. Are you sure that you are not seeing on of the occasional failures that the io test suffer from? Am 27.09.2017 um 00:16 schrieb Gary Gregory: This test fails on Windows: org.apache.commons.io.F

Re: [VOTE] Release Apache Commons JCS 2.2.1

2017-09-27 Thread Romain Manni-Bucau
Have to admit I'm not 100% sure how dist module is intended to work (probably a 2 phases build?) but since we don't deploy it on maven I can probably update it in dist without cancelling the release? That said would need some help for it. Romain Manni-Bucau @rmannibucau

Re: [LOGGING] Release with Java 9 Module support

2017-09-27 Thread Stephen Colebourne
On 27 September 2017 at 00:01, Emmanuel Bourg wrote: > I wonder if we should do the same for commons-lang 2.x, it's still > commonly used. Yes. This would be very helpful Stephen - To unsubscribe, e-mail: dev-unsubscr...@commons

Re: [IO] Releasing 2.6

2017-09-27 Thread sebb
The current Jenkins build uses Windows: https://builds.apache.org/view/A-D/view/Commons/job/commons-io/58/ Last few runs were successful. On 27 September 2017 at 08:46, Pascal Schumacher wrote: > Strange. > > I just ran the commons-io test three times on windows 10 and every run was > successf

[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text

2017-09-27 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/62 Should be able to look again today. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands

[ANNOUNCE] Apache Commons Jelly 1.0.1 released!

2017-09-27 Thread Rob Tompkins
The Apache Commons Team is pleased to announce the release of Apache Commons Jelly 1.0.1. Jelly is a tool for turning XML into executable code. So Jelly is a Java and XML based scripting and processing engine. Jelly can be used as a more flexible and powerful front end to Ant such as in the Mave

[SECURITY] CVE-2017-12621 Apache Commons Jelly connects to URL with custom doctype definitions.

2017-09-27 Thread Rob Tompkins
CVE-2017-12621: Apache Commons Jelly connects to URL with custom doctype definitions. Severity: Medium Vendor: The Apache Software Foundation Versions Affected: commons-jelly-1.0 (core), namely commons-jelly-1.0.jar Description: During Jelly (xml) file parsing with Apache Xerces, if a custom d

Re: [SECURITY] CVE-2017-12621 Apache Commons Jelly connects to URL with custom doctype definitions.

2017-09-27 Thread Benedikt Ritter
I would like to give kudos to Rob for handling this issue. The kind of dedication you put into fixing this issue and releasing a component that has not been touched for ages is what I’m looking for in PMC members. Great work! Benedikt > Am 27.09.2017 um 15:05 schrieb Rob Tompkins : > > CVE-201

Re: [SECURITY] CVE-2017-12621 Apache Commons Jelly connects to URL with custom doctype definitions.

2017-09-27 Thread Gary Gregory
On Wed, Sep 27, 2017 at 8:29 AM, Benedikt Ritter wrote: > I would like to give kudos to Rob for handling this issue. The kind of > dedication you put into fixing this issue and releasing a component that > has not been touched for ages is what I’m looking for in PMC members. > > Great work! > +1

Re: [COLLECTIONS] Test failures on Windows

2017-09-27 Thread Gary Gregory
Using git master and 'mvn clean verify', on Windows 10, with Java 7, I get 44 failures, and I think this is all/mostly hash code problems. With Java 8, all tests pass. With Java 9, I get ONE failure: ListIteratorWrapperTest.testRemove:116 ╗ ServiceConfiguration sun.util.locale If I checkout

Re: [IO] Releasing 2.6

2017-09-27 Thread Gary Gregory
I fixed that failure with some Git magic. Gary On Wed, Sep 27, 2017 at 12:32 AM, Benedikt Ritter wrote: > > > Am 27.09.2017 um 00:16 schrieb Gary Gregory : > > > > This test fails on Windows: > > Can’t we just drop Windows support? :( > > Do you have some time to investigate this? > > Cheers, >

Re: [IO] Releasing 2.6

2017-09-27 Thread Gary Gregory
But I am also seeing random failures trying to set up and teardown the test directory. For example: java.lang.AssertionError: Could not create directory C:\vcs\git\apache\commons\commons-io\target\test_io at org.apache.commons.io.IOUtilsTestCase.setUp(IOUtilsTestCase.java:80) testAsBuffer

Re: [IO] Releasing 2.6

2017-09-27 Thread Gary Gregory
Actually, we should not manage our own test folder, we should let JUnit do with the TemporaryFolder rule... Gary On Wed, Sep 27, 2017 at 11:58 AM, Gary Gregory wrote: > But I am also seeing random failures trying to set up and teardown the > test directory. For example: > > java.lang.AssertionE

Re: [SECURITY] CVE-2017-12621 Apache Commons Jelly connects to URL with custom doctype definitions.

2017-09-27 Thread Pascal Schumacher
I agree this required a lot of dedication/work. Thanks Rob! Am 27.09.2017 um 16:29 schrieb Benedikt Ritter: I would like to give kudos to Rob for handling this issue. The kind of dedication you put into fixing this issue and releasing a component that has not been touched for ages is what I’m

Re: [COLLECTIONS] Test failures on Windows

2017-09-27 Thread Andreas Kuhtz
Hi, I'm running Win7 and with "mvn clean verify". Checkout master. I got the hash code errors, too. But sometimes the tests pass, the next time they failed with 44 failures (the hash code verification). As I'm not sure if my antivirus kicks in and keep some files in the target dir, I ran "mvn cl

[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text

2017-09-27 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/62 As I'm pulling this in this crosses my mind: Wait I'm curious here. Weren't folks leaning towards keeping `RandomStringUtils` in `[lang]`? The thread in question is this one:

Re: [IO] Releasing 2.6

2017-09-27 Thread Pascal Schumacher
Am 27.09.2017 um 19:58 schrieb Gary Gregory: I wonder if we need to force Maven to disable any concurrency when running tests? That should not be necessary. Maven/Maven-Surefire-Plugin does not run test in parallel by default. The surefire configuration of commons-io does not specify the paral

Re: [VOTE] Release Apache Commons JCS 2.2.1

2017-09-27 Thread Thomas Vandahl
On 25.09.17 17:47, Gary Gregory wrote: > -1 > > The file > https://dist.apache.org/repos/dist/dev/commons/jcs/source/commons-jcs-dist-2.2.1-src.zip > does not contain any of the modules folders. > Hi Romain, did you do mvn -Duser.name=rmannibucau -Prelease release:prepare mvn -Duser.name=rm

[GitHub] commons-text issue #64: Minor JavaDoc change for deprecated isDelimiter

2017-09-27 Thread chtompki
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/64 @arunvinudss - would you vote for removing it if we were to roll a, very hypothetical, 2.0 right now? If so, then I'd say we have our decision. --- ---

Re: [SECURITY] CVE-2017-12621 Apache Commons Jelly connects to URL with custom doctype definitions.

2017-09-27 Thread Rob Tompkins
Just glad to help. And, it was fun to learn the CVE process. -Rob > On Sep 27, 2017, at 2:25 PM, Pascal Schumacher > wrote: > > I agree this required a lot of dedication/work. > > Thanks Rob! > > Am 27.09.2017 um 16:29 schrieb Benedikt Ritter: >> I would like to give kudos to Rob for handli

Re: [IO] Releasing 2.6

2017-09-27 Thread Gary Gregory
I updated the tests to use JUnit's TemporaryFolder rule instead of the old custom and _shared_ folder. No more random errors. Gary On Wed, Sep 27, 2017 at 1:05 PM, Pascal Schumacher wrote: > Am 27.09.2017 um 19:58 schrieb Gary Gregory: > >> I wonder if we need to force Maven to disable any conc

Re: [IO] Releasing 2.6

2017-09-27 Thread Pascal Schumacher
Great! That should reduce the number of random test failures. I was just taking a look at this and the usage patterns of the folder looked horrible. :/ Cheers, Pascal Am 27.09.2017 um 21:19 schrieb Gary Gregory: I updated the tests to use JUnit's TemporaryFolder rule instead of the old cust

Re: [VOTE] Release Apache Commons JCS 2.2.1

2017-09-27 Thread Romain Manni-Bucau
Hi Thomas Didn't run the site one yet - was planned post vote - but did the others without the profile since it is configured to be added automatically. Is it an issue? Le 27 sept. 2017 21:06, "Thomas Vandahl" a écrit : On 25.09.17 17:47, Gary Gregory wrote: > -1 > > The file > https://dist.apa

Re: [VOTE] Release Apache Commons JCS 2.2.1

2017-09-27 Thread Thomas Vandahl
On 27.09.17 21:40, Romain Manni-Bucau wrote: > Didn't run the site one yet - was planned post vote - but did the others > without the profile since it is configured to be added automatically. Is it > an issue? It might be. I copied these from my actual shell history, so I know them to work. Bye,

Re: [COLLECTIONS] Test failures on Windows

2017-09-27 Thread Bruno P. Kinoshita
Forgot to mention something important. When I was debugging the hash tests, they would pretty much always pass. But if I ran the tests normally in maven or eclipse they would always fail. Debugging adds a small overhead I think, that could be slowing down some part of the code with a concurrency

[GitHub] commons-text issue #64: Minor JavaDoc change for deprecated isDelimiter

2017-09-27 Thread arunvinudss
Github user arunvinudss commented on the issue: https://github.com/apache/commons-text/pull/64 @chtompki Yes Rob I would definitely vote in the affirmative. Since the functionality provided by that method is trivial I would be surprised if anyone was using it in the first place. --

Re: [VOTE] Release Apache Commons JCS 2.2.1

2017-09-27 Thread Gary Gregory
You really need to publish a site for an RC IMO so I can compare your reports to mine (CLIRR, RAT in particular). Gary On Wed, Sep 27, 2017 at 1:40 PM, Romain Manni-Bucau wrote: > Hi Thomas > > Didn't run the site one yet - was planned post vote - but did the others > without the profile since

Re: [1/3] commons-io git commit: Remove setUp and tearDown methods that are no longer necessary after the switch to the TemporaryFolder rule.

2017-09-27 Thread Gary Gregory
More clean ups! Yes! :-) Gary On Wed, Sep 27, 2017 at 2:23 PM, wrote: > Repository: commons-io > Updated Branches: > refs/heads/master 14b52eb4f -> a43d2fa2f > > > Remove setUp and tearDown methods that are no longer necessary after the > switch to the TemporaryFolder rule. > > > Project: htt

Re: [SECURITY] CVE-2017-12621 Apache Commons Jelly connects to URL with custom doctype definitions.

2017-09-27 Thread Bruno P. Kinoshita
+1 Amazing work Rob! Kudos! Bruno Sent from Yahoo Mail on Android On Thu, 28 Sep 2017 at 0:29, Benedikt Ritter wrote: I would like to give kudos to Rob for handling this issue. The kind of dedication you put into fixing this issue and releasing a component that has not been touched for a

Re: [IO] Releasing 2.6

2017-09-27 Thread Stian Soiland-Reyes
I only got one error on Windows 10 – thanks for the fixes, Pascal and Gary! The new error is: FileSystemUtilsTestCase.testGetFreeSpace_String:89 expected:<1.02861164E8> but was:<1.0286066E8> I have: 5 Dir(s) 104,991,649,792 bytes free Test calls: final long bytes

[GitHub] commons-text issue #62: TEXT-101: Moved RandomStringUtils to Commons-text

2017-09-27 Thread ameyjadiye
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/62 @chtompki , I think all were thinking to deprecate it from lang and so we did. and due to more requests for ```RandomStringUtils``` we came up with the plan to move it also I think since ```