Re: [Net] When should we update net from Java 6 to 7?

2018-01-12 Thread Gilles
On Fri, 12 Jan 2018 21:51:58 +0100, Pascal Schumacher wrote: imho we should drop support for java 6 and make every component java 7+ Why? Just curious to know what to do for "Commons RNG": source is Java 6 compatible and the fairly "low-level" functionality is unlikely to evolve much: only addi

[GitHub] commons-io pull request #53: Modifier 'private' is redundant for enum constr...

2018-01-12 Thread shahabkondri
GitHub user shahabkondri opened a pull request: https://github.com/apache/commons-io/pull/53 Modifier 'private' is redundant for enum constructors. If no access modifier is specified for the constructor of an enum type, the constructor is private. You can merge this pull request in

Re: [Net] When should we update net from Java 6 to 7?

2018-01-12 Thread Pascal Schumacher
imho we should drop support for java 6 and make every component java 7+ Am 12.01.2018 um 18:54 schrieb Gary Gregory: Hi All: When should we update Commons Net from Java 6 to 7? Gary - To unsubscribe, e-mail: dev-unsubscr..

Re: [collections] New iterator/iterable methods

2018-01-12 Thread Matt Sicker
This use case reminds me of how both Scala and Kotlin have structured their collections classes. Here are some comparisons. Kotlin adds a .first() extension function for multiple collection classes: < https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/first.html> Do note the lack of

Lists (was Re: [LANG] Github PR reviews)

2018-01-12 Thread Stefan Bodewig
On 2018-01-12, sebb wrote: > On 12 January 2018 at 16:45, Stefan Bodewig wrote: >> By now we've got two different lists where notifications may end up, >> the github notifications for lang go to issues@commons, those for >> compress go to notifications@commons. > That seems wrong. > IMO > issu

Re: [LANG] Github PR reviews

2018-01-12 Thread sebb
On 12 January 2018 at 16:45, Stefan Bodewig wrote: > On 2018-01-12, Otto Fowler wrote: > >> https://github.com/apache/commons-lang/pull/311 > >> I did not see a mail for it. If someone else *did* see it, then I am sorry. > > https://lists.apache.org/thread.html/fb76f5e54f6f3713c06465539e13100f7e7

Re: [Net] When should we update net from Java 6 to 7?

2018-01-12 Thread sebb
On 12 January 2018 at 17:54, Gary Gregory wrote: > Hi All: > > When should we update Commons Net from Java 6 to 7? What benefit does Java 7 give to the user of the library? > Gary - To unsubscribe, e-mail: dev-unsubscr...@comm

Re: [collections] New iterator/iterable methods

2018-01-12 Thread Gary Gregory
first(Iterator/Iterable) is shorthand for get(Iterator/Iterable, 0), so the Javadocs is much like get(). My current use case is to replace: aSet.iterator().next() with: first(aSet) Gary On Fri, Jan 12, 2018 at 12:43 AM, Claude Warren wrote: > actually last() would probably be more useful.

[Net] When should we update net from Java 6 to 7?

2018-01-12 Thread Gary Gregory
Hi All: When should we update Commons Net from Java 6 to 7? Gary

Re: [lang] new IllegalArgumentException shorcut.

2018-01-12 Thread Gary Gregory
On Fri, Jan 12, 2018 at 10:45 AM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: > Hi Gary, > > we already have Validate#isTrue(boolean expression, String message, > Object... values), which throws an IllegalArgumentException when the > expression is false. > Ah, but that is no good IMO sin

Re: [lang] new IllegalArgumentException shorcut.

2018-01-12 Thread Pascal Schumacher
Hi Gary, we already have Validate#isTrue(boolean expression, String message, Object... values), which throws an IllegalArgumentException when the expression is false. Cheers, Pascal Am 12.01.2018 um 18:30 schrieb Gary Gregory: Hi All: We have code like: throw new IllegalArgumentException(

Re: [LANG] Github PR reviews

2018-01-12 Thread Gary Gregory
I am hoping to find time this weekend to review... Gary On Fri, Jan 12, 2018 at 9:40 AM, Otto Fowler wrote: > https://github.com/apache/commons-lang/pull/311 > > I did not see a mail for it. If someone else *did* see it, then I am > sorry. > > > > On January 12, 2018 at 11:35:00, Gary Gregory

Re: [lang] - Pull Requests containing new StringUtils methods

2018-01-12 Thread Gary Gregory
Hi Pascal, Thank you for tracking these issues. I sprinkled some comments in the PRs. Gary On Fri, Jan 12, 2018 at 9:40 AM, Pascal Schumacher wrote: > Hello everybody, > > currently there are three open pull requests containing new StringUtils > methods: > > 1. astIndexOfAnyChar > > https://g

[lang] new IllegalArgumentException shorcut.

2018-01-12 Thread Gary Gregory
Hi All: We have code like: throw new IllegalArgumentException(String.format("Minimum abbreviation width is %d", minAbbrevWidth)); and I use this pattern a lot. I would like to short cut this as follows: throw IllegalArgumentExceptions.format("Minimum abbreviation width is %d", minAbbrevWidth);

Re: [LANG] Github PR reviews

2018-01-12 Thread Stefan Bodewig
On 2018-01-12, Otto Fowler wrote: > https://github.com/apache/commons-lang/pull/311 > I did not see a mail for it. If someone else *did* see it, then I am sorry. https://lists.apache.org/thread.html/fb76f5e54f6f3713c06465539e13100f7e7dfc6b7874d1bea47c2ab4@%3Cissues.commons.apache.org%3E By now

[lang] - Pull Requests containing new StringUtils methods

2018-01-12 Thread Pascal Schumacher
Hello everybody, currently there are three open pull requests containing new StringUtils methods: 1. astIndexOfAnyChar https://github.com/apache/commons-lang/pull/273 2. extendIfNotBlank/extendIfNotEmpty https://github.com/apache/commons-lang/pull/278 https://issues.apache.org/jira/browse/

Re: [LANG] Github PR reviews

2018-01-12 Thread Otto Fowler
https://github.com/apache/commons-lang/pull/311 I did not see a mail for it. If someone else *did* see it, then I am sorry. On January 12, 2018 at 11:35:00, Gary Gregory (garydgreg...@gmail.com) wrote: We should get emails from GitHub... What is the link to your PR? Gary On Fri, Jan 12, 201

Re: [LANG] Github PR reviews

2018-01-12 Thread Gary Gregory
We should get emails from GitHub... What is the link to your PR? Gary On Fri, Jan 12, 2018 at 6:05 AM, Otto Fowler wrote: > I see that github notices don’t get sent to this list, is there a procedure > to get a pr review? > Asking for a friend ;) > > O >

[LANG] Github PR reviews

2018-01-12 Thread Otto Fowler
I see that github notices don’t get sent to this list, is there a procedure to get a pr review? Asking for a friend ;) O