Re: [ALL][DRAFT] Board report

2018-06-12 Thread Gilles
Hello. On Tue, 12 Jun 2018 16:11:30 -0600, Gary Gregory wrote: Thank you for your review Gilles (more below.) On Tue, Jun 12, 2018 at 3:50 PM Gilles wrote: Hi. On Tue, 12 Jun 2018 12:53:52 -0600, Gary Gregory wrote: > I plan on sending this tomorrow at the latest: > > ## Description: > -

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-12 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 @garydgregory Thank you for the patient answer, I understand. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.

[GitHub] commons-pool pull request #7: Refactor PooledObject and BaseGenericObjectPoo...

2018-06-12 Thread wangyulin
Github user wangyulin closed the pull request at: https://github.com/apache/commons-pool/pull/7 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Apache Commons Text 1.4

2018-06-12 Thread Gary Gregory
The Apache Commons Team is pleased to announce the release of Apache Commons Text 1.4. The Apache Commons Text open source software library provides a host of algorithms focused on working with strings and blocks of text. Source and binary distributions are available for download from the Apache

Re: [DBCP] Release 2.4.0

2018-06-12 Thread Gary Gregory
I will probably cut RC1 tonight or tomorrow. Gary On Sat, Jun 9, 2018 at 9:43 AM Gary Gregory wrote: > Hi All: > > I'd like to release DBCP 2.4.0 ASAP. Please review what you feel like > reviewing... > > Gary >

[GitHub] commons-collections issue #41: Fix checkstyle config.

2018-06-12 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-collections/pull/41 [![Coverage Status](https://coveralls.io/builds/17457126/badge)](https://coveralls.io/builds/17457126) Coverage remained the same at 87.386% when pulling **df3a7ef493a8144

[GitHub] commons-collections pull request #41: Fix checkstyle config.

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/41 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.

[GitHub] commons-collections pull request #41: Fix checkstyle config.

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/41 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.

Re: [ALL][DRAFT] Board report

2018-06-12 Thread Gary Gregory
Thank you for your review Gilles (more below.) On Tue, Jun 12, 2018 at 3:50 PM Gilles wrote: > Hi. > > On Tue, 12 Jun 2018 12:53:52 -0600, Gary Gregory wrote: > > I plan on sending this tomorrow at the latest: > > > > ## Description: > > - Apache Commons is an Apache project focused on all aspe

[GitHub] commons-collections pull request #41: Fix checkstyle config.

2018-06-12 Thread sfuhrm
GitHub user sfuhrm opened a pull request: https://github.com/apache/commons-collections/pull/41 Fix checkstyle config. mvn clean checkstyle:checkstyle was failing. Error was: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:checkstyle (

[GitHub] commons-io pull request #49: [IO-554] fixed: prevent input stream close

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-io/pull/49 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [ALL][DRAFT] Board report

2018-06-12 Thread Gilles
Hi. On Tue, 12 Jun 2018 12:53:52 -0600, Gary Gregory wrote: I plan on sending this tomorrow at the latest: ## Description: - Apache Commons is an Apache project focused on all aspects of reusable Java components. ## Issues: - There are no issues requiring board attention at this time. ##

Re: [DBCP] DelegatingConnection, hashCode(), and equals()

2018-06-12 Thread Gary Gregory
After fixing prepared statements in the cpdsadapter package, I found a cleaner solution that delegates all prepared and callable statement pooling to DBCP's cpdsadapter. Thank you for the feedback. I think I am ready to create an RC for DBCP 2.4.0. Gary On Thu, Jun 7, 2018 at 5:01 PM Gary Grego

[GitHub] commons-collections issue #40: COLLECTIONS-685: IterableUtils has public con...

2018-06-12 Thread sfuhrm
Github user sfuhrm commented on the issue: https://github.com/apache/commons-collections/pull/40 Closing because of breaking the API. May be interesting for commons-cli 5.0. --- - To unsubscribe, e-mail: dev-unsu

[GitHub] commons-collections pull request #40: COLLECTIONS-685: IterableUtils has pub...

2018-06-12 Thread sfuhrm
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/40 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.

[GitHub] commons-collections pull request #40: COLLECTIONS-685: IterableUtils has pub...

2018-06-12 Thread sfuhrm
Github user sfuhrm closed the pull request at: https://github.com/apache/commons-collections/pull/40 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.

[GitHub] commons-collections pull request #37: COLLECTIONS-673: Fix inspired by the G...

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/37 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.

[GitHub] commons-collections pull request #37: COLLECTIONS-673: Fix inspired by the G...

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/37 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.

[GitHub] commons-collections pull request #39: COLLECTIONS-684: Flat3Map: Some test c...

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/39 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.

[GitHub] commons-collections pull request #39: COLLECTIONS-684: Flat3Map: Some test c...

2018-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-collections/pull/39 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.

Re: [all] Regarding pom.xml commons.componentId

2018-06-12 Thread Gary Gregory
Other IDs: Java 9 modules and OSGi bundle names. On Mon, Jun 11, 2018 at 4:28 PM sebb wrote: > On 11 June 2018 at 21:13, Rob Tompkins wrote: > > > > > >> On Jun 11, 2018, at 3:55 PM, Gary Gregory > wrote: > >> > >> The best IMO is “commons.packageId” for "lang3”. > > > > Sounds good….will head

[ALL][DRAFT] Board report

2018-06-12 Thread Gary Gregory
I plan on sending this tomorrow at the latest: ## Description: - Apache Commons is an Apache project focused on all aspects of reusable Java components. ## Issues: - There are no issues requiring board attention at this time. ## Activity: - Activity is medium with the release of 4 components

[VOTE] [RESULT] Release Apache Commons Text 1.4 based on RC1

2018-06-12 Thread Gary Gregory
This VOTE passes with +1's from the following PMC members: - Bruno P. Kinoshita - Pascal Schumacher - Gary Gregory I will proceed with the release. Gary On Tue, Jun 12, 2018 at 11:51 AM Gary Gregory wrote: > My +1 > > Gary > > On Sat, Jun 9, 2018 at 11:49 AM Gary Gregory wrote: > >> We have

Re: [VOTE] Release Apache Commons Text 1.4 based on RC1

2018-06-12 Thread Gary Gregory
My +1 Gary On Sat, Jun 9, 2018 at 11:49 AM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Text 1.3 was released, so I would like to release > Apache Commons Text 1.4. > > Apache Commons Text 1.4 RC1 is available for review her

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-12 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-pool/pull/7 If by "moving" you mean deleting a method from an interface, that would break binary compatibility, which we cannot do outside of a major release (where we would change the package name and

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-12 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 @garydgregory In fact, the intention is to move the startEvictionTest and endEvictionTest methods from PooledObject to BaseGenericObjectPool, because eviction is the operation of ObjectPool, n

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-12 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 In fact, the intention is to move the startEvictionTest and endEvictionTest methods from PooledObject to BaseGenericObjectPool, because eviction is the operation of ObjectPool, not the operatio

[DBCP] test code coverage

2018-06-12 Thread Gary Gregory
Hi All, Jacoco reports that our code coverage is not great here. Does anyone want to help improve the situation? Gary

[DBCP] UML sources

2018-06-12 Thread Gary Gregory
Hi All: Where are the UML sources for the GIF files? I'd like to regenerate them. Or was this done straight from Java sources with some Eclipse or IDEA plugin? Gary

Re: [jira] [Commented] (IO-579) FilenameUtils.isExtension() is case-sensitive

2018-06-12 Thread Gary Gregory
On Tue, Jun 12, 2018 at 4:25 AM Jochen Wiedmann wrote: > On Fri, Jun 8, 2018 at 5:07 PM Gary Gregory (JIRA) > wrote: > > > Case-sensitivity for file names depends on the file system. The Javadoc > for this method specifies "The extension check is case-sensitive on all > platforms." There is noth

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-12 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-pool/pull/7 Right, we cannot add method to existing interfaces outside of a major release. --- - To unsubscribe, e-mail: dev-unsubsc

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-12 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 **Check checkAPIcompatibility failed:** - org.apache.commons.pool2.PooledObject: Method 'public void setState(org.apache.commons.pool2.PooledObjectState)' has been added to an inte

Re: [jira] [Commented] (IO-579) FilenameUtils.isExtension() is case-sensitive

2018-06-12 Thread Jochen Wiedmann
On Fri, Jun 8, 2018 at 5:07 PM Gary Gregory (JIRA) wrote: > Case-sensitivity for file names depends on the file system. The Javadoc for > this method specifies "The extension check is case-sensitive on all > platforms." There is nothing to fix in this API IMO. To me, this sounds like a strong