[numbers-primes] Improving trial division code and algorithm

2019-06-03 Thread Heinrich Bohne
I have been advised to raise this improvement suggestion on the developers' mailing list. It is about the trial division algorithm in the method SmallPrimes.boundedTrialDivision(int, int, List) in the primes module. Currently, this algorithm skips multiples of 2 and 3 as trial candidates, which

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Bruno P. Kinoshita
  [x] +1 Release these artifacts Build passing with `mvn clean test site -P !setup-checkout` on Ubuntu LTS and Windows 10 Pro and Java 8. Reports look OK with issues that can/need to be fixed later. CheersBruno On Monday, 3 June 2019, 10:55:58 pm NZST, Gary Gregory wrote: Hi Bruno,

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Alex Herbert
> On 3 Jun 2019, at 21:44, Gary Gregory wrote: > > On Mon, Jun 3, 2019 at 3:49 PM Alex Herbert > wrote: > >> >> >>> On 3 Jun 2019, at 18:47, Alex Herbert wrote: >>> >>> >>> On 3 Jun 2019, at 15:11, Gary Gregory > garydgreg...@gmail.com>> wrote: On Mon, Jun 3, 2019 at

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Gary Gregory
On Mon, Jun 3, 2019 at 3:49 PM Alex Herbert wrote: > > > > On 3 Jun 2019, at 18:47, Alex Herbert wrote: > > > > > > > >> On 3 Jun 2019, at 15:11, Gary Gregory garydgreg...@gmail.com>> wrote: > >> > >> On Mon, Jun 3, 2019 at 9:07 AM Gary Gregory > wrote: > >> >

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Gary Gregory
My +1 Gary On Sat, Jun 1, 2019 at 8:31 PM Gary Gregory wrote: > We have fixed quite a few bugs and added some enhancements since Apache > Commons CSV 1.6 was released, so I would like to release Apache Commons CSV > 1.7. > > Apache Commons CSV 1.7 RC1 is available for review here: >

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Alex Herbert
> On 3 Jun 2019, at 18:47, Alex Herbert wrote: > > > >> On 3 Jun 2019, at 15:11, Gary Gregory > > wrote: >> >> On Mon, Jun 3, 2019 at 9:07 AM Gary Gregory > > wrote: >> >>> On Mon, Jun 3, 2019 at 9:00 AM Alex Herbert >>

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Alex Herbert
> On 3 Jun 2019, at 15:11, Gary Gregory wrote: > > On Mon, Jun 3, 2019 at 9:07 AM Gary Gregory > wrote: > >> On Mon, Jun 3, 2019 at 9:00 AM Alex Herbert >> wrote: >> >>> >>> On 03/06/2019 12:12, Gary Gregory wrote: What about disabling the site-checkout

Fwd: Is there any reasons for there being 8 ArrayUtil#isEmpty functions?

2019-06-03 Thread Xeno Amess
-- Forwarded message - 发件人: Xeno Amess Date: 2019年6月4日周二 上午12:07 Subject: Re: Is there any reasons for there being 8 ArrayUtil#isEmpty functions? To: dev-subscr...@commons.apache.org and notice that there be only one getLength function in ArrayUtils. public static int

[rng] Update ProviderBuilder factory methods

2019-06-03 Thread Alex Herbert
Can I get a review of a PR that changes the ProviderBuilder [1]? The aim is to move the creation of the seed and the RNG into the RandomSourceInternal. This allows for customisation of the seed creation on a per-RNG basis. The reason is that some new generators in the library for v1.3

Re: [lang] Giant StringUtils vs. NullSafeStrings.

2019-06-03 Thread Gary Gregory
On Wed, May 29, 2019 at 8:07 AM Gary Gregory wrote: > On Tue, May 28, 2019 at 5:04 PM Mark Dacek wrote: > >> I’m a bit curious on the desire to split it out. I’m not hard opposed but >> also don’t know that it would save much time or clarify things for most. I >> wouldn’t want to say that this

Re: [ALL] Issues with Git repos: bad HEADs and unexpected refs - need Git guru

2019-06-03 Thread Gary Gregory
Did we git guru ourselves out of all of these? Gary On Wed, May 29, 2019 at 9:39 AM sebb wrote: > I noticed that JCS still has a trunk branch and that appears to be the > default, so I did a check of all the commons git repos. > > The command used is: > > git ls-remote #{repo} HEAD master

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Gary Gregory
On Mon, Jun 3, 2019 at 9:07 AM Gary Gregory wrote: > On Mon, Jun 3, 2019 at 9:00 AM Alex Herbert > wrote: > >> >> On 03/06/2019 12:12, Gary Gregory wrote: >> > What about disabling the site-checkout profile like this: >> > >> > mvn clean install site -Pjacoco -P!setup-checkout >> >> That works

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Gary Gregory
On Mon, Jun 3, 2019 at 9:00 AM Alex Herbert wrote: > > On 03/06/2019 12:12, Gary Gregory wrote: > > What about disabling the site-checkout profile like this: > > > > mvn clean install site -Pjacoco -P!setup-checkout > > That works (with the following escape for a bash shell): > > mvn clean

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Alex Herbert
On 03/06/2019 12:12, Gary Gregory wrote: What about disabling the site-checkout profile like this: mvn clean install site -Pjacoco -P!setup-checkout That works (with the following escape for a bash shell): mvn clean install site -Pjacoco -P \!setup-checkout ? Gary On Mon, Jun 3, 2019 at

Re: [Commons][Descriptive][STATISTICS-7][GSoC] SummaryStatistics class design & Whether to use DoubleSummaryStatistics class from java.util package?

2019-06-03 Thread Gilles Sadowski
Hello. Side note: Top-posting is quite annoying in these discussions... Le dim. 2 juin 2019 à 21:27, Eric Barnhill a écrit : > > As discussed on prior threads you should have both. There will need to be > static convenience methods for a user who wants to make a very simple call, > say

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Gary Gregory
What about disabling the site-checkout profile like this: mvn clean install site -Pjacoco -P!setup-checkout ? Gary On Mon, Jun 3, 2019 at 7:06 AM Alex Herbert wrote: > Hi Gary, > > I've just tried on my Linux setup and get the same error as Bruno. All > tests pass but the site build doesn't

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Alex Herbert
Hi Gary, I've just tried on my Linux setup and get the same error as Bruno. All tests pass but the site build doesn't work. mvn -v Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T19:41:47+01:00) Maven home: /usr/local/apache-maven-3.6.0 Java version: 1.8.0_212,

Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1

2019-06-03 Thread Gary Gregory
Hi Bruno, Hm, that is odd. You are building on Linux or MacOS? I am on Windows 10 and I used 'mvn clean install site -Pjacoco' Can you try the above? Gary On Sun, Jun 2, 2019 at 9:09 PM Bruno P. Kinoshita wrote: > Java 8 on Ubuntu LTS, `mvn clean test` passes OK. But I'm not able to >