Re: [configuration] review for PR 30

2019-07-01 Thread Gary Gregory
On Mon, Jul 1, 2019 at 6:46 PM Emmanuel Bourg wrote: > Le 01/07/2019 à 16:26, Gary Gregory a écrit : > > > May anyone that knows enough of the internals of [configuration] please > > comment on https://github.com/apache/commons-configuration/pull/30 > > I got a quick look, besides the

Re: [configuration] review for PR 30

2019-07-01 Thread Emmanuel Bourg
Le 01/07/2019 à 16:26, Gary Gregory a écrit : > May anyone that knows enough of the internals of [configuration] please > comment on https://github.com/apache/commons-configuration/pull/30 I got a quick look, besides the setArrayProperty method that doesn't seem to have the right name (there is

Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-01 Thread Gilles Sadowski
Hello. Le lun. 1 juil. 2019 à 20:23, Heinrich Bohne a écrit : > > > Is there a case where *not* knowing whether the fraction is reduced or > > not is detrimental? > > Hm, maybe you're right and specifying this (as well as where the sign is > stored) in the public API is not that important, as

Re: [GSoC][Commons][Statistics][Descriptive] Should Standard Deviation extend Variance & Variance extend Moment class?

2019-07-01 Thread Gilles Sadowski
Le lun. 1 juil. 2019 à 22:47, Alex Herbert a écrit : > > Re-sent to list. > > > On 1 Jul 2019, at 18:49, Gilles Sadowski wrote: > > > > Le lun. 1 juil. 2019 à 19:10, Alex Herbert > > a écrit : > >> > >> On 01/07/2019 08:59, Gilles Sadowski wrote: > >>> Hello. >

Re: [GSoC][Commons][Statistics][Descriptive] Should Standard Deviation extend Variance & Variance extend Moment class?

2019-07-01 Thread Alex Herbert
Re-sent to list. > On 1 Jul 2019, at 18:49, Gilles Sadowski wrote: > > Le lun. 1 juil. 2019 à 19:10, Alex Herbert > a écrit : >> >> On 01/07/2019 08:59, Gilles Sadowski wrote: >>> Hello. >>> >>> Le lun. 1 juil. 2019 à 00:50, Virendra singh Rajpurohit >>> a

Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-01 Thread Heinrich Bohne
Is there a case where *not* knowing whether the fraction is reduced or not is detrimental? Hm, maybe you're right and specifying this (as well as where the sign is stored) in the public API is not that important, as long as the combination of returned numerator and denominator is valid. The

Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-01 Thread Gilles Sadowski
Hello. Le lun. 1 juil. 2019 à 12:35, Heinrich Bohne a écrit : > > > Couldn't it entail a loss of opportunity to allow "non-reduced" fractions > > for efficiency reason? > > Yes, it would, but I can't envision a scenario where this would be > detrimental. Of course, I may be missing something.

Re: [VOTE] Release Apache Commons Text 1.7 based on RC1

2019-07-01 Thread Rob Tompkins
Reports good; specifically, japicmp good, rat good; signatures good; builds on java8 and java11 with “mvn clean test install site.” +1 > On Jun 30, 2019, at 10:28 AM, Gary Gregory wrote: > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Text 1.6

Re: [VOTE] Release Apache Commons Daemon 1.2.0 RC2

2019-07-01 Thread Rob Tompkins
+1, reports good, signatures good, agree with Gary on builds. -Rob > On Jun 28, 2019, at 10:20 AM, Mark Thomas wrote: > > It has been ~18 months since the last Commons Daemon release. After the > recent flurry of activity and a couple of failed RCs, it is time for > another release vote. > >

[configuration] review for PR 30

2019-07-01 Thread Gary Gregory
Hi All: May anyone that knows enough of the internals of [configuration] please comment on https://github.com/apache/commons-configuration/pull/30 ? Gary

Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-01 Thread Heinrich Bohne
Couldn't it entail a loss of opportunity to allow "non-reduced" fractions for efficiency reason? Yes, it would, but I can't envision a scenario where this would be detrimental. Of course, I may be missing something. But I don't follow; if it's an implementation detail, it should not appear

Re: [GSoC][Commons][Statistics][Descriptive] Should Standard Deviation extend Variance & Variance extend Moment class?

2019-07-01 Thread Gilles Sadowski
Hello. Le lun. 1 juil. 2019 à 00:50, Virendra singh Rajpurohit a écrit : > > Hi everyone, > I've been working on descriptive module of "Commons-Statistics". My > question is should I extend I'll give hints as if the question mark was after the word "extend". For starter, please read this:

Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-01 Thread Gilles Sadowski
Hi. Le lun. 1 juil. 2019 à 03:52, Heinrich Bohne a écrit : > > I've recently been wondering about the following: > > With the resolution of NUMBERS-119 > (https://issues.apache.org/jira/browse/NUMBERS-119), all constructors in > Fraction and BigFraction reduce the created fraction to lowest