Hi Claude and all:
Here are a couple of comments on the bloom filter PR.
10,100 ft level comment we do not have to worry about today: Before the
release, we might want to split Commons Collection into a multi-module
project and have the BF code in it own module. The _main_ reason for this
is
It certainly is not obvious from looking at the JRE method that calling
toArray this way is faster... some // comments would be nice.
Gary
On Thu, Dec 26, 2019 at 7:25 PM sebb wrote:
> Also, where is it documented that modern JVMs are faster?
> To which JVMs does this apply?
>
> S.
>
> On Thu,
Also, where is it documented that modern JVMs are faster?
To which JVMs does this apply?
S.
On Thu, 26 Dec 2019 at 22:08, Gary Gregory wrote:
> Please do not cause garbage to apparently be generated all over the place
> by creating new empty arrays all the time. Use the constants Commons Lang
Please do not cause garbage to apparently be generated all over the place
by creating new empty arrays all the time. Use the constants Commons Lang
constants already defines; see ArrayUtils.
Gary
On Thu, Dec 26, 2019 at 4:48 PM wrote:
> This is an automated email from the ASF dual-hosted git
For the contributions and issues I was involved in, the javadoc appear to
be correct.
Claude
On Thu, Dec 26, 2019 at 1:30 PM Gary Gregory wrote:
> It looks like we will need a new version of Commons Codec out before we can
> use new code there from Commons Collections. So now's the time to
+1
I couldn’t get java 11 to fully build the site. I recall that being an ongoing
problem with VFS, but the main run does indeed work with java 11 so the package
runs effectively on java 11. The rest of everything checks out appropriately,
signatures, rat, reports.
-Rob
> On Dec 25, 2019, at
Working on this validation now. -Rob
> On Dec 25, 2019, at 3:32 PM, Gary Gregory wrote:
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons VFS 2.4.1 was released, so I would like to release
> Apache Commons VFS Project 2.5.0.
>
> Apache Commons
It looks like we will need a new version of Commons Codec out before we can
use new code there from Commons Collections. So now's the time to polish,
PR, and so on.
If you've contributed code to Codec, please make sure the Javadoc are
helpful and the site up to date.
Thank you!
Gary