Re: [NUMBERS-96][GSoC-2020] Port and redevelop interpolation libraries from commons-math

2019-12-28 Thread Gilles Sadowski
Hi. 2019-12-28 19:59 UTC+01:00, Rishabh Budhouliya : > Hi everyone, > > I would like to know two things: > > 1) Which ported module/classes should I read and compare from commons-math > to understand the architectural decisions taken to use lambda functions, > streams etc all the FP paradigms in

Re: [codec] release soon

2019-12-28 Thread Gary Gregory
It looks like public methods have been removed from org.apache.commons.codec.digest.MurmurHash3$IncrementalHash32, These need to go back in to maintain binary compatibility. Then we can have a release candidate. Gary On Fri, Dec 27, 2019 at 7:02 PM Gary Gregory wrote: > On Fri, Dec 27, 2019 at

Re: [numbers] Complex missing some C++ standards

2019-12-28 Thread Gilles Sadowski
Hi. 2019-12-29 1:15 UTC+01:00, Alex Herbert : > > >> On 21 Dec 2019, at 11:42, Gilles Sadowski wrote: >> >>> ... >> >> So, would you suggest that no "Number"-like class should ever throw >> an exception (but instead return the equivalent of "Double.NaN”)? > > Yes. As it was the method could

Re: [commons-lang] branch master updated: Use Collection#toArray(new T[0]) instead of a presized array as it is faster on modern JVMs.

2019-12-28 Thread sebb
On Fri, 27 Dec 2019 at 17:43, Matt Sicker wrote: > It's somewhat logical, though, that T[0] is faster than T[size]. In > both cases, the given array is checked to see if it's large enough to > fit the collection contents. If it isn't, then a new array is > allocated. By deferring the new array

Re: [numbers] Complex missing some C++ standards

2019-12-28 Thread Alex Herbert
> On 21 Dec 2019, at 11:42, Gilles Sadowski wrote: > >> ... > > So, would you suggest that no "Number"-like class should ever throw > an exception (but instead return the equivalent of "Double.NaN”)? Yes. As it was the method could throw for some invalid input and not others. This is

[RESULT][VOTE] Release Apache Commons VFS Project 2.5.0 based on RC1

2019-12-28 Thread Gary Gregory
This VOTE passes with the following +1s: - Eitan Adler, non-binding - Rob Tompkins, binding - Bruno P. Kinoshita, binding - Gary Gregory, binding Thank you all for taking the time to review this release candidate. Gary On Wed, Dec 25, 2019 at 3:32 PM Gary Gregory wrote: > We have fixed quite

Re: [commons-codec] branch master updated: Change AssertionError to IllegalStateException

2019-12-28 Thread Gary Gregory
You can recover from an exception, errors you are not supposed to... Gary On Sat, Dec 28, 2019, 13:53 Matt Sicker wrote: > Aren’t Errors supposed to be fatal exceptions that are generally only > caught by exception handlers rather than by calling code? Think > OutOfMemoryError or

[NUMBERS-96][GSoC-2020] Port and redevelop interpolation libraries from commons-math

2019-12-28 Thread Rishabh Budhouliya
Hi everyone, I would like to know two things: 1) Which ported module/classes should I read and compare from commons-math to understand the architectural decisions taken to use lambda functions, streams etc all the FP paradigms in common-numbers? 2) Is this project still up for GSoC 2020? I

Re: [commons-codec] branch master updated: Change AssertionError to IllegalStateException

2019-12-28 Thread Matt Sicker
Aren’t Errors supposed to be fatal exceptions that are generally only caught by exception handlers rather than by calling code? Think OutOfMemoryError or StackOverflowError. On Sat, Dec 28, 2019 at 11:35 Miguel Munoz wrote: > I can't look at the code right now, but I would use an >

Re: [commons-codec] branch master updated: Change AssertionError to IllegalStateException

2019-12-28 Thread Miguel Munoz
I can't look at the code right now, but I would use an IllegalStateException if the problem is caused by a user error. I would use an AssertionError if the problem is caused by a defect in the implementation. -- Miguel Muñoz On Friday, December 27, 2019, 5:45:58 PM PST, Gary Gregory

Re: [VOTE] Release Apache Commons VFS Project 2.5.0 based on RC1

2019-12-28 Thread Gary Gregory
My +1 Gary On Wed, Dec 25, 2019 at 3:32 PM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons VFS 2.4.1 was released, so I would like to release > Apache Commons VFS Project 2.5.0. > > Apache Commons VFS Project 2.5.0 RC1 is

Re: [commons-codec] branch master updated: Change AssertionError to IllegalStateException

2019-12-28 Thread Claude Warren
Wherever the note is found the javadoc should include * This implementation contains a sign-extension bug in the seed initialization. * This manifests if the seed is negative. On Sat, Dec 28, 2019 at 1:45 AM Gary Gregory wrote: > On Fri, Dec 27, 2019 at 8:17 PM wrote: > > > This is

Re: [collections] bloom filters comments

2019-12-28 Thread Claude Warren
Once the interface is extracted and reduced to the minimum necessary the following methods are removed: orCardinality() -- we have andCardinality() and xorCardinality() this was included for completeness. isFull() -- true if all the bits in the vector are on. A convenience method used to short