Re: [geometry] Rename Transform to AffineTransform

2020-01-08 Thread Gilles Sadowski
Hi. Le mer. 8 janv. 2020 à 04:39, Matt Juntunen a écrit : > > Gilles, > > > I thought that the question was how to replace "transform"... > > I should probably clarify. I want to change the name of the Transform class > to make it clear that it only represents transforms that preserve parallelis

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

2020-01-08 Thread Gary Gregory
On Tue, Jan 7, 2020 at 12:12 AM Carl Hall wrote: > Thanks for the reviews, Gary and Bruno. And thanks, Gary, for giving such > a sharp eye to the broader range of code. I'll work through the suggestions > in this thread, and clear everything up for the next RC. > Good news :-) Gary > > > > On

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

2020-01-08 Thread Gary Gregory
You should reply to this thread with [CANCEL] in the subject to make it clear this VOTE is canceled. Gary On Wed, Jan 8, 2020 at 8:30 AM Gary Gregory wrote: > On Tue, Jan 7, 2020 at 12:12 AM Carl Hall wrote: > >> Thanks for the reviews, Gary and Bruno. And thanks, Gary, for giving such >> a sh

Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

2020-01-08 Thread Rob Tompkins
> On Jan 8, 2020, at 8:31 AM, Gary Gregory wrote: > > You should reply to this thread with [CANCEL] in the subject to make it > clear this VOTE is canceled. Yes…good call. > > Gary > > On Wed, Jan 8, 2020 at 8:30 AM Gary Gregory wrote: > >> On Tue, Jan 7, 2020 at 12:12 AM Carl Hall wrot

Re: [collections] bloom filters comments

2020-01-08 Thread Gary Gregory
I think it is time to bring this PR in and make any adjustments within master beyond that. This will be quicker and simpler than going round and round for simple things like Javadoc tweaks and small non-functional changes (formatting, variable names, and so on.) I'll proceed with that tonight. Gar

Re: [collections] bloom filters comments

2020-01-08 Thread Gilles Sadowski
Le mer. 8 janv. 2020 à 15:15, Gary Gregory a écrit : > > I think it is time to bring this PR in and make any adjustments within > master beyond that. This will be quicker and simpler than going round and > round for simple things like Javadoc tweaks and small non-functional > changes (formatting,

Re: [collections] bloom filters comments

2020-01-08 Thread Claude Warren
I believe the issue (I think history is at https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17003600) is about the identification of hash implementations. Currently there are a couple of classes involved:

Re: [VOTE] Release Apache Commons VFS Project 2.6.0 based on RC1

2020-01-08 Thread Rob Tompkins
Everything over here looks good. -Rob > On Jan 7, 2020, at 3:41 AM, Bruno P. Kinoshita > wrote: > > [x] +1 Release these artifacts > > Build passing on Java 8, Ubuntu LTS. Checked dist area and maven signatures, > found no issues. Nothing wrong with zip sources file as well (RELEASE-NOTES

Re: [VOTE] Release Apache Commons VFS Project 2.6.0 based on RC1

2020-01-08 Thread Rob Tompkins
+1 > On Jan 8, 2020, at 3:44 PM, Rob Tompkins wrote: > > Everything over here looks good. > > -Rob > >> On Jan 7, 2020, at 3:41 AM, Bruno P. Kinoshita >> wrote: >> >> [x] +1 Release these artifacts >> >> Build passing on Java 8, Ubuntu LTS. Checked dist area and maven signatures, >> foun

Re: [VOTE] Release Apache Commons VFS Project 2.6.0 based on RC1

2020-01-08 Thread Gary Gregory
On Wed, Jan 8, 2020 at 3:45 PM Gary Gregory wrote: > Hi Rob, > > Are you still evaluating? If not, you need to clearly state +1 or > something else ;-) > Ah!, you best me to it :-) Gary > > TY, > Gary > > On Wed, Jan 8, 2020 at 3:44 PM Rob Tompkins wrote: > >> Everything over here looks good

Re: [VOTE] Release Apache Commons VFS Project 2.6.0 based on RC1

2020-01-08 Thread Gary Gregory
Hi Rob, Are you still evaluating? If not, you need to clearly state +1 or something else ;-) TY, Gary On Wed, Jan 8, 2020 at 3:44 PM Rob Tompkins wrote: > Everything over here looks good. > > -Rob > > > On Jan 7, 2020, at 3:41 AM, Bruno P. Kinoshita < > brunodepau...@yahoo.com.br.INVALID> wrot

Re: [collections] bloom filters comments

2020-01-08 Thread Bruno P. Kinoshita
Thanks for the summary Claude. I read some of the messages, but got lost in the middle of the discussion, and tend to understand problems better if there's some code to read along. And I am used to GitHub/GitLab diff interface. So I agree with Gary that this could be a good time for a PR (maybe

Re: [collections] bloom filters comments

2020-01-08 Thread Claude Warren
There is a pull request open: https://github.com/apache/commons-collections/pull/83 On Wed, Jan 8, 2020 at 9:32 PM Bruno P. Kinoshita wrote: > Thanks for the summary Claude. I read some of the messages, but got lost > in the middle of the discussion, and tend to understand problems better if >

Re: [dbutils] 2_0 branch discussion

2020-01-08 Thread Bill Speirs
Everything is as up-to-date as I can tell... just submitted a few merges: https://gitbox.apache.org/repos/asf?p=commons-dbutils.git;a=commit;h=31deec7a232bacb1204c86788939afaac101b0ef Bill- On Sun, Jan 5, 2020 at 1:12 PM Carl Hall wrote: > Thanks for merging that in. Since 2.0 RC1 was cut, ther

Re: [collections] bloom filters comments

2020-01-08 Thread Bruno P. Kinoshita
Sorry, I'd read Gary's reply as if there was no PR yet. Reviewed it a bit now, lots of tests! Will play with the code and read the comments and finish the review by the end of the week. Thanks Claude On Thursday, 9 January 2020, 11:20:40 am NZDT, Claude Warren wrote: There is a pull

[CANCEL] Re: [VOTE] Release Apache Commons DbUtils 1.8 based on RC1

2020-01-08 Thread Carl Hall
Ah, thanks for the suggestion. RC2 vote coming soon. > On Jan 8, 2020, at 5:52 AM, Rob Tompkins wrote: > > > >> On Jan 8, 2020, at 8:31 AM, Gary Gregory > > wrote: >> >> You should reply to this thread with [CANCEL] in the subject to make it >> clear this VOTE i

[VOTE] Release Apache Commons DbUtils 1.8 based on RC2

2020-01-08 Thread Carl Hall
We have fixed quite a few bugs and added some significant enhancements since Apache Commons DbUtils 1.7 was released, so I would like to release Apache Commons DbUtils 1.8. RC2 handles closing connections only when owned, and addresses generated javadoc, NOTICE year update, and release notes de