Re: [geometry] PMD failures

> On 18 Feb 2020, at 03:06, Matt Juntunen wrote: > > Hi Alex, > > Thanks for the updates on this. FYI, the current geometry build fails due to > a missing import: > https://travis-ci.org/apache/commons-geometry/jobs/651768129#L3806. Sorry. I blindly trusted my IDE to clean-up the code to

Re: [numbers] Release?

Gilles, > Anyways, +1 to making beta releases, even while still working > on features that we want in version 1.0 "non-beta". What are the next steps for this? -Matt From: Gilles Sadowski Sent: Thursday, February 13, 2020 10:27 AM To: Commons Developers List

Re: [geometry] PMD failures

Hi Alex, Thanks for the updates on this. FYI, the current geometry build fails due to a missing import: https://travis-ci.org/apache/commons-geometry/jobs/651768129#L3806. -Matt From: Alex Herbert Sent: Monday, February 17, 2020 7:18 PM To: Commons Developers

[geometry] PMD failures

I’ve just updated PMD and checkstyle on [rng], [numbers] and [geometry]. After a few glitches I have fixed [rng] and [numbers]. [geometry] has a lot of PMD issues: [INFO] You have 64 PMD violations. For more details see: /Users/ah403/git/commons-geometry/commons-geometry-core/target/pmd.xml

Re: [collections] Bloom filters

> On 17 Feb 2020, at 20:30, Claude Warren wrote: > > Alex, > > Thank you for your comments. > > See comments inline. > > > > On Mon, Feb 17, 2020 at 3:20 PM Alex Herbert > > wrote: > >> I had a look through all the BloomFilter code. Thanks Claude for the

Re: [collections] Bloom filters

Alex, Thank you for your comments. See comments inline. On Mon, Feb 17, 2020 at 3:20 PM Alex Herbert wrote: > I had a look through all the BloomFilter code. Thanks Claude for the > contribution. > > Some items that need clarifying: > > > 1. HashFunctionIdentity.Signedness > > This is not

[collections] Bloom filters

I had a look through all the BloomFilter code. Thanks Claude for the contribution. Some items that need clarifying: 1. HashFunctionIdentity.Signedness This is not fully documented as to what the sign applies to. There is no javadoc on the enum values for SIGNED and UNSIGNED. The current